fix: add legacy aiox-core wrapper - #730
Merged
Merged
Conversation
rafaelscosta
requested review from
Pedrovaleriolopez and
oalanicolas
as code owners
May 13, 2026 13:35
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR implements a legacy ChangesLegacy aiox-core Wrapper and Publishing Integration
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
area: docs
Contributor
📊 Coverage ReportCoverage report not available
Generated by PR Automation (Story 6.1) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/npm-publish.yml:
- Around line 418-423: The current loop captures the exit code after the entire
if compound so `$?` yields the `if` result rather than the `npm publish` exit
code; update the loop around the `if npm publish --tag ${{
steps.publish-tag.outputs.tag }} --access public; then` block to move the
publish-status capture into an `else` branch so that `publish_status` is set to
the immediate `$?` of the failed `npm publish` command (keep using the existing
`publish_status` variable and the same tag reference
`steps.publish-tag.outputs.tag`) and only break/set `publish_status=0` inside
the `then` branch when publish succeeds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5f7dfc4f-343f-4997-9210-718a989780a3
📒 Files selected for processing (5)
.github/workflows/npm-publish.ymlcompat/aiox-core/README.mdcompat/aiox-core/bin/aiox-core.jscompat/aiox-core/package.jsondocs/stories/epic-124-aiox-squads-scope-migration/STORY-124.8-legacy-aiox-core-wrapper.md
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/npm-publish.yml:
- Around line 488-494: The summary appends "aiox-core legacy wrapper" whenever
the dependent job finished successfully, even if it skipped publishing; update
the condition to only append when the publish actually occurred by checking the
publish job's output (e.g. needs.publish_legacy_aiox_core.outputs.should_publish
== 'true' or a similar output flag) instead of just
needs.publish_legacy_aiox_core.result; modify the block that references
PUBLISHED_PACKAGES and needs.publish_legacy_aiox_core.result so it uses the job
output that indicates a real publish before adding "aiox-core legacy wrapper" to
PUBLISHED_PACKAGES.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4f816251-cc7d-4b00-b168-4d069734dfd2
📒 Files selected for processing (1)
.github/workflows/npm-publish.yml
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiox-corenpm wrapper that delegates to@aiox-squads/core@5.2.2Validation
npm pack --dry-run --jsonforcompat/aiox-coreaiox-core --version-> 5.2.2;aiox-core pro setup --helpnpm_config_ignore_scripts=true npm run validate:publishaiox-core@latest-> 5.2.2, depends on@aiox-squads/core@5.2.2Summary by CodeRabbit
New Features
npx aiox-core@latestand legacy binary names delegate to the canonical package.Documentation