Skip to content

fix(ci): use require.resolve() in smoke_test_exports — fixes #755 #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaelscosta merged 1 commit into from
May 18, 2026
Merged

fix(ci): use require.resolve() in smoke_test_exports — fixes #755 #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ jobs:
echo "❌ ${CORE_SPEC} not visible after 90s — cannot run exports smoke"
exit 1

- name: Force require() resolution to trigger exports gate
- name: Force require.resolve() to trigger exports gate
env:
CORE_SPEC: '@aiox-squads/core@${{ needs.build.outputs.version }}'
run: |
Expand All @@ -520,13 +520,16 @@ jobs:
cd "${SMOKE_DIR}"
npm init -y >/dev/null 2>&1
npm install "${CORE_SPEC}" 2>&1 | tail -3
# External require() forces Node's package-exports gate. If bin/*
# is not declared in exports, this fails with ERR_PACKAGE_PATH_NOT_EXPORTED.
# External require.resolve() forces Node's package-exports gate. If
# bin/* is not declared in exports, this fails with ERR_PACKAGE_PATH_NOT_EXPORTED.
# Uses resolve() instead of require() to avoid loading the CLI's wizard
# in non-TTY runners (Node 24 surfaced ERR_USE_AFTER_CLOSE on readline
# close in non-interactive contexts — false positive, not exports drift).
# set -o pipefail above ensures node's exit status survives the head pipe.
if node -e "require('@aiox-squads/core/bin/aiox.js')" 2>&1 | head -20; then
echo "✅ require('@aiox-squads/core/bin/aiox.js') succeeds on Node ${{ matrix.node }}"
if node -e "require.resolve('@aiox-squads/core/bin/aiox.js')" 2>&1 | head -20; then
echo "✅ require.resolve('@aiox-squads/core/bin/aiox.js') succeeds on Node ${{ matrix.node }}"
else
echo "❌ REGRESSION: require() blocked by exports field on Node ${{ matrix.node }}"
echo "❌ REGRESSION: require.resolve() blocked by exports field on Node ${{ matrix.node }}"
echo "❌ Issue #734 has returned — check exports field in package.json"
exit 1
fi
Expand Down
Loading