docs(governance): propose a quality harness (layered gates + full-suite-before-seal) by jordyamoedo · Pull Request #794 · SynkraAI/aiox-core

jordyamoedo · 2026-06-15T02:27:26Z

Summary

This proposes a quality harness — submitted through the project's own governance/evolution-pipeline.md as an AuditFinding + FrameworkProposal (both PENDING your approval). Two governance YAML files; no code paths touched.

The gap

"Quality First" is Article V of the constitution — but it's declarative. There's no harness that ties gates to moments and owners, nothing forces the full test suite before a seal, and a seal can pass on a subset test run that hides a regression in an untouched module.

The proposal

A small set of additive, advisory-by-default rules built on three invariants:

Every gate has a NAMED owning agent — not "whoever remembers".
Every gate runs automatically at its moment (git hook or CI), never by human initiative.
The PR/CI gate is the un-bypassable one — merge is blocked there.

Plus full-suite-before-seal: run the whole suite (no path filter) + build + typecheck before marking work shippable — because subset runs hide cross-module regressions (a change shifts lines/exports and breaks a test in a module you never touched).

Why it's good for the project

It makes the constitution's own "Quality First" enforceable — a mechanism with owners and automatic gates, instead of a slogan.
full-suite-before-seal catches the cross-module regressions that subset runs silently miss.
Additive and freedom-preserving — gates start advisory; a project opts each into blocking via config; only the PR/CI gate blocks by default (already the right place).
Battle-tested in a production consumer fork, then generalized here (no project-specific content).

Submitted in the spirit of the framework's own evolution pipeline. Happy to follow up with the implementation PR once approved — or to adjust scope per your guidance.

Summary by CodeRabbit

Documentation
- Established automated quality gate framework with full-suite testing requirements enforced before release sealing
- Added governance proposal and audit findings documenting the quality assurance policy implementation

vercel · 2026-06-15T02:27:31Z

@jordyamoedo is attempting to deploy a commit to the SINKRA - AIOX Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2026-06-15T02:27:36Z

Welcome to aiox-core! Thanks for your first pull request.

What happens next?

Automated checks will run on your PR
A maintainer will review your changes
Once approved, we'll merge your contribution!

PR Checklist:

Tests pass (npm test)
Linting passes (npm run lint)
Commit messages follow Conventional Commits

Thanks for contributing!

coderabbitai · 2026-06-15T02:27:39Z

Walkthrough

Two new YAML documents are added: a promoted audit finding (AF-20260614-quality-harness) recording evidence, impact, and disposition for a quality gap, and a governance proposal (PROP-20260614-quality-harness) formalizing a framework for automated layered quality gates with full-suite-before-seal enforcement, migration plan, cost/risk statements, and pending approval fields.

Changes

Quality Harness Audit Finding and Governance Proposal

Layer / File(s)	Summary
Promoted audit finding record `audits/promoted/AF-20260614-quality-harness.yaml`	Adds the complete audit finding covering record metadata, anonymized project context, finding summary with evidence bullets, observed impact (blast radius, affected artifacts, cost), framework candidate status, and proposed disposition items for automated layered QA gates and full-suite-before-seal/push enforcement.
Governance proposal for quality harness framework `governance/proposals/PROP-20260614-quality-harness.yaml`	Adds the governance proposal referencing the audit finding, defining the L2 target artifact (quality-suite rules plus optional pre-push gate), specifying the layered gate generalization pattern with owning agents and non-bypassable PR/CI semantics, an additive migration path, empty deprecation plan, cost/benefit and risk statements, approval status initialized to PENDING, and blank implementation tracking fields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

area: docs, area: devops

Suggested reviewers

oalanicolas
Pedrovaleriolopez

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: proposing a quality harness with layered gates and full-suite-before-seal enforcement, which aligns with the core objective of the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@audits/promoted/AF-20260614-quality-harness.yaml`:
- Line 4: The date field in both governance documents violates ISO 8601 format
requirements by omitting time and timezone components. In
audits/promoted/AF-20260614-quality-harness.yaml at line 4 and
governance/proposals/PROP-20260614-quality-harness.yaml at line 4, update the
date value from the format YYYY-MM-DD (2026-06-14) to the full ISO 8601 format
with UTC timezone (2026-06-14T00:00:00Z) to ensure consistent date parsing
across all tooling.
- Around line 30-32: The kind field in the references section uses an invalid
value "pattern" that is not in the documented list of allowed reference kinds.
Change the kind value from "pattern" to "existing-pattern-source", which is a
valid kind that matches the intent of referencing a quality harness pattern.
This will bring the YAML configuration into compliance with the documented
template requirements for the kind field.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fb133895-b061-4a2a-aca1-976c279f8719

📥 Commits

Reviewing files that changed from the base of the PR and between 77265d5 and 492b577.

📒 Files selected for processing (2)

audits/promoted/AF-20260614-quality-harness.yaml
governance/proposals/PROP-20260614-quality-harness.yaml

coderabbitai · 2026-06-15T02:31:17Z

+audit_finding:
+  version: "1.0"
+  id: "AF-20260614-quality-harness"
+  date: "2026-06-14"


⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

ISO 8601 date format violation in both governance documents. Both the audit finding and the proposal use 2026-06-14 without time and timezone components. The governance templates require full ISO 8601 format (e.g., 2026-05-07T18:30:00Z) to ensure reliable date parsing across tooling.

audits/promoted/AF-20260614-quality-harness.yaml#L4: Change to 2026-06-14T00:00:00Z

governance/proposals/PROP-20260614-quality-harness.yaml#L4: Change to 2026-06-14T00:00:00Z

📍 Affects 2 files

audits/promoted/AF-20260614-quality-harness.yaml#L4-L4 (this comment)

governance/proposals/PROP-20260614-quality-harness.yaml#L4-L4

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@audits/promoted/AF-20260614-quality-harness.yaml` at line 4, The date field in both governance documents violates ISO 8601 format requirements by omitting time and timezone components. In audits/promoted/AF-20260614-quality-harness.yaml at line 4 and governance/proposals/PROP-20260614-quality-harness.yaml at line 4, update the date value from the format YYYY-MM-DD (2026-06-14) to the full ISO 8601 format with UTC timezone (2026-06-14T00:00:00Z) to ensure consistent date parsing across all tooling.

coderabbitai · 2026-06-15T02:31:17Z

+  references:
+    - kind: pattern
+      path: "Quality harness: layered gates with an owning agent and a fail-mode"


⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Use a documented reference kind.

The kind field uses "pattern", which is not in the allowed list documented in the template: ADR | code | hook | governance-doc | existing-pattern-source | voice-clone-finding | voice-clone-personas | handoff-contract | audit | proposal.

Consider using existing-pattern-source instead, which appears to match the intent of referencing a quality harness pattern.

🔧 Proposed fix

references: - - kind: pattern + - kind: existing-pattern-source path: "Quality harness: layered gates with an owning agent and a fail-mode"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

references:

- kind: pattern

path: "Quality harness: layered gates with an owning agent and a fail-mode"

references:

- kind: existing-pattern-source

path: "Quality harness: layered gates with an owning agent and a fail-mode"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@audits/promoted/AF-20260614-quality-harness.yaml` around lines 30 - 32, The kind field in the references section uses an invalid value "pattern" that is not in the documented list of allowed reference kinds. Change the kind value from "pattern" to "existing-pattern-source", which is a valid kind that matches the intent of referencing a quality harness pattern. This will bring the YAML configuration into compliance with the documented template requirements for the kind field.

jordyamoedo added 2 commits June 14, 2026 23:26

docs(governance): PROP-20260614-quality-harness.yaml

7f01ef1

docs(governance): AF-20260614-quality-harness.yaml

492b577

jordyamoedo requested review from Pedrovaleriolopez and oalanicolas as code owners June 15, 2026 02:27

github-actions Bot added the area: docs Documentation (docs/) label Jun 15, 2026

coderabbitai Bot requested changes Jun 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

docs(governance): propose a quality harness (layered gates + full-suite-before-seal)#794

docs(governance): propose a quality harness (layered gates + full-suite-before-seal)#794
jordyamoedo wants to merge 2 commits into
SynkraAI:mainfrom
jordyamoedo:contrib/quality-harness

jordyamoedo commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jun 15, 2026

Uh oh!

coderabbitai Bot Jun 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

jordyamoedo commented Jun 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

The gap

The proposal

Why it's good for the project

Summary by CodeRabbit

Uh oh!

vercel Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jordyamoedo commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading