fix: route environment-bootstrap to @devops and gate greenfield guard#813
fix: route environment-bootstrap to @devops and gate greenfield guard#813GiovaneLaurencio wants to merge 1 commit into
Conversation
The GREENFIELD GUARD recommended `*environment-bootstrap` from 11 agents that do not own it — the command is @devops-exclusive, so the recommendation violated Constitution Article II (Agent Authority). The guard also fired in any non-git directory, including a user home directory, where `git init` must never run. - 11 agents now delegate: `@devops *environment-bootstrap`; devops.md keeps the direct call since it owns the command - guard decides from the working directory path already present in the system prompt (zero extra I/O at activation): a home or non-project directory gets a tip to activate from inside the project instead of a bootstrap suggestion - status line "Greenfield project" -> "No git repository detected in the working directory" (a home directory is not a greenfield project) - IDE derivatives regenerated with `npm run sync:ide` (.claude, .codex, .gemini, .kimi); .cursor and .antigravity use a condensed format that does not carry activation-instructions, so they are unchanged Validated: `npm run validate:agents` -> 12 agents, 0 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@GiovaneLaurencio is attempting to deploy a commit to the SINKRA - AIOX Team on Vercel. A member of the Team first needs to authorize it. |
|
Welcome to aiox-core! Thanks for your first pull request. What happens next?
PR Checklist:
Thanks for contributing! |
WalkthroughAgent activation instructions now distinguish missing Git repositories from home/non-project directories and actual project directories. The install manifest was regenerated with updated timestamps and metadata for tracked assets. ChangesActivation Guidance
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The unrelated registry defect noted at the end of the description is now tracked separately as #814, with a deterministic reproduction and the root cause pinned to |
There was a problem hiding this comment.
Actionable comments posted: 13
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.aiox-core/development/agents/aiox-master.md:
- Around line 33-36: Replace the directory guard in the canonical AIOX master
instructions with a positive project-directory check; when no such signal is
available, use the no-bootstrap tip rather than recommending environment
bootstrap. Apply this corrected guard to
.aiox-core/development/agents/aiox-master.md:33-36, analyst.md:24-27,
architect.md:24-27, and data-engineer.md:25-28, then regenerate the
corresponding derivatives in .codex/agents/squad-creator.md:24-27,
.codex/agents/ux-design-expert.md:29-32,
.gemini/rules/AIOX/agents/aiox-master.md:33-36, analyst.md:24-27,
architect.md:24-27, data-engineer.md:25-28, and dev.md:24-27.
In @.aiox-core/development/agents/dev.md:
- Around line 24-27: The post-substep 6 decision logic must not classify every
non-home path as a project directory. Update the working-directory evaluation to
recommend bootstrap only when the system prompt explicitly identifies an actual
project; otherwise use the unknown/non-project branch, display the existing
activation tip, and suppress bootstrap.
In @.aiox-core/development/agents/devops.md:
- Around line 25-28: Update the post-substep-6 decision logic in the DevOps
activation flow to recommend *environment-bootstrap only when the system context
positively identifies the working directory as an actual project. Treat unknown
or merely non-home paths, including /tmp, as non-project directories and show
the existing non-project tip without recommending repository initialization;
preserve the home-directory handling.
In @.aiox-core/development/agents/pm.md:
- Around line 38-41: Update the post-substep-6 decision logic in the
project-status guidance to recommend `@devops` *environment-bootstrap only when
the system prompt explicitly identifies the working directory as an actual
project directory. Treat all other paths, including arbitrary no-Git directories
and home directories, as non-project directories and show the existing safe
activation tip without recommending bootstrap.
In @.aiox-core/development/agents/po.md:
- Around line 24-27: Update the post-substep 6 decision logic in the PO agent
instructions to recommend environment-bootstrap only when the supplied system
context positively identifies the working directory as an actual project. Treat
home directories, /tmp, generic workspace roots, and any other unverified or
non-project directory as non-project locations, showing the activation tip
without recommending bootstrap.
In @.aiox-core/development/agents/qa.md:
- Around line 24-27: The post-substep-6 decision in the QA activation flow must
recommend environment bootstrap only when the system prompt explicitly confirms
the working directory is an actual project directory. For unknown, arbitrary, or
otherwise unconfirmed no-Git paths, retain the activation tip and do not
recommend bootstrap; update the project-directory branch accordingly.
In @.claude/skills/AIOX/agents/architect/SKILL.md:
- Around line 35-37: The bootstrap recommendation currently infers project
status from the working-directory path alone; update the post-substep-6 decision
in .claude/skills/AIOX/agents/architect/SKILL.md lines 35-37,
.claude/skills/AIOX/agents/data-engineer/SKILL.md lines 36-38,
.claude/skills/AIOX/agents/dev/SKILL.md lines 35-37,
.claude/skills/AIOX/agents/devops/SKILL.md lines 36-38,
.claude/skills/AIOX/agents/pm/SKILL.md lines 49-51,
.kimi/skills/aiox-dev/SKILL.md lines 109-111, .kimi/skills/aiox-devops/SKILL.md
lines 110-112, .kimi/skills/aiox-master/SKILL.md lines 113-115,
.kimi/skills/aiox-pm/SKILL.md lines 96-98, and .kimi/skills/aiox-po/SKILL.md
lines 84-86 to use explicit project-directory metadata from the system prompt;
when classification is unavailable or ambiguous, do not recommend
environment-bootstrap, while preserving the existing recommendation only for
positively identified project directories.
In @.claude/skills/AIOX/agents/po/SKILL.md:
- Around line 35-37: Replace the home-directory-only check after substep 6 with
a definitive project-directory classification or existing project indicator
before recommending bootstrap; non-project paths must show the activation tip
and never recommend `@devops` *environment-bootstrap. Apply the same guard in
.claude/skills/AIOX/agents/po/SKILL.md:35-37, qa/SKILL.md:35-37,
sm/SKILL.md:35-37, squad-creator/SKILL.md:35-37,
ux-design-expert/SKILL.md:40-42, and regenerate the corresponding derivatives in
.kimi/skills/aiox-qa/SKILL.md:91-93, aiox-sm/SKILL.md:73-75,
aiox-squad-creator/SKILL.md:88-90, and aiox-ux-design-expert/SKILL.md:112-114.
In @.gemini/rules/AIOX/agents/devops.md:
- Around line 25-28: Update the post-substep 6 decision logic in the no-Git flow
to recommend *environment-bootstrap only after positively identifying the
working directory as an actual project directory. Treat unrecognized non-project
locations, including paths outside the listed home-directory patterns such as
/tmp, like other non-project directories and show the activation tip instead; do
not infer project status solely from not matching a home path.
In @.gemini/rules/AIOX/agents/pm.md:
- Around line 38-41: Update the post-substep-6 decision logic in the
project-status guidance so bootstrap is recommended only when the system context
explicitly confirms the working directory is an actual project directory. Treat
all other paths, including arbitrary non-home directories without positive
project identification, as non-project directories and show the existing
activation tip without recommending `@devops` *environment-bootstrap.
In @.gemini/rules/AIOX/agents/po.md:
- Around line 24-27: Update the post-substep-6 decision logic to recommend
`@devops` *environment-bootstrap only when the system prompt positively identifies
the working directory as an actual project. Treat any path that is not
positively confirmed as a project—including non-home directories without Git—as
non-project, show the existing activation tip, and do not infer project status
merely because the path is not excluded.
In @.gemini/rules/AIOX/agents/qa.md:
- Around line 24-27: Update the post-substep 6 path decision in the QA guidance
so only positively identified actual project directories recommend `@devops`
*environment-bootstrap. Treat all unrecognized or unknown paths as non-project
directories, displaying the existing activation tip and never recommending
bootstrap; preserve the explicit user-home directory handling.
In @.gemini/rules/AIOX/agents/sm.md:
- Around line 24-27: Update the post-substep-6 decision logic in the sm agent
instructions so bootstrap is recommended only when the system prompt explicitly
confirms the working directory is an actual project. Treat all other no-Git
paths, including non-home directories with unknown context, as non-project
locations and show the existing safe activation tip without recommending
environment-bootstrap.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0716c11c-6a86-4262-b47a-1b7a3dcb670b
📒 Files selected for processing (61)
.aiox-core/development/agents/aiox-master.md.aiox-core/development/agents/analyst.md.aiox-core/development/agents/architect.md.aiox-core/development/agents/data-engineer.md.aiox-core/development/agents/dev.md.aiox-core/development/agents/devops.md.aiox-core/development/agents/pm.md.aiox-core/development/agents/po.md.aiox-core/development/agents/qa.md.aiox-core/development/agents/sm.md.aiox-core/development/agents/squad-creator.md.aiox-core/development/agents/ux-design-expert.md.aiox-core/install-manifest.yaml.claude/skills/AIOX/agents/aiox-master/SKILL.md.claude/skills/AIOX/agents/analyst/SKILL.md.claude/skills/AIOX/agents/architect/SKILL.md.claude/skills/AIOX/agents/data-engineer/SKILL.md.claude/skills/AIOX/agents/dev/SKILL.md.claude/skills/AIOX/agents/devops/SKILL.md.claude/skills/AIOX/agents/pm/SKILL.md.claude/skills/AIOX/agents/po/SKILL.md.claude/skills/AIOX/agents/qa/SKILL.md.claude/skills/AIOX/agents/sm/SKILL.md.claude/skills/AIOX/agents/squad-creator/SKILL.md.claude/skills/AIOX/agents/ux-design-expert/SKILL.md.codex/agents/aiox-master.md.codex/agents/analyst.md.codex/agents/architect.md.codex/agents/data-engineer.md.codex/agents/dev.md.codex/agents/devops.md.codex/agents/pm.md.codex/agents/po.md.codex/agents/qa.md.codex/agents/sm.md.codex/agents/squad-creator.md.codex/agents/ux-design-expert.md.gemini/rules/AIOX/agents/aiox-master.md.gemini/rules/AIOX/agents/analyst.md.gemini/rules/AIOX/agents/architect.md.gemini/rules/AIOX/agents/data-engineer.md.gemini/rules/AIOX/agents/dev.md.gemini/rules/AIOX/agents/devops.md.gemini/rules/AIOX/agents/pm.md.gemini/rules/AIOX/agents/po.md.gemini/rules/AIOX/agents/qa.md.gemini/rules/AIOX/agents/sm.md.gemini/rules/AIOX/agents/squad-creator.md.gemini/rules/AIOX/agents/ux-design-expert.md.kimi/skills/aiox-analyst/SKILL.md.kimi/skills/aiox-architect/SKILL.md.kimi/skills/aiox-data-engineer/SKILL.md.kimi/skills/aiox-dev/SKILL.md.kimi/skills/aiox-devops/SKILL.md.kimi/skills/aiox-master/SKILL.md.kimi/skills/aiox-pm/SKILL.md.kimi/skills/aiox-po/SKILL.md.kimi/skills/aiox-qa/SKILL.md.kimi/skills/aiox-sm/SKILL.md.kimi/skills/aiox-squad-creator/SKILL.md.kimi/skills/aiox-ux-design-expert/SKILL.md
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
The directory guard still has a false-positive path.
The otherwise branch treats every non-home directory as an actual project directory, so /tmp, workspace folders, downloads directories, and other non-project locations can still receive bootstrap guidance. Require a positive project-directory signal and default to the no-bootstrap tip when that signal is unavailable.
.aiox-core/development/agents/aiox-master.md#L33-L36: Fix the canonical guard and use it as the source for regenerated derivatives..aiox-core/development/agents/analyst.md#L24-L27: Apply the same positive project check..aiox-core/development/agents/architect.md#L24-L27: Apply the same positive project check..aiox-core/development/agents/data-engineer.md#L25-L28: Apply the same positive project check..codex/agents/squad-creator.md#L24-L27: Regenerate with the corrected guard..codex/agents/ux-design-expert.md#L29-L32: Regenerate with the corrected guard..gemini/rules/AIOX/agents/aiox-master.md#L33-L36: Regenerate with the corrected guard..gemini/rules/AIOX/agents/analyst.md#L24-L27: Regenerate with the corrected guard..gemini/rules/AIOX/agents/architect.md#L24-L27: Regenerate with the corrected guard..gemini/rules/AIOX/agents/data-engineer.md#L25-L28: Regenerate with the corrected guard..gemini/rules/AIOX/agents/dev.md#L24-L27: Regenerate with the corrected guard.
📍 Affects 11 files
.aiox-core/development/agents/aiox-master.md#L33-L36(this comment).aiox-core/development/agents/analyst.md#L24-L27.aiox-core/development/agents/architect.md#L24-L27.aiox-core/development/agents/data-engineer.md#L25-L28.codex/agents/squad-creator.md#L24-L27.codex/agents/ux-design-expert.md#L29-L32.gemini/rules/AIOX/agents/aiox-master.md#L33-L36.gemini/rules/AIOX/agents/analyst.md#L24-L27.gemini/rules/AIOX/agents/architect.md#L24-L27.gemini/rules/AIOX/agents/data-engineer.md#L25-L28.gemini/rules/AIOX/agents/dev.md#L24-L27
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.aiox-core/development/agents/aiox-master.md around lines 33 - 36, Replace
the directory guard in the canonical AIOX master instructions with a positive
project-directory check; when no such signal is available, use the no-bootstrap
tip rather than recommending environment bootstrap. Apply this corrected guard
to .aiox-core/development/agents/aiox-master.md:33-36, analyst.md:24-27,
architect.md:24-27, and data-engineer.md:25-28, then regenerate the
corresponding derivatives in .codex/agents/squad-creator.md:24-27,
.codex/agents/ux-design-expert.md:29-32,
.gemini/rules/AIOX/agents/aiox-master.md:33-36, analyst.md:24-27,
architect.md:24-27, data-engineer.md:25-28, and dev.md:24-27.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not treat every non-home path as a project directory.
This fallback still recommends bootstrap for arbitrary no-Git paths such as /tmp or a workspace root. With no filesystem inspection or explicit project marker, use a conservative “unknown/non-project” branch and suppress bootstrap unless the system prompt positively identifies the directory as a project.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.aiox-core/development/agents/dev.md around lines 24 - 27, The post-substep
6 decision logic must not classify every non-home path as a project directory.
Update the working-directory evaluation to recommend bootstrap only when the
system prompt explicitly identifies an actual project; otherwise use the
unknown/non-project branch, display the existing activation tip, and suppress
bootstrap.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `*environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not treat every non-home path as a project directory.
A no-Git working directory such as /tmp can reach the “actual project directory” branch and receive *environment-bootstrap. Require positive project identification from the system context; otherwise show the non-project tip and avoid recommending repository initialization.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.aiox-core/development/agents/devops.md around lines 25 - 28, Update the
post-substep-6 decision logic in the DevOps activation flow to recommend
*environment-bootstrap only when the system context positively identifies the
working directory as an actual project. Treat unknown or merely non-home paths,
including /tmp, as non-project directories and show the existing non-project tip
without recommending repository initialization; preserve the home-directory
handling.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Require positive project detection before recommending bootstrap.
The “otherwise” branch assumes that every path outside the listed home-directory patterns is a project. Arbitrary no-Git directories can therefore receive @devops *environment-bootstrap; default to the safe tip unless the system prompt explicitly identifies a project directory.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.aiox-core/development/agents/pm.md around lines 38 - 41, Update the
post-substep-6 decision logic in the project-status guidance to recommend
`@devops` *environment-bootstrap only when the system prompt explicitly identifies
the working directory as an actual project directory. Treat all other paths,
including arbitrary no-Git directories and home directories, as non-project
directories and show the existing safe activation tip without recommending
bootstrap.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not infer “project directory” solely from not being a home directory.
Directories such as /tmp or a generic workspace root can lack Git while still matching the “otherwise” branch. Suppress bootstrap unless the supplied system context positively identifies the working directory as a project.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.aiox-core/development/agents/po.md around lines 24 - 27, Update the
post-substep 6 decision logic in the PO agent instructions to recommend
environment-bootstrap only when the supplied system context positively
identifies the working directory as an actual project. Treat home directories,
/tmp, generic workspace roots, and any other unverified or non-project directory
as non-project locations, showing the activation tip without recommending
bootstrap.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `*environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not classify arbitrary non-home paths as projects.
A no-Git directory outside the listed home patterns can still be /tmp or another non-project location, yet this branch recommends *environment-bootstrap. Require positive project identification before suggesting repository initialization.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.gemini/rules/AIOX/agents/devops.md around lines 25 - 28, Update the
post-substep 6 decision logic in the no-Git flow to recommend
*environment-bootstrap only after positively identifying the working directory
as an actual project directory. Treat unrecognized non-project locations,
including paths outside the listed home-directory patterns such as /tmp, like
other non-project directories and show the activation tip instead; do not infer
project status solely from not matching a home path.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Require positive project identification before bootstrap guidance.
The current “otherwise” branch treats every non-home path as a project, so arbitrary no-Git directories may receive @devops *environment-bootstrap. Use the safe non-project tip unless the system context explicitly confirms a project directory.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.gemini/rules/AIOX/agents/pm.md around lines 38 - 41, Update the
post-substep-6 decision logic in the project-status guidance so bootstrap is
recommended only when the system context explicitly confirms the working
directory is an actual project directory. Treat all other paths, including
arbitrary non-home directories without positive project identification, as
non-project directories and show the existing activation tip without
recommending `@devops` *environment-bootstrap.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not infer project status from a path exclusion.
A no-Git path that is not a home directory may still be a non-project directory. This branch should avoid @devops *environment-bootstrap unless the system prompt positively identifies the working directory as a project.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.gemini/rules/AIOX/agents/po.md around lines 24 - 27, Update the
post-substep-6 decision logic to recommend `@devops` *environment-bootstrap only
when the system prompt positively identifies the working directory as an actual
project. Treat any path that is not positively confirmed as a project—including
non-home directories without Git—as non-project, show the existing activation
tip, and do not infer project status merely because the path is not excluded.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Default unknown paths to the non-project branch.
The current fallback recommends bootstrap for every path not matching the home examples. That includes arbitrary no-Git directories; only recommend @devops *environment-bootstrap after positive project-directory identification.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.gemini/rules/AIOX/agents/qa.md around lines 24 - 27, Update the
post-substep 6 path decision in the QA guidance so only positively identified
actual project directories recommend `@devops` *environment-bootstrap. Treat all
unrecognized or unknown paths as non-project directories, displaying the
existing activation tip and never recommending bootstrap; preserve the explicit
user-home directory handling.
| - For substep 3: show "📊 **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "💡 **Tip:** Activate agents from inside the project directory — never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "💡 **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Require positive project detection before recommending bootstrap.
A non-home path is not necessarily a project directory. For arbitrary no-Git locations, this branch can recommend @devops *environment-bootstrap; retain the safe tip unless the system prompt explicitly confirms project context.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.gemini/rules/AIOX/agents/sm.md around lines 24 - 27, Update the
post-substep-6 decision logic in the sm agent instructions so bootstrap is
recommended only when the system prompt explicitly confirms the working
directory is an actual project. Treat all other no-Git paths, including non-home
directories with unknown context, as non-project locations and show the existing
safe activation tip without recommending environment-bootstrap.
📋 Description
The
GREENFIELD GUARDin the activation instructions had two defects that surfaced when an agent was activated from a directory that is not a git repository (a user home directory, in this case):*environment-bootstrap— a @devops-exclusive command — from 11 agents that do not own it (aiox-master,dev,qa,pm,po,sm,architect,analyst,data-engineer,ux-design-expert,squad-creator).C:\Users\{name}produced a bootstrap recommendation whose task would rungit initover the user's entire profile (Documents, Downloads,.ssh, …). It also labelled that directory a "Greenfield project", which it is not.🎯 AIOX Story Reference
Story ID: none — defect found during live agent activation, not from a story.
📦 Type of Change
🎯 Scope
aiox-core/).claude,.codex,.gemini,.kimi)📝 Changes Made
@devops *environment-bootstrap.devops.mdkeeps the direct*environment-bootstrapcall, since it owns the command.C:\Users\{name},/home/{name},/Users/{name}) or any non-project directory → shows a tip to activate from inside the project directory, and does not recommend bootstrap;@devops *environment-bootstrapas before.Greenfield project — no git repository detectedtoNo git repository detected in the working directory.npm run sync:ide..cursorand.antigravityare untouched by design — their condensed format does not carryactivation-instructions, so they never had the guard.🧪 Testing
npm run validate:agents→ 12 agents, 0 errors (121 warnings are pre-existing missingchecklists/+data/dependencies, unrelated to this change).npm run lint→ PASSnpm run typecheck→ PASSnpm test→ 14 suites / 222 tests failing, identical to themainbaseline (verified by running the full suite onmainbefore and on this branch after:14 failed, 341 passedboth times). No regression introduced. The greeting suites (greeting-preference-manager,greeting-preference) were checked specifically on both refs: 21 failures on each, unchanged. Most failures stem from CodeRabbit CLI/WSL expectations on a Windows host.Unrelated defect found while committing this, worth its own issue: the IDS post-commit/pre-push hook rewrites
.aiox-core/data/entity-registry.yamldestructively, emptyingusedBy: []across hundreds of entities (230 insertions vs 818 deletions on a commit touching only 12 agents) — it appears to process only the entities touched by the commit and rebuild the graph from scratch. That diff was deliberately excluded from this PR and reverted locally; the registry here is untouched. Left as-is for the maintainers to triage, since the versioned registry feeds IDS impact analysis and gates G1–G6.🤖 Generated with Claude Code
Summary by CodeRabbit