-
-
Notifications
You must be signed in to change notification settings - Fork 937
fix: route environment-bootstrap to @devops and gate greenfield guard #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,10 @@ activation-instructions: | |
| Display greeting using native context (zero JS execution): | ||
| 0. GREENFIELD GUARD: If gitStatus in system prompt says "Is a git repository: false" OR git commands return "not a git repository": | ||
| - For substep 2: skip the "Branch:" append | ||
| - For substep 3: show "π **Project Status:** Greenfield project β no git repository detected" instead of git narrative | ||
| - After substep 6: show "π‘ **Recommended:** Run `*environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
| - For substep 3: show "π **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "π‘ **Tip:** Activate agents from inside the project directory β never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "π‘ **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
|
Comment on lines
+24
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π― Functional Correctness | π Major | β‘ Quick win Do not treat every non-home path as a project directory. This fallback still recommends bootstrap for arbitrary no-Git paths such as π€ Prompt for AI Agents |
||
| - Do NOT run any git commands during activation β they will fail and produce errors | ||
| 1. Show: "{icon} {persona_profile.communication.greeting_levels.archetypal}" + permission badge from current permission mode (e.g., [β οΈ Ask], [π’ Auto], [π Explore]) | ||
| 2. Show: "**Role:** {persona.role}" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,10 @@ activation-instructions: | |
| Display greeting using native context (zero JS execution): | ||
| 0. GREENFIELD GUARD: If gitStatus in system prompt says "Is a git repository: false" OR git commands return "not a git repository": | ||
| - For substep 2: skip the "Branch:" append | ||
| - For substep 3: show "π **Project Status:** Greenfield project β no git repository detected" instead of git narrative | ||
| - After substep 6: show "π‘ **Recommended:** Run `*environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
| - For substep 3: show "π **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "π‘ **Tip:** Activate agents from inside the project directory β never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "π‘ **Recommended:** Run `*environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
|
Comment on lines
+25
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π― Functional Correctness | π Major | β‘ Quick win Do not treat every non-home path as a project directory. A no-Git working directory such as π€ Prompt for AI Agents |
||
| - Do NOT run any git commands during activation β they will fail and produce errors | ||
| 1. Show: "{icon} {persona_profile.communication.greeting_levels.archetypal}" + permission badge from current permission mode (e.g., [β οΈ Ask], [π’ Auto], [π Explore]) | ||
| 2. Show: "**Role:** {persona.role}" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,8 +35,10 @@ activation-instructions: | |
| Display greeting using native context (zero JS execution): | ||
| 0. GREENFIELD GUARD: If gitStatus in system prompt says "Is a git repository: false" OR git commands return "not a git repository": | ||
| - For substep 2: skip the "Branch:" append | ||
| - For substep 3: show "π **Project Status:** Greenfield project β no git repository detected" instead of git narrative | ||
| - After substep 6: show "π‘ **Recommended:** Run `*environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
| - For substep 3: show "π **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "π‘ **Tip:** Activate agents from inside the project directory β never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "π‘ **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
|
Comment on lines
+38
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π― Functional Correctness | π Major | β‘ Quick win Require positive project detection before recommending bootstrap. The βotherwiseβ branch assumes that every path outside the listed home-directory patterns is a project. Arbitrary no-Git directories can therefore receive π€ Prompt for AI Agents |
||
| - Do NOT run any git commands during activation β they will fail and produce errors | ||
| 1. Show: "{icon} {persona_profile.communication.greeting_levels.archetypal}" + permission badge from current permission mode (e.g., [β οΈ Ask], [π’ Auto], [π Explore]) | ||
| 2. Show: "**Role:** {persona.role}" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,10 @@ activation-instructions: | |
| Display greeting using native context (zero JS execution): | ||
| 0. GREENFIELD GUARD: If gitStatus in system prompt says "Is a git repository: false" OR git commands return "not a git repository": | ||
| - For substep 2: skip the "Branch:" append | ||
| - For substep 3: show "π **Project Status:** Greenfield project β no git repository detected" instead of git narrative | ||
| - After substep 6: show "π‘ **Recommended:** Run `*environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
| - For substep 3: show "π **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "π‘ **Tip:** Activate agents from inside the project directory β never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "π‘ **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
|
Comment on lines
+24
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π― Functional Correctness | π Major | β‘ Quick win Do not infer βproject directoryβ solely from not being a home directory. Directories such as π€ Prompt for AI Agents |
||
| - Do NOT run any git commands during activation β they will fail and produce errors | ||
| 1. Show: "{icon} {persona_profile.communication.greeting_levels.archetypal}" + permission badge from current permission mode (e.g., [β οΈ Ask], [π’ Auto], [π Explore]) | ||
| 2. Show: "**Role:** {persona.role}" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,10 @@ activation-instructions: | |
| Display greeting using native context (zero JS execution): | ||
| 0. GREENFIELD GUARD: If gitStatus in system prompt says "Is a git repository: false" OR git commands return "not a git repository": | ||
| - For substep 2: skip the "Branch:" append | ||
| - For substep 3: show "π **Project Status:** Greenfield project β no git repository detected" instead of git narrative | ||
| - After substep 6: show "π‘ **Recommended:** Run `*environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
| - For substep 3: show "π **Project Status:** No git repository detected in the working directory" instead of git narrative | ||
| - After substep 6, decide from the working directory path already in the system prompt (zero I/O): | ||
| - If it is a user home directory (e.g. `C:\Users\{name}`, `/home/{name}`, `/Users/{name}`) or any other non-project directory: show "π‘ **Tip:** Activate agents from inside the project directory β never run `git init` in a home directory." and do NOT recommend bootstrap | ||
| - Otherwise (an actual project directory): show "π‘ **Recommended:** Run `@devops *environment-bootstrap` to initialize git, GitHub remote, and CI/CD" | ||
|
Comment on lines
+24
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π― Functional Correctness | π Major | β‘ Quick win Make the project-directory branch conservative. The current fallback recommends bootstrap for any non-home path, including arbitrary no-Git directories. Only recommend π€ Prompt for AI Agents |
||
| - Do NOT run any git commands during activation β they will fail and produce errors | ||
| 1. Show: "{icon} {persona_profile.communication.greeting_levels.archetypal}" + permission badge from current permission mode (e.g., [β οΈ Ask], [π’ Auto], [π Explore]) | ||
| 2. Show: "**Role:** {persona.role}" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π― Functional Correctness | π Major | β‘ Quick win
The directory guard still has a false-positive path.
The
otherwisebranch treats every non-home directory as an actual project directory, so/tmp, workspace folders, downloads directories, and other non-project locations can still receive bootstrap guidance. Require a positive project-directory signal and default to the no-bootstrap tip when that signal is unavailable..aiox-core/development/agents/aiox-master.md#L33-L36: Fix the canonical guard and use it as the source for regenerated derivatives..aiox-core/development/agents/analyst.md#L24-L27: Apply the same positive project check..aiox-core/development/agents/architect.md#L24-L27: Apply the same positive project check..aiox-core/development/agents/data-engineer.md#L25-L28: Apply the same positive project check..codex/agents/squad-creator.md#L24-L27: Regenerate with the corrected guard..codex/agents/ux-design-expert.md#L29-L32: Regenerate with the corrected guard..gemini/rules/AIOX/agents/aiox-master.md#L33-L36: Regenerate with the corrected guard..gemini/rules/AIOX/agents/analyst.md#L24-L27: Regenerate with the corrected guard..gemini/rules/AIOX/agents/architect.md#L24-L27: Regenerate with the corrected guard..gemini/rules/AIOX/agents/data-engineer.md#L25-L28: Regenerate with the corrected guard..gemini/rules/AIOX/agents/dev.md#L24-L27: Regenerate with the corrected guard.π Affects 11 files
.aiox-core/development/agents/aiox-master.md#L33-L36(this comment).aiox-core/development/agents/analyst.md#L24-L27.aiox-core/development/agents/architect.md#L24-L27.aiox-core/development/agents/data-engineer.md#L25-L28.codex/agents/squad-creator.md#L24-L27.codex/agents/ux-design-expert.md#L29-L32.gemini/rules/AIOX/agents/aiox-master.md#L33-L36.gemini/rules/AIOX/agents/analyst.md#L24-L27.gemini/rules/AIOX/agents/architect.md#L24-L27.gemini/rules/AIOX/agents/data-engineer.md#L25-L28.gemini/rules/AIOX/agents/dev.md#L24-L27π€ Prompt for AI Agents