removed IsBinary

Author: maccesch

CHANGELOG.md

@@ -3,6 +3,14 @@
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.0] - 2024-08-23
+
+### Breaking Changes
+
+- Trait `IsBinary` has been removed.
+- Instead, the traits `HybridEncoder` and `HybridDecoder` now provide the methods `is_binary_encoder` and
+  `is_binary_decoder` respectively.
+
 ## [0.1.2] - 2024-07-08
 
 ### New Codecs

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "codee"
-version = "0.1.2"
+version = "0.2.0"
 edition = "2021"
 authors = ["Marc-Stefan Cassola"]
 categories = ["encoding"]

src/hybrid.rs

@@ -1,28 +1,6 @@
 use crate::{Decoder, Encoder};
 use thiserror::Error;
 
-pub trait IsBinary<T, E: ?Sized> {
-    fn is_binary() -> bool;
-}
-
-impl<D, T> IsBinary<T, [u8]> for D
-where
-    D: Decoder<T, Encoded = [u8]>,
-{
-    fn is_binary() -> bool {
-        true
-    }
-}
-
-impl<D, T> IsBinary<T, str> for D
-where
-    D: Decoder<T, Encoded = str>,
-{
-    fn is_binary() -> bool {
-        false
-    }
-}
-
 #[derive(Debug, Error)]
 pub enum HybridCoderError<E> {
     #[error("Not implemented: {0}")]
@@ -34,6 +12,8 @@ pub enum HybridCoderError<E> {
 pub trait HybridDecoder<T, E: ?Sized> {
     type Error;
 
+    fn is_binary_decoder() -> bool;
+
     fn decode_str(_val: &str) -> Result<T, HybridCoderError<Self::Error>> {
         Err(HybridCoderError::NotImplemented(
             "You're trying to decode from a string. This codec is binary.",
@@ -53,6 +33,11 @@ where
 {
     type Error = D::Error;
 
+    #[inline(always)]
+    fn is_binary_decoder() -> bool {
+        true
+    }
+
     fn decode_bin(val: &[u8]) -> Result<T, HybridCoderError<Self::Error>> {
         Ok(D::decode(val)?)
     }
@@ -64,6 +49,11 @@ where
 {
     type Error = D::Error;
 
+    #[inline(always)]
+    fn is_binary_decoder() -> bool {
+        false
+    }
+
     fn decode_str(val: &str) -> Result<T, HybridCoderError<Self::Error>> {
         Ok(D::decode(val)?)
     }
@@ -72,6 +62,8 @@ where
 pub trait HybridEncoder<T, E> {
     type Error;
 
+    fn is_binary_encoder() -> bool;
+
     fn encode_str(_val: &T) -> Result<String, HybridCoderError<Self::Error>> {
         Err(HybridCoderError::NotImplemented(
             "You're trying to encode into a string. This codec is binary.",
@@ -91,6 +83,11 @@ where
 {
     type Error = E::Error;
 
+    #[inline(always)]
+    fn is_binary_encoder() -> bool {
+        true
+    }
+
     fn encode_bin(val: &T) -> Result<Vec<u8>, HybridCoderError<Self::Error>> {
         Ok(E::encode(val)?)
     }
@@ -102,6 +99,11 @@ where
 {
     type Error = E::Error;
 
+    #[inline(always)]
+    fn is_binary_encoder() -> bool {
+        false
+    }
+
     fn encode_str(val: &T) -> Result<String, HybridCoderError<Self::Error>> {
         Ok(E::encode(val)?)
     }