fix: add Log.Warn to 22 silent catch blocks in RegistryLeftoverScanner, fix ManagementObject disposal leaks

Author: SysAdminDoc

src/DeepPurge.Core/Registry/RegistryLeftoverScanner.cs

@@ -1,5 +1,6 @@
 using global::Microsoft.Win32;
 using DeepPurge.Core.Data;
+using DeepPurge.Core.Diagnostics;
 using DeepPurge.Core.Models;
 
 namespace DeepPurge.Core.Registry;
@@ -264,11 +265,11 @@ private void ScanSoftwareKeys(List<LeftoverItem> leftovers, ScanMode mode)
                                     }
                                 }
                             }
-                            catch { }
+                            catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
                         }
                     }
                 }
-                catch { }
+                catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
             }
         }
     }
@@ -317,10 +318,10 @@ private void ScanComRegistrations(InstalledProgram program, List<LeftoverItem> l
                         });
                     }
                 }
-                catch { }
+                catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
             }
         }
-        catch { }
+        catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
     }
 
     private void ScanAppPaths(InstalledProgram program, List<LeftoverItem> leftovers)
@@ -354,7 +355,7 @@ private void ScanAppPaths(InstalledProgram program, List<LeftoverItem> leftovers
                     }
                 }
             }
-            catch { }
+            catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
         }
     }
 
@@ -391,10 +392,10 @@ private void ScanFileAssociations(InstalledProgram program, List<LeftoverItem> l
                         });
                     }
                 }
-                catch { }
+                catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
             }
         }
-        catch { }
+        catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
     }
 
     private void ScanStartupEntries(List<LeftoverItem> leftovers)
@@ -430,7 +431,7 @@ private void ScanStartupEntries(List<LeftoverItem> leftovers)
                     }
                 }
             }
-            catch { }
+            catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
         }
     }
 
@@ -463,10 +464,10 @@ private void ScanServices(InstalledProgram program, List<LeftoverItem> leftovers
                         });
                     }
                 }
-                catch { }
+                catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
             }
         }
-        catch { }
+        catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
     }
 
     private void ScanFirewallRules(InstalledProgram program, List<LeftoverItem> leftovers)
@@ -497,7 +498,7 @@ private void ScanFirewallRules(InstalledProgram program, List<LeftoverItem> left
                 }
             }
         }
-        catch { }
+        catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
     }
 
     private void ScanMuiCache(InstalledProgram program, List<LeftoverItem> leftovers)
@@ -527,7 +528,7 @@ private void ScanMuiCache(InstalledProgram program, List<LeftoverItem> leftovers
                 }
             }
         }
-        catch { }
+        catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
     }
 
     private void ScanShellExtensions(InstalledProgram program, List<LeftoverItem> leftovers)
@@ -562,7 +563,7 @@ private void ScanShellExtensions(InstalledProgram program, List<LeftoverItem> le
                     }
                 }
             }
-            catch { }
+            catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
         }
     }
 
@@ -599,7 +600,7 @@ private void ScanAppCompatFlags(InstalledProgram program, List<LeftoverItem> lef
                     }
                 }
             }
-            catch { }
+            catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
         }
     }
 
@@ -622,7 +623,7 @@ private void ScanMsiData(InstalledProgram program, List<LeftoverItem> leftovers)
                     guid.Replace("{", "").Replace("}", "").Replace("-", ""),
                     "HKLM", leftovers, 2);
             }
-            catch { }
+            catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
         }
     }
 
@@ -657,7 +658,7 @@ private void SearchKeyRecursive(RegistryKey hive, string path, string searchTerm
                 }
             }
         }
-        catch { }
+        catch (Exception ex) { Log.Warn($"Registry scan: {ex.Message}"); }
     }
 
     private static bool RegistryKeyExists(string path)

src/DeepPurge.Core/Safety/SecureDelete.cs

@@ -172,8 +172,9 @@ private static bool DetectSsd(string driveRoot)
                 $"SELECT MediaType FROM MSFT_PhysicalDisk WHERE DeviceID IN " +
                 $"(SELECT DiskNumber FROM MSFT_Partition WHERE DriveLetter='{driveLetter}')");
             searcher.Scope = new ManagementScope(@"\\.\ROOT\Microsoft\Windows\Storage");
-            foreach (var obj in searcher.Get())
+            foreach (ManagementBaseObject baseObj in searcher.Get())
             {
+                using var obj = baseObj;
                 var mediaType = Convert.ToInt32(obj["MediaType"]);
                 return mediaType == 4; // 4 = SSD, 3 = HDD
             }

src/DeepPurge.Core/Safety/SystemRestoreManager.cs

@@ -45,8 +45,9 @@ public static List<RestorePointInfo> GetRestorePoints()
         {
             using var searcher = new ManagementObjectSearcher("root\\default",
                 "SELECT * FROM SystemRestorePoint");
-            foreach (ManagementObject obj in searcher.Get())
+            foreach (ManagementBaseObject baseObj in searcher.Get())
             {
+                using var obj = baseObj;
                 var desc = obj["Description"]?.ToString() ?? "";
                 var seq = Convert.ToInt32(obj["SequenceNumber"]);
                 var creationStr = obj["CreationTime"]?.ToString() ?? "";