fix(ffmpeg): centralize concat list writers

Author: SysAdminDoc

CHANGELOG.md

@@ -135,6 +135,9 @@ record also lives in the git commit messages.
   names.** The concat-demuxer escaping used `\'` (rejected by ffmpeg) and the
   default text codec (cp1252 on Windows). Added `write_concat_list()` (UTF-8 +
   the correct `'\''` idiom). *Verified: apostrophe and Cyrillic/CJK names.*
+- All core concat-demuxer writers found by the repo-wide scan now use
+  `write_concat_list()` or the shared concat-line formatter instead of local
+  platform-codec path writes.
 - New shared escaping helpers in `opencut/helpers.py`
   (`escape_filter_path`, `escape_drawtext`, `write_concat_list`) with a
   string-level regression test (`tests/test_ffmpeg_escaping.py`) locking the

ROADMAP-COMPLETED.md

@@ -0,0 +1,5 @@
+# Completed Roadmap Reference
+
+Completed roadmap work is recorded in `CHANGELOG.md` and git history.
+
+`ROADMAP.md` is the only source of truth for incomplete actionable work.

ROADMAP.md

@@ -23,10 +23,6 @@ history, not here.
   Why: six full :root token redefinitions (12, 4462, 5386, 13215, 15466, 17214), two divergent html.theme-light blocks (16701 vs 17628), three different :focus-visible rules, and a triplicated prefers-reduced-motion block — the effective theme is "whatever the last pass overrode" and ~⅓ of 18k lines is dead weight. Consolidate to one token block per theme; then retokenize the ~340 stray hex literals.
   Where: extension/com.opencut.panel/client/style.css
 
-- [ ] P2 — Concat lists in ~17 feature modules still use unescaped, platform-codec writes
-  Why: write_concat_list() now exists in helpers.py (UTF-8 + correct quote escaping) and the merge path uses it, but beat_cuts, ai_intro_gen, auto_dub_pipeline, photo_montage, instant_replay, cursor_zoom, event_recap, stream_highlights, video_360, generative_extend, auto_montage, glitch_effects, hook_generator, fit_to_fill, paper_edit, guest_compilation, stringout_reel still hand-roll open(path,"w") lists that break on apostrophes/non-ASCII names.
-  Where: opencut/core/* (grep: "file '" writes); replace with helpers.write_concat_list
-
 - [ ] P2 — Drawtext escaping is duplicated and wrong about apostrophes in ~10 modules
   Why: the local _escape_drawtext copies use \' inside single quotes (apostrophes silently dropped, graph can be mangled); helpers.escape_drawtext (ffmpeg-verified, expansion=none contract) should replace them.
   Where: opencut/core/caption_styles.py:365-372, click_overlay.py, news_ticker.py, quiz_overlay.py, telemetry_overlay.py, callout_gen.py, audiogram.py, brand_kit.py, end_screen.py, guest_compilation.py

opencut/core/ai_intro_gen.py

@@ -25,6 +25,7 @@
     output_path,
     require_package,
     run_ffmpeg,
+    write_concat_list,
 )
 
 logger = logging.getLogger("opencut")
@@ -715,9 +716,7 @@ def _prepend_intro(intro_path: str, main_video: str, out_path: str) -> str:
     _fd, concat_file = tempfile.mkstemp(suffix=".txt", prefix="intro_concat_")
     os.close(_fd)
     try:
-        with open(concat_file, "w") as f:
-            f.write(f"file '{intro_path}'\n")
-            f.write(f"file '{main_video}'\n")
+        write_concat_list([intro_path, main_video], concat_file)
 
         cmd = (FFmpegCmd()
                .option("f", "concat")

opencut/core/auto_chapter_art.py

@@ -21,6 +21,7 @@
 
 from opencut.helpers import (
     FFmpegCmd,
+    _concat_file_line,
     get_video_info,
     require_package,
     run_ffmpeg,
@@ -645,13 +646,13 @@ def _assemble_cards_to_video(card_paths: List[str], chapters: List[ChapterInfo],
     _fd, concat_file = tempfile.mkstemp(suffix=".txt", prefix="chapter_concat_")
     os.close(_fd)
     try:
-        with open(concat_file, "w") as f:
+        with open(concat_file, "w", encoding="utf-8") as f:
             for i, card_path in enumerate(card_paths):
-                f.write(f"file '{card_path}'\n")
+                f.write(_concat_file_line(card_path))
                 f.write(f"duration {config.card_duration}\n")
             # Repeat last frame to avoid truncation
             if card_paths:
-                f.write(f"file '{card_paths[-1]}'\n")
+                f.write(_concat_file_line(card_paths[-1]))
 
         cmd = (FFmpegCmd()
                .option("f", "concat")

opencut/core/auto_dub_pipeline.py

@@ -26,6 +26,7 @@
     get_video_info,
     output_path,
     run_ffmpeg,
+    write_concat_list,
 )
 
 logger = logging.getLogger("opencut")
@@ -601,9 +602,7 @@ def _composite_dubbed_audio(
             # Concatenate all TTS to single track
             concat_path = os.path.join(work_dir, "concat_tts.wav")
             list_path = os.path.join(work_dir, "concat_list.txt")
-            with open(list_path, "w") as f:
-                for seg in tts_segments_with_audio:
-                    f.write(f"file '{seg.tts_audio_path}'\n")
+            write_concat_list((seg.tts_audio_path for seg in tts_segments_with_audio), list_path)
             concat_cmd = (FFmpegCmd()
                           .option("f", "concat")
                           .option("safe", "0")

opencut/core/auto_montage.py

@@ -30,6 +30,7 @@
     get_video_info,
     output_path,
     run_ffmpeg,
+    write_concat_list,
 )
 
 logger = logging.getLogger("opencut")
@@ -416,9 +417,7 @@ def assemble_montage(
 
         # Concat all segments
         concat_file = os.path.join(tmp_dir, "concat.txt")
-        with open(concat_file, "w") as f:
-            for sp in segment_files:
-                f.write(f"file '{sp}'\n")
+        write_concat_list(segment_files, concat_file)
 
         concat_video = os.path.join(tmp_dir, "concat_video.mp4")
         cmd = [

opencut/core/beat_cuts.py

@@ -17,7 +17,14 @@
 from dataclasses import dataclass, field
 from typing import Callable, List, Optional
 
-from opencut.helpers import get_ffmpeg_path, get_ffprobe_path, get_video_info, output_path, run_ffmpeg
+from opencut.helpers import (
+    get_ffmpeg_path,
+    get_ffprobe_path,
+    get_video_info,
+    output_path,
+    run_ffmpeg,
+    write_concat_list,
+)
 
 logger = logging.getLogger("opencut")
 
@@ -421,9 +428,7 @@ def assemble_beat_synced(
 
         # Write concat list
         concat_file = os.path.join(tmp_dir, "concat.txt")
-        with open(concat_file, "w") as f:
-            for sp in segment_files:
-                f.write(f"file '{sp}'\n")
+        write_concat_list(segment_files, concat_file)
 
         # Concat video segments
         concat_video = os.path.join(tmp_dir, "concat_video.mp4")

opencut/core/beat_sync_edit.py

@@ -19,7 +19,14 @@
 from dataclasses import dataclass, field
 from typing import Callable, Dict, List, Optional, Tuple
 
-from opencut.helpers import get_ffmpeg_path, get_ffprobe_path, get_video_info, output_path, run_ffmpeg
+from opencut.helpers import (
+    get_ffmpeg_path,
+    get_ffprobe_path,
+    get_video_info,
+    output_path,
+    run_ffmpeg,
+    write_concat_list,
+)
 
 logger = logging.getLogger("opencut")
 
@@ -585,10 +592,7 @@ def assemble_beat_sync(
         fd, list_path = tempfile.mkstemp(suffix="_beatconcat.txt")
         os.close(fd)
         try:
-            with open(list_path, "w", encoding="utf-8") as f:
-                for p in segment_paths:
-                    safe_p = p.replace("\\", "/").replace("'", "'\\''")
-                    f.write(f"file '{safe_p}'\n")
+            write_concat_list(segment_paths, list_path)
 
             # Determine output path
             if output_path_val:

opencut/core/ceremony_autoedit.py

@@ -18,6 +18,7 @@
     get_video_info,
     output_path,
     run_ffmpeg,
+    write_concat_list,
 )
 
 logger = logging.getLogger("opencut")
@@ -421,10 +422,7 @@ def auto_edit_ceremony(
             on_progress(96, "Concatenating final video...")
 
         concat_path = os.path.join(tmp_dir, "concat.txt")
-        with open(concat_path, "w", encoding="utf-8") as f:
-            for seg in segment_files:
-                safe = seg.replace("\\", "/").replace("'", "'\\''")
-                f.write(f"file '{safe}'\n")
+        write_concat_list(segment_files, concat_path)
 
         cmd = (FFmpegCmd()
                .option("f", "concat")