Commit 2735a08
committed
fix: document CPU-only constraint on determineLocalComposing
Every commit/delete/selection path calls determineLocalComposing inside
runBlocking on the IME main thread. Safe today because all providers
(Latin BreakIterator, Han shape engine) are CPU-only, but a future
provider doing I/O would ANR on every keystroke.
Pinned the invariant at both the interface contract (NlpProviders.kt)
and the call site (AbstractEditorInstance.kt).1 parent eeae492 commit 2735a08
2 files changed
Lines changed: 6 additions & 0 deletions
File tree
- app/src/main/kotlin/dev/patrickgold/florisboard/ime
- editor
- nlp
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
351 | 351 | | |
352 | 352 | | |
353 | 353 | | |
| 354 | + | |
| 355 | + | |
354 | 356 | | |
355 | 357 | | |
356 | 358 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
206 | 210 | | |
207 | 211 | | |
208 | 212 | | |
| |||
0 commit comments