chore: remove legacy getINITModel2 gene-essentiality code#1068
Conversation
Gene essentiality now runs the Python ftINIT (tINIT2) pipeline (code/test/geneEssentiality.py + estimateEssentialGenes.py + evaluateHart2015Essentiality.py). Remove the superseded MATLAB implementation: - tINIT/getINITModel2.m old INIT algorithm; RAVEN ftINIT is its successor - tINIT/restoreModelGrRules.m orphan; restored grRules the old tINIT stripped - test/estimateEssentialGenes.m MATLAB; only caller of getINITModel2 - test/evaluateHart2015Essentiality.m MATLAB The Python equivalents, the Hart2015 data/results and the (already-Python) gene-essentiality workflow are the current pipeline and are untouched.
Model quality report
Each check name links to its explanation in the testResults README. Model checksDuplicate keys (model unloadable) and no growth block the merge; every other row is a non-blocking report.
MACAW and mass/charge balance
Model file and metabolic tasks
MEMOTETotal score: 63.2% (core subset) 0
Per-test scores
Full suite: 64.2% 0 · from the last The score above is the fast core subset. Comment Gene essentiality (Hart 2015)Not run automatically (it takes hours). Comment ❌ = a count rose vs the target branch (regression) · Full workflow run · this comment is edited as results come in |
Main improvements in this PR:
Remove the legacy MATLAB getINITModel2 gene-essentiality pipeline. Gene essentiality now runs the Python ftINIT (tINIT2) pipeline on raven-toolbox (
code/test/geneEssentiality.py→estimateEssentialGenes.py→raven_toolbox.init.ftinit), dispatched on demand bygene-essentiality.yml. The MATLAB implementation is superseded, so remove it:code/tINIT/getINITModel2.m— the old INIT algorithm (its own header names RAVEN ftINIT as the successor)code/tINIT/restoreModelGrRules.m— orphan; restored grRules that the old tINIT strippedcode/test/estimateEssentialGenes.m— MATLAB; the only caller ofgetINITModel2code/test/evaluateHart2015Essentiality.m— MATLABThe Python equivalents (
estimateEssentialGenes.py,evaluateHart2015Essentiality.py,geneEssentiality.py), the Hart2015 datasets, the committed results, and the (already-Python) gene-essentiality workflow are the current pipeline and are untouched. No model changes.Verified before removal:
getINITModel2andrestoreModelGrRuleshave no remaining callers, andgeneEssentiality.pyimports the Python modules (not the.mfiles), so nothing references the removed files.I hereby confirm that I have:
data/deprecatedIdentifiers/.developas target branch, and will be resolved with a squash-merge.mainas target branch, and will be resolved with a merge commit.