Fix metabolicTasks_Full.txt so it parses with parseTaskList#1070
Fix metabolicTasks_Full.txt so it parses with parseTaskList#1070edkerk wants to merge 2 commits into
Conversation
The full metabolic task list was missing the leading (empty) column that metabolicTasks_Essential.txt has, so RAVEN parseTaskList read the whole file as a single task. Add the leading column to align the format; parseTaskList now returns 257 tasks and compareMultipleModels runs against the full list. No task definitions are changed.
Model quality report
Each check name links to its explanation in the testResults README. Model checksDuplicate keys (model unloadable) and no growth block the merge; every other row is a non-blocking report.
MACAW and mass/charge balance
Model file and metabolic tasks
MEMOTETotal score: 63.2% (core subset) 0
Per-test scores
Full suite: 64.2% 0 · from the last The score above is the fast core subset. Comment Gene essentiality (Hart 2015)Not run automatically (it takes hours). Comment ❌ = a count rose vs the target branch (regression) · Full workflow run · this comment is edited as results come in |
data/metabolicTasks/metabolicTasks_Full.txtdoes not parse with the current RAVENparseTaskList. UnlikemetabolicTasks_Essential.txt, it is missing the leading empty column (17 vs 20 columns), so the entire file is read as a single task (parseTaskListreturns 1). Any workflow that uses the full task list — e.g.compareMultipleModels(..., true, taskFile)— then fails with:This PR adds the leading column so the format matches
metabolicTasks_Essential.txt. After the fix,parseTaskListreturns 257 tasks andcompareMultipleModelsruns against the full list.Only the leading column is added; no task definitions are changed. (Every line is touched because the column is prepended to each row.)