Skip to content

Commit a79888a

Browse files
seidewitzkris7t
authored andcommitted
ST6RI-752 Removed non-generated code for Relationship::source / target.
- Moved special handling of ownedRelatedElements for Dependencies to post-processing in an adapter.
1 parent 81fcb1c commit a79888a

5 files changed

Lines changed: 58 additions & 36 deletions

File tree

kerml/src/examples/Simple Tests/Dependencies.kerml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ package Dependencies {
88

99
import System::*;
1010

11-
// dependency Use from 'Application Layer' to 'Service Layer';
12-
// dependency from 'Service Layer' to 'Data Layer';
11+
dependency Use from 'Application Layer' to 'Service Layer';
12+
dependency from 'Service Layer' to 'Data Layer';
1313

1414
feature x;
1515
feature y;
Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
/*******************************************************************************
2+
* SysML 2 Pilot Implementation
3+
* Copyright (c) 2024 Model Driven Solutions, Inc.
4+
*
5+
* This program is free software: you can redistribute it and/or modify
6+
* it under the terms of the GNU Lesser General Public License as published by
7+
* the Free Software Foundation, either version 3 of the License, or
8+
* (at your option) any later version.
9+
*
10+
* This program is distributed in the hope that it will be useful,
11+
* but WITHOUT ANY WARRANTY; without even the implied warranty of
12+
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13+
* GNU Lesser General Public License for more details.
14+
*
15+
* You should have received a copy of the GNU Lesser General Public License
16+
* along with this program. If not, see <https://www.gnu.org/licenses/>.
17+
*
18+
* @license LGPL-3.0-or-later <http://spdx.org/licenses/LGPL-3.0-or-later>
19+
*
20+
*******************************************************************************/
21+
22+
package org.omg.sysml.adapter;
23+
24+
import org.eclipse.emf.common.util.EList;
25+
import org.eclipse.emf.ecore.util.EObjectResolvingEList;
26+
import org.omg.sysml.lang.sysml.Dependency;
27+
import org.omg.sysml.lang.sysml.Element;
28+
29+
public class DependencyAdapter extends RelationshipAdapter {
30+
31+
public DependencyAdapter(Dependency element) {
32+
super(element);
33+
}
34+
35+
public Dependency getTarget() {
36+
return (Dependency)super.getTarget();
37+
}
38+
39+
public void postProcess() {
40+
Dependency target = getTarget();
41+
42+
// Add all ownedRelatedElements to supplier.
43+
EObjectResolvingEList<Element> suppliers = (EObjectResolvingEList<Element>)target.getSupplier();
44+
EList<Element> ownedRelatedElements = target.getOwnedRelatedElement();
45+
ownedRelatedElements.stream().forEachOrdered(suppliers::addUnique);
46+
}
47+
48+
}

org.omg.sysml/src/org/omg/sysml/adapter/ElementAdapterFactory.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,11 @@ public ElementAdapter caseDefinition(Definition element) {
192192
return new DefinitionAdapter(element);
193193
}
194194

195+
@Override
196+
public ElementAdapter caseDependency(Dependency element) {
197+
return new DependencyAdapter(element);
198+
}
199+
195200
@Override
196201
public ElementAdapter caseDifferencing(Differencing element) {
197202
return new DifferencingAdapter(element);

org.omg.sysml/syntax-gen/org/omg/sysml/lang/sysml/impl/DependencyImpl.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,11 @@ public boolean isSetSource() {
153153
/**
154154
* <!-- begin-user-doc -->
155155
* Xtext workaround:
156-
* getTarget() is inherited from Relationship.
157156
* <!-- end-user-doc -->
158157
* @generated
159158
*/
160159
@Override
161-
public EList<Element> getTargetGen() {
160+
public EList<Element> getTarget() {
162161
return getSupplier();
163162
}
164163

org.omg.sysml/syntax-gen/org/omg/sysml/lang/sysml/impl/RelationshipImpl.java

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -238,25 +238,11 @@ else if (eNotificationRequired())
238238

239239
/**
240240
* <!-- begin-user-doc -->
241-
* Xtext workaround:
242-
* Add all ownedRelatedElements to target.
243241
* <!-- end-user-doc -->
244-
* @generated NOT
242+
* @generated
245243
*/
246244
@Override
247245
public EList<Element> getTarget() {
248-
EList<Element> targets = getTargetGen();
249-
EList<Element> ownedRelatedElements = getOwnedRelatedElement();
250-
ownedRelatedElements.stream().filter(e->!targets.contains(e)).forEachOrdered(targets::add);
251-
return targets;
252-
}
253-
254-
/**
255-
* <!-- begin-user-doc -->
256-
* <!-- end-user-doc -->
257-
* @generated
258-
*/
259-
public EList<Element> getTargetGen() {
260246
if (target == null) {
261247
target = new EObjectResolvingEList<Element>(Element.class, this, SysMLPackage.RELATIONSHIP__TARGET);
262248
}
@@ -265,27 +251,11 @@ public EList<Element> getTargetGen() {
265251

266252
/**
267253
* <!-- begin-user-doc -->
268-
* Xtext workaround:
269-
* If source is empty, then add all owningRelatedElements to it.
270254
* <!-- end-user-doc -->
271-
* @generated NOT
255+
* @generated
272256
*/
273257
@Override
274258
public EList<Element> getSource() {
275-
EList<Element> sources = getSourceGen();
276-
Element owningRelatedElement = getOwningRelatedElement();
277-
if (sources.isEmpty() && owningRelatedElement != null && !getTarget().contains(owningRelatedElement)) {
278-
sources.add(owningRelatedElement);
279-
}
280-
return sources;
281-
}
282-
283-
/**
284-
* <!-- begin-user-doc -->
285-
* <!-- end-user-doc -->
286-
* @generated
287-
*/
288-
public EList<Element> getSourceGen() {
289259
if (source == null) {
290260
source = new EObjectResolvingEList<Element>(Element.class, this, SysMLPackage.RELATIONSHIP__SOURCE);
291261
}

0 commit comments

Comments
 (0)