PR/main向け軽量CIワークフローを追加#16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mainブランチへのpushごとに最低限のフロントエンド+Rustの検証を自動化して早期に問題を検出するため。build-release.yml)とは分離して、PR段階では軽量確認に留める運用を定義するため。Description
.github/workflows/ci.ymlでpull_request/push(main)時にフロントエンドのlint/build/test、node:test整合性チェック、cargo check/cargo testを実行するようにした。package.jsonにtest(vitest run)とtest:consistency(node --test tests/*.test.mjs)のnpm scriptを追加した。tests/ciWorkflowConsistency.test.mjsを追加し、既存のtests/readmeConsistency.test.mjsにCIテストの記載確認を追加した。README.mdとCONTRIBUTING.mdを更新して、ローカルでの最低限の事前確認コマンド(npm run lint、npm run build、npm test、npm run test:consistency、cargo check、cargo test)とCI/Releaseの役割分担を明記した。Testing
npm run lintは問題なく成功した。npm run build(tsc -b && vite build)は成功し、フロントエンドがビルドできることを確認した。npm test(vitest run)は全テストが成功し、5ファイル・52テストが通過した。npm run test:consistency(node --test tests/*.test.mjs)は全て成功し、合計25テストがパスした。cargo check --manifest-path src-tauri/Cargo.tomlはローカルで実行した際にglib-2.0のシステムライブラリが見つからず失敗したためCIでの実行を想定している(ワークフローにLinux依存パッケージのインストール手順を含めている)。Codex Task