fix(ptdatax): new tab link on Portal requires CMS nav ready#538
Merged
Conversation
Extract link initialization into `initLinks` and branch on whether `#s-cms-nav` exists: call immediately on plain CMS pages, or wait for the `cms-nav:ready` event (with a `data-nav-ready` flag fallback to catch the case where the event already fired). Co-authored-by: Cursor <cursoragent@cursor.com>
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
marked this pull request as draft
May 26, 2026 21:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Wrap
findLinksAndSetTargets, and defer until CMS nav signals it is ready.open-certain-links-in-new-tab.jswas callingfindLinksAndSetTargetsimmediately at load time. On Portal pages the CMS nav is injected asynchronously, so the target links don't exist yet.Related
Changes
findLinksAndSetTargetscall intoinitLinksfunctionTesting
internal-docslinks still open in a new tab.internal-docslinks newly open in a new tab.UI
CMS.mov
Portal.mov
Made with Cursor