fix: hidden a11y text should not require asset

[wesleyboar]

Overview

Hide a11y text via hidden not a class, because class requires stylesheet to have loaded.

When testing TACC/Core-Portal#1303, a11y text showed on screen before Bootstrap stylesheet had loaded.

Related

• fixes UI bug with feat: custom scripts via PORTAL_JS_FILENAMES Core-Portal#1303

Changes

• changed className to hidden attribute

Testing

0. Have external link without accessible descritpion.
   _{(e.g. a CMS Nav link that opens site in new tab.)}
1. Deploy with (or on-the-fly change to use) new code.
2. Verify link a11y description is still "Opens in a new window".
3. Verify element with text "Opens in a new window":
   • is hidden
   • not class="sr-only"

UI

Before.mov

After.mov

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →