Skip to content

fix: menu position and function since Bootstrap 5#1072

Closed
wesleyboar wants to merge 7 commits into
fix/use-core-styles-v2-headerfrom
fix/WP-895-portal-nav-position-inaccurate-still
Closed

fix: menu position and function since Bootstrap 5#1072
wesleyboar wants to merge 7 commits into
fix/use-core-styles-v2-headerfrom
fix/WP-895-portal-nav-position-inaccurate-still

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Mar 3, 2025

Copy link
Copy Markdown
Member

Overview

  • Do not let Portal Nav dropdown menu be positioned off-screen horizontally.
  • Fix CMS dropdown menu not opening.
  • Fix navbar toggle not working (narrow screen).

Related

Changes

  • changed classes from Bootstrap4 to Bootstrap 5

Testing

  1. Be in Portal (not on a CMS page).

Portal Nav Dropdown Off-Screen

  1. Click portal nav dropdown menu.
  2. Verify dropdown menu is not off the right side of the window.

CMS Dropdown Menu Not Opening

  1. Create/Find a CMS menu that with a dropdown.
  2. Click dropdown menu button.
  3. Verify dropdown menu opens.

Fix Navbar Toggle Not Working

  1. Make screen narrow enough to hide menu.
  2. Verify menu toggle opens menu.

UI

Portal Nav Dropdown Off-Screen

fix.nav.position.more.mov

CMS Dropdown Menu Not Opening

Fixed

cms.dropdown.menus.FIXED.mov

Broken

cms.dropdown.menus.BROKEN.mov

Fix Navbar Toggle Not Working

Fixed

navbar.expand-collapse.FIXED.mov

Broken

navbar.expand-collapse.BROKEN.mov

@wesleyboar wesleyboar changed the title fix: dropdown menu position offscreen fix: dropdown menu position horz. off-screen Mar 3, 2025
@wesleyboar
wesleyboar requested review from fnets and taoteg March 3, 2025 23:26
@codecov

codecov Bot commented Mar 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (a1f2bfb) to head (ea291d1).

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           fix/use-core-styles-v2-header    #1072   +/-   ##
==============================================================
  Coverage                          70.34%   70.34%           
==============================================================
  Files                                538      538           
  Lines                              33328    33328           
  Branches                            2953     2953           
==============================================================
  Hits                               23446    23446           
  Misses                              9684     9684           
  Partials                             198      198           
Flag Coverage Δ
javascript 72.53% <ø> (ø)
unittests 61.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@taoteg taoteg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesleyboar
wesleyboar marked this pull request as draft March 3, 2025 23:35
@wesleyboar wesleyboar changed the title fix: dropdown menu position horz. off-screen fix: menu position and function since Bootstrap 5 Mar 3, 2025
@wesleyboar
wesleyboar changed the base branch from fix/use-core-styles-v2-header to main March 4, 2025 00:02
@wesleyboar
wesleyboar changed the base branch from main to fix/use-core-styles-v2-header March 4, 2025 00:03
@wesleyboar

Copy link
Copy Markdown
Member Author

Wrong base branch. Try again, Wes.

@wesleyboar wesleyboar closed this Mar 4, 2025
@wesleyboar
wesleyboar deleted the fix/WP-895-portal-nav-position-inaccurate-still branch March 19, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants