fix: wp-895 menu bugs since bootstrap 5#1073
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1073 +/- ##
=======================================
Coverage 70.34% 70.34%
=======================================
Files 538 538
Lines 33328 33328
Branches 2953 2953
=======================================
Hits 23446 23446
Misses 9684 9684
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
wesleyboar
commented
Mar 4, 2025
wesleyboar
left a comment
wesleyboar
left a comment
Member
Author
There was a problem hiding this comment.
Notes for reviewers.
Member
Author
Comment on lines
+25
to
+41
|
|
||
| /* Make (CMS) Bootstrap 4 toggle compatible with (Portal) Bootstrap 5 */ | ||
| [ ...container.querySelectorAll('[data-toggle]')].forEach(toggle => { | ||
| const cmsUsesBootstrap4Toggle = ( | ||
| toggle.dataset.toggle !== undefined && | ||
| toggle.dataset.bsToggle === undefined | ||
| ) | ||
|
|
||
| if ( cmsUsesBootstrap4Toggle ) { | ||
| toggle.dataset.bsToggle = toggle.dataset.toggle; | ||
| delete toggle.dataset.toggle; | ||
| console.log( | ||
| 'Replaced `data-toggle` with `data-bs-toggle` in `#s-cms-nav`.', | ||
| 'To not need this, update CMS Bootstrap from 4 to 5.' | ||
| ) | ||
| } | ||
| }); |
Member
Author
There was a problem hiding this comment.
Like my working fix in CMS for Portal nav, but reversed.
wesleyboar
commented
Mar 4, 2025
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Mar 4, 2025
PR TACC/Core-Portal#1073/1066 fixes portal nav dropdown menu alignment. But that breask alignment for CMS, because CMS uses old Bootstrap.
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Mar 4, 2025
* fix: WP-894 portal nav dropdown menu alignment PR TACC/Core-Portal#1073/1066 fixes portal nav dropdown menu alignment. But that breask alignment for CMS, because CMS uses old Bootstrap. * refactor: make fix independent of similar fix * fix: missing punctuation
rstijerina
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Do not let Portal Nav dropdown menu be positioned off-screen horizontally.Fix moved to Fix: Workbench drop down menu is cut off on the right. #1066.
Important
Upon merge, notify @shayanaijaz, so he can update Digital Rocks Portal branch(es).
Related
Changes
Testing
3. Portal Nav Dropdown Off-Screen
Also fixed in #1066.
4. CMS Dropdown Menu Not Opening
5. Fix Navbar Toggle Not Working
UI
3. Portal Nav Dropdown Off-Screen
fix.nav.position.more.mov
Also fixed in #1066.
4. CMS Dropdown Menu Not Opening
Fixed
cms.dropdown.menu.dev-cep.works.mov
Warning
Unable to test locally because of WP-897.
Broken
cms.dropdown.menus.BROKEN.mov
5. Fix Navbar Toggle Not Working
Fixed
navbar.expand-collapse.FIXED.mov
Broken
navbar.expand-collapse.BROKEN.mov