feat: WC-274 isolate external styles for component#1126
Closed
wesleyboar wants to merge 4 commits into
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1126 +/- ##
==========================================
+ Coverage 70.68% 70.73% +0.04%
==========================================
Files 540 542 +2
Lines 33572 33736 +164
Branches 2989 3011 +22
==========================================
+ Hits 23732 23864 +132
- Misses 9632 9664 +32
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The testing might be overkill. It passed before the fix was added.
to help in debugging solution to hot reload error in dev
20 tasks
Member
Author
|
Not working yet. Non-standard use of React. Hot reload errors in dev. React 19 (supports web components) not available. Replaced by #1127. Refactor in I should probably not try Shadow DOM in React again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Allow loading a component that uses external styles that are isolated such that they do not conflict with portal styles.
Important
Proof of Concept. Do not merge as is.
Status
Related
Changes
Testing
UI
So far…
Notes
I made styles for CMS-powered content1, but now I learn the function will be built in React. But CMS global styles might conflict with Portal global styles.
Footnotes
Like DesignSafe Tools & Apps Overview pages. ↩