Skip to content

refactor(a11y): logged-in dropdown as button not link #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesleyboar wants to merge 8 commits into
base: main
Choose a base branch
from
+2 −2
Open

refactor(a11y): logged-in dropdown as button not link #1256

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f243aae
refactor: logged-in dropdown as button not link
cursoragent Mar 20, 2026
2b6ba6c
fix: css for button-based dropdown
wesleyboar Mar 24, 2026
772d398
Merge branch 'main' into cursor/tup-ui-changes-port-6eca
wesleyboar Mar 24, 2026
155faa3
Merge branch 'cursor/tup-ui-changes-port-6eca' of github.com:wesleybo…
wesleyboar Mar 24, 2026
b9c0eb4
Revert "fix: css for button-based dropdown"
wesleyboar Mar 24, 2026
894d63f
Merge branch 'main' into cursor/tup-ui-changes-port-6eca
rstijerina Apr 8, 2026
b8a37ad
Merge branch 'main' into cursor/tup-ui-changes-port-6eca
rstijerina Apr 9, 2026
172bffd
Merge branch 'main' into cursor/tup-ui-changes-port-6eca
wesleyboar May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/portal/templates/includes/nav_portal.raw.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
{% endif %}
{% if user.is_authenticated %}
<li class="nav-item dropdown" style="{% if settings.DOCS_CHATBOT_URL %}border-left: 1px solid var(--header-minor-border-color);{% endif %}">
<a class="nav-link dropdown-toggle" href="#" id="navbarDropdown" role="button" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
<button class="nav-link dropdown-toggle" id="navbarDropdown" type="button" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
<i class="icon icon-user" role="presentation"></i>
<span>{{ user.get_username }}</span>
<span class="sr-only">Toggle Dropdown</span>
</a>
</button>
<nav class="dropdown-menu dropdown-menu-end">
<a class="dropdown-item" href="{% url 'workbench:dashboard' %}">
<i class="icon icon-dashboard" role="presentation"></i> My Dashboard
Expand Down
Loading