Skip to content

task/WI-398: Update Allocation Onboarding Check#1299

Merged
fnets merged 4 commits into
mainfrom
task/WI-398
May 26, 2026
Merged

task/WI-398: Update Allocation Onboarding Check#1299
fnets merged 4 commits into
mainfrom
task/WI-398

Conversation

@fnets
Copy link
Copy Markdown
Contributor

@fnets fnets commented May 15, 2026

Overview

Added part to allocation check that validates if a user has an allocation with access to a specific machine.

Related

Changes

Adds an expected_host setting to the allocation check in onboarding, and will not let the user access the portal if they do not have an allocation with access to that host.

Testing

  1. Either in settings_default.py or settings_custom.py, add the snippet below to your _PORTAL_USER_ACCOUNT_SETUP_STEPS:
{
        'step': 'portal.apps.onboarding.steps.allocation.AllocationStep',
        'settings': {
            'expected_hosts': ['vista.tacc.utexas.edu']
        }
 },
  1. Reset your user's onboarding steps, and the portal should check if you have an allocation with access to Vista. Then it will grant you access to the portal depending on whether or not that is true. The logs should show which steps failed or passed and for which hosts.
  2. Now add a second host to the array, for example frontera.tacc.utexas.edu. Test two or more expected hosts where you don't have access to all of them. Reset your user's onboarding steps again and the logs should let you know which hosts failed.
  3. If you remove expected_host from the settings in the snippet, the portal should only check if you have any active allocations at all.

UI

Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.01%. Comparing base (bb174f9) to head (56410a1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   63.98%   64.01%   +0.02%     
==========================================
  Files         461      461              
  Lines       13723    13733      +10     
  Branches     2738     2735       -3     
==========================================
+ Hits         8781     8791      +10     
  Misses       4595     4595              
  Partials      347      347              
Flag Coverage Δ
javascript 67.04% <ø> (ø)
unittests 60.79% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
server/portal/apps/onboarding/steps/allocation.py 82.35% <100.00%> (+7.35%) ⬆️
server/portal/settings/settings_default.py 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread server/portal/settings/settings_default.py Outdated
Comment thread server/portal/apps/onboarding/steps/allocation.py Outdated
@fnets fnets marked this pull request as draft May 18, 2026 16:41
@fnets fnets marked this pull request as ready for review May 20, 2026 16:46
Copy link
Copy Markdown
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

Copy link
Copy Markdown
Member

@happycodemonkey happycodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fnets fnets merged commit 81ada36 into main May 26, 2026
6 checks passed
@fnets fnets deleted the task/WI-398 branch May 26, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants