feat: custom scripts via PORTAL_JS_FILENAMES#1303
Draft
wesleyboar wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
- Coverage 64.09% 64.09% -0.01%
==========================================
Files 461 461
Lines 13793 13794 +1
Branches 2750 2750
==========================================
Hits 8841 8841
- Misses 4603 4604 +1
Partials 349 349
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
May 26, 2026
## Overview Hide a11y text via `hidden` not a class, because class requires stylesheet to have loaded. _When testing TACC/Core-Portal#1303, a11y text showed on screen before Bootstrap stylesheet had loaded._ ## Related - fixes UI bug with TACC/Core-Portal#1303 ## Changes - **changed** className to `hidden` attribute ## Testing 0. Have external link without accessible descritpion. <sub>(e.g. a CMS Nav link that opens site in new tab.)</sub> 1. Deploy with (or on-the-fly change to use) new code. 2. Verify link a11y description is still "Opens in a new window". 3. Verify element with text "Opens in a new window": - is `hidden` - not `class="sr-only"` ## UI https://github.com/user-attachments/assets/316dbed1-769e-4d12-a655-f147801fd036 https://github.com/user-attachments/assets/e131f8f5-447b-4372-8aa0-c35b1e492923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
PORTAL_JS_FILENAMES(like existingPORTAL_CSS_FILENAMES).Enables the client-side solution for WP-1230: a custom script on PTDataX needs to run on Portal pages, but Portal had no mechanism for per-project JS.
Related
Changes
PORTAL_JS_FILENAMESPORTAL_…_FILENAMESTesting
UI
Tip
Tested on https://pprd.ptdatax.tacc.utexas.edu/.
On.Portal.CMS.Nav.Documentation.Link.Opens.in.New.Tab.mov
Still Works on CMS Too
On.CMS.mov
Notes
Important
Assumes
type="module". Could instead allow object instead of array, like CMSPORTAL_LOGOandPORTAL_FAVICON, as could otherPORTAL_…_FILENAMES.