fix: moving a column in TAStudio to near the end could scroll horizontally

Author: SuuperW

src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs

@@ -1660,13 +1660,9 @@ private void DoColumnReorder()
 			{
 				var oldIndex = _columns.IndexOf(_columnDown);
 				var newIndex = _columns.IndexOf(CurrentCell.Column);
+				_columns.Move(oldIndex, newIndex);
 
 				ColumnReordered?.Invoke(this, new ColumnReorderedEventArgs(oldIndex, newIndex, _columnDown));
-
-				//TODO surely this only works properly in one direction?
-				// also the event is "...Reordered"--past tense--so it should be called AFTER the change --yoshi
-				_columns.Remove(_columnDown);
-				_columns.Insert(newIndex, _columnDown);
 			}
 		}
 

src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/RollColumns.cs

@@ -87,6 +87,15 @@ public void ColumnsChanged()
 			return result;
 		}
 
+		public void Move(int oldIndex, int newIndex)
+		{
+			RollColumn col = this[oldIndex];
+			_suspendChanged = true;
+			RemoveAt(oldIndex);
+			_suspendChanged = false;
+			Insert(newIndex, col);
+		}
+
 		public new int RemoveAll(Predicate<RollColumn> match)
 		{
 			var result = base.RemoveAll(match);