Make GuiApi init lazier to get LuaTestContext working under .NET 8

Author: YoshiRulz

src/BizHawk.Client.Common/Api/Classes/GuiApi.cs

@@ -16,6 +16,11 @@ namespace BizHawk.Client.Common
 {
 	public sealed class GuiApi : IGuiApi
 	{
+		private static Bitmap/*?*/ field = null;
+
+		private static Bitmap NullGraphicsBitmap
+			=> field ??= new(1, 1);
+
 		private static readonly StringFormat PixelTextFormat = new(StringFormat.GenericTypographic)
 		{
 			FormatFlags = StringFormatFlags.MeasureTrailingSpaces,
@@ -32,8 +37,6 @@ public sealed class GuiApi : IGuiApi
 
 		private readonly Dictionary<string, Bitmap> _imageCache = new();
 
-		private readonly Bitmap _nullGraphicsBitmap = new(1, 1);
-
 		private CompositingMode _compositingMode = CompositingMode.SourceOver;
 
 		private Color? _defaultBackground;
@@ -46,7 +49,7 @@ public sealed class GuiApi : IGuiApi
 
 		private (int Left, int Top, int Right, int Bottom) _padding = (0, 0, 0, 0);
 
-		private readonly FontFamily[] _pixelFonts;
+		private FontFamily[]/*?*/ _pixelFonts = null;
 
 		private DisplaySurfaceID? _usingSurfaceID;
 		public bool HasGUISurface => true;
@@ -59,12 +62,14 @@ public GuiApi(
 			_dialogController = dialogController;
 			LogCallback = logCallback;
 			_displayManager = displayManager;
-			_pixelFonts = (new[]
+		}
+
+		private IReadOnlyList<FontFamily> PixelFonts
+			=> _pixelFonts ??= (new[]
 			{
 				"fceux",
 				"gens",
 			}).Select(s => _displayManager.CustomFonts.Families.First(f => f.Name.EqualsIgnoreCase(s))).ToArray();
-		}
 
 		private I2DRenderer Get2DRenderer(DisplaySurfaceID? surfaceID)
 		{
@@ -310,7 +315,7 @@ public void DrawImage(string path, int x, int y, int? width = null, int? height
 		public void ClearImageCache()
 		{
 			_imageCache.Clear();
-			_displayManager.ClearApiHawkTextureCache();
+			_displayManager?.ClearApiHawkTextureCache();
 		}
 
 		public void DrawImageRegion(Image img, int source_x, int source_y, int source_width, int source_height, int dest_x, int dest_y, int? dest_width = null, int? dest_height = null, DisplaySurfaceID? surfaceID = null)
@@ -432,7 +437,7 @@ public void DrawString(int x, int y, string message, Color? forecolor = null, Co
 					_ => FontStyle.Regular,
 				};
 
-				using var g = Graphics.FromImage(_nullGraphicsBitmap);
+				using var g = Graphics.FromImage(NullGraphicsBitmap);
 
 				// The text isn't written out using GenericTypographic, so measuring it using GenericTypographic seemed to make it worse.
 				// And writing it out with GenericTypographic just made it uglier. :p
@@ -527,8 +532,8 @@ public void PixelText(
 						break;
 				}
 
-				using var g = Graphics.FromImage(_nullGraphicsBitmap);
-				var font = new Font(_pixelFonts[index], 8, FontStyle.Regular, GraphicsUnit.Pixel);
+				using var g = Graphics.FromImage(NullGraphicsBitmap);
+				Font font = new(PixelFonts[index], 8, FontStyle.Regular, GraphicsUnit.Pixel);
 				var sizeOfText = g.MeasureString(message, font, width: 0, PixelTextFormat).ToSize();
 
 				var r = Get2DRenderer(surfaceID);

src/BizHawk.Tests.Client.Common/lua/LuaTestContext.cs

@@ -28,7 +28,7 @@ public LuaTestContext()
 				emulator.ServiceProvider,
 				print,
 				mainApi,
-				new SimpleGDIPDisplayManager(config, emulator),
+				null!,
 				null!,
 				null!,
 				null!,