make InputRoll handle its own ShowColumnTextOnHover redrawing on pointed cell change

Author: SuuperW

src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs

@@ -1047,21 +1047,12 @@ protected override void OnMouseMove(MouseEventArgs e)
 
 			Cell newCell = CalculatePointedCell(_currentX.Value, _currentY.Value);
 
-			if (!newCell.Equals(CurrentCell))
+			bool changed = CellChanged(newCell);
+			if (changed && (ShowColumnTextOnHover || IsHoveringOnColumnCell || WasHoveringOnColumnCell))
 			{
-				CellChanged(newCell);
-
-				if (IsHoveringOnColumnCell
-					|| (WasHoveringOnColumnCell && !IsHoveringOnColumnCell))
-				{
-					Refresh();
-				}
-				else if (_columnDown != null)
-				{
-					Refresh();
-				}
+				Refresh();
 			}
-			else if (_columnDown != null)  // Kind of silly feeling to have this check twice, but the only alternative I can think of has it refreshing twice when pointed column changes with column down, and speed matters
+			else if (_columnDown != null)
 			{
 				Refresh();
 			}
@@ -1588,13 +1579,15 @@ private void OrientationChanged()
 		/// <summary>
 		/// Call this function to change the CurrentCell to newCell
 		/// </summary>
-		private void CellChanged(Cell newCell)
+		/// <returns>true if CurrentCell was changed</returns>
+		private bool CellChanged(Cell newCell)
 		{
+			if (newCell == CurrentCell) return false;
+
 			_lastCell = CurrentCell;
 			CurrentCell = newCell;
 
-			if (PointedCellChanged is not null
-				&& !(_lastCell?.Column == CurrentCell.Column && _lastCell?.RowIndex == CurrentCell.RowIndex)) //TODO isn't this just `Cell.==`? --yoshi
+			if (PointedCellChanged is not null)
 			{
 				PointedCellChanged(this, new CellEventArgs(_lastCell, CurrentCell));
 			}
@@ -1607,6 +1600,8 @@ private void CellChanged(Cell newCell)
 			{
 				_hoverTimer.Stop();
 			}
+
+			return true;
 		}
 
 		private void VerticalBar_ValueChanged(object sender, EventArgs e)

src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs

@@ -1279,7 +1279,6 @@ private void TasView_PointedCellChanged(object sender, InputRoll.CellEventArgs e
 
 			if (e.NewCell.RowIndex is null || !MouseButtonHeld)
 			{
-				SetTasViewRowCount(); // redraw
 				return;
 			}