Remove TI83Hawk

Author: YoshiRulz

README.md

@@ -4,7 +4,7 @@ An emulation project.
 
 EmuHawk is a multi-system emulator written in C#. As well as quality-of-life features for casual players, it also has recording/playback and debugging tools, making it the first choice for TASers (Tool-Assisted Speedrunners). More info [below](#features-and-systems).
 
-A7800Hawk, Atari2600Hawk, C64Hawk, ChannelFHawk, ColecoHawk, GBHawk, IntelliHawk, NesHawk, O2Hawk, PCEHawk, SMSHawk, TI83Hawk, VectrexHawk, and ZXHawk are bespoke emulation cores written in C#.
+A7800Hawk, Atari2600Hawk, C64Hawk, ChannelFHawk, ColecoHawk, GBHawk, IntelliHawk, NesHawk, O2Hawk, PCEHawk, SMSHawk, VectrexHawk, and ZXHawk are bespoke emulation cores written in C#.
 MSXHawk is a bespoke emulation core written in C++.
 More info [below](#cores).
 
@@ -357,7 +357,7 @@ Sega Master System | **Genplus-gx**, **SMSHawk**
 Sega Saturn | **Saturnus**
 SNES | **BSNES**, Faust, Snes9x
 Super Game Boy | **BSNES**, **Gambatte**
-TI-83 | **Emu83**, **TI83Hawk**
+TI-83 | **Emu83**
 TIC-80 | **TIC-80** reference implementation
 TurboGrafx | HyperNyma, **PCEHawk**, **TurboNyma**
 Uzebox | **Uzem**

src/BizHawk.Client.Common/config/Config.cs

@@ -50,8 +50,6 @@ public class Config
 				[ CoreNames.Gpgx, CoreNames.SMSHawk ]),
 			([ VSystemID.Raw.SNES ],
 				[ CoreNames.Snes9X, CoreNames.Bsnes115, CoreNames.SubBsnes115, CoreNames.Faust, CoreNames.Bsnes ]),
-			([ VSystemID.Raw.TI83 ],
-				[ CoreNames.Emu83, CoreNames.TI83Hawk ]),
 		};
 
 		public static Dictionary<string, string> GenDefaultCorePreferences()

src/BizHawk.Client.EmuHawk/MainForm.Designer.cs

@@ -13,7 +13,6 @@
 using BizHawk.Emulation.Cores.Atari.Jaguar;
 using BizHawk.Emulation.Cores.Atari.Lynx;
 using BizHawk.Emulation.Cores.Calculators.Emu83;
-using BizHawk.Emulation.Cores.Calculators.TI83;
 using BizHawk.Emulation.Cores.ColecoVision;
 using BizHawk.Emulation.Cores.Computers.Amiga;
 using BizHawk.Emulation.Cores.Computers.AmstradCPC;
@@ -894,34 +893,6 @@ private void SNES_ToggleObj(int layer)
 		private void Ti83KeypadMenuItem_Click(object sender, EventArgs e)
 			=> Tools.Load<TI83KeyPad>();
 
-		private void Ti83LoadTIFileMenuItem_Click(object sender, EventArgs e)
-		{
-			if (Emulator is not TI83 ti83) return;
-			var result = this.ShowFileOpenDialog(
-				discardCWDChange: true,
-				filter: TI83ProgramFilesFSFilterSet,
-				initDir: Config.PathEntries.RomAbsolutePath(Emulator.SystemId));
-			if (result is null) return;
-			try
-			{
-				ti83.LinkPort.SendFileToCalc(File.OpenRead(result), true);
-				return;
-			}
-			catch (IOException ex)
-			{
-				if (this.ShowMessageBox3(
-					owner: null,
-					icon: EMsgBoxIcon.Question,
-					caption: "Upload Failed",
-					text: $"Invalid file format. Reason: {ex.Message} \nForce transfer? This may cause the calculator to crash.")
-						is not true)
-				{
-					return;
-				}
-			}
-			ti83.LinkPort.SendFileToCalc(File.OpenRead(result), false);
-		}
-
 		private DialogResult OpenTI83PaletteSettingsDialog(ISettingsAdapter settable)
 		{
 			using TI83PaletteConfig form = new(settable);
@@ -933,7 +904,6 @@ private void Ti83PaletteMenuItem_Click(object sender, EventArgs e)
 			var result = Emulator switch
 			{
 				Emu83 => OpenTI83PaletteSettingsDialog(GetSettingsAdapterForLoadedCore<Emu83>()),
-				TI83 => OpenTI83PaletteSettingsDialog(GetSettingsAdapterForLoadedCore<TI83>()),
 				_ => DialogResult.None
 			};
 			if (result.IsOk()) AddOnScreenMessage("Palette settings saved");
@@ -1386,9 +1356,6 @@ ToolStripMenuItemEx CreateCoreSubmenu(VSystemCategory cat, string coreName, para
 			};
 			items.Add(subNESHawkSubmenu);
 
-			// TI83Hawk
-			items.Add(CreateCoreSubmenu(VSystemCategory.Other, CoreNames.TI83Hawk, CreateSettingsItem("Palette...", (_, _) => OpenTI83PaletteSettingsDialog(GetSettingsAdapterFor<TI83>()))));
-
 			// TIC80
 			items.Add(CreateCoreSubmenu(VSystemCategory.PCs, CoreNames.TIC80, CreateGenericCoreConfigItem<TIC80>(CoreNames.TIC80)));
 
@@ -1486,7 +1453,6 @@ private void HandlePlatformMenus()
 					break;
 				case VSystemID.Raw.TI83:
 					TI83SubMenu.Visible = true;
-					LoadTIFileMenuItem.Visible = Emulator is TI83;
 					break;
 				case VSystemID.Raw.ZXSpectrum:
 					zXSpectrumToolStripMenuItem.Visible = true;

src/BizHawk.Client.EmuHawk/MainForm.VSystem.cs

@@ -4275,7 +4275,6 @@ bool PromptToSwitchCore(string currentCore, string recommendedCore, Action disab
 			var recommendedCore = currentCoreName switch
 			{
 				CoreNames.Snes9X => CoreNames.Bsnes115,
-				CoreNames.TI83Hawk => CoreNames.Emu83,
 				CoreNames.QuickNes => CoreNames.NesHawk,
 				CoreNames.Atari2600Hawk => CoreNames.Stella,
 				CoreNames.HyperNyma => CoreNames.TurboNyma,

src/BizHawk.Client.EmuHawk/MainForm.cs

@@ -589,7 +589,6 @@ void AddSnesSramDomain(string domain)
 						break;
 					case ConsoleID.TI83:
 						TryAddDomain("RAM"); // Emu83
-						TryAddDomain("Main RAM"); // TI83Hawk
 						break;
 					case ConsoleID.DS:
 					case ConsoleID.DSi: