Remove OpenGLProvider and add project reference instead#4784
Open
Morilli wants to merge 1 commit into
Open
Conversation
YoshiRulz
added
the
Meta
YoshiRulz
reviewed
Jun 25, 2026
| using BizHawk.Common.CollectionExtensions; | ||
| using BizHawk.Common; | ||
| using BizHawk.Common.StringExtensions; | ||
| using CollectionExtensions = BizHawk.Common.CollectionExtensions.CollectionExtensions; |
Member
There was a problem hiding this comment.
Was this to avoid a name collision or something?
Collaborator
Author
There was a problem hiding this comment.
Yeah, BizHawk.Common.CollectionExtensions and System.Collections.Generic.CollectionExtensions.
Member
There was a problem hiding this comment.
Cause is an explicit (non-Source Generator) backport... BY MS https://github.com/dotnet/runtime/blob/c369fd627a26b606f36e6b3cbef6f25f3c00bbac/src/libraries/Microsoft.Extensions.DependencyModel/ref/Microsoft.Extensions.DependencyModel.cs#L221-L223 -_-
which we depend on via Silk.NET, hence no collisions before adding the dep on Bizware.Graphics.
edit: dotnet/runtime#129881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this makes more logical sense and makes it easier to add new classes and functions in the future, and will also help if we ever want to use hardware contexts for other renderers (vulkan, direct3d) and would have to do the same frontend graphics integration there. See also #4758 for an example where this helps implementation.
Check if completed: