Set TAStudio column sizes based on font size#4786
Open
SuuperW wants to merge 4 commits into
Open
Conversation
fixes TAStudio columns being the wrong size if loaded with a different Windows display scale factor than the project was created with
…loading of some old movies
fixes cursor column when rotating after loading an old movie allow `tastudio.addcolumn` to update column width (they might be 0 now, after loading an old movie); also text because why not
Contributor
Min value may be bigger due to negative sign, or if some insane arcade machine has negative range that's outright bigger than positive.
Scaling sounds better, but I'd need screenshots to know for sure. |
Contributor
Author
Contributor
|
Yeah scaling the arrow and the column is the way to go (also those icons for states/markers). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #3048 and other causes of column sizes being messed up.
All button columns with a single-character mnemonic use the same size, since that preserves the uniform look of the input roll for most buttons. Bigger columns are sized based on a measurement of text length (column text and max analog value length), including button columns.
I considered using
JsonIgnoreonRollColumn.VerticalWidthandHorizontalHeightsince we now resize on loading a movie, but decided against that due to Lua columns. Lua columns can be resized now by re-runningtastudio.addcolumthough. (column text can also be updated too now because why not)The cursor icon looks weird with large fonts. I don't know if it should just be centered, or if it should be scaled up to match the font size.
Warning: Running this branch will mess up your config file, so make a backup. All non-TAStudio
InputRollcontrols will be unusable on the master branch with the updated config file. (TheWidthproperty ofRollColumnobjects will be missing, resulting in it being 0 after deserialization when you go back to the master branch.)Check if completed: