Warn about auto calc spell vendors

Author: Assumeru

WARNINGS.md

@@ -113,6 +113,9 @@ This NPC has a class that is not suitable for use in this province.
 Spells have names that are visible to the player (either when buying them or when being affected by them.)
 These names imply a certain culture, meaning NPCs outside of Morrowind should not receive vanilla spells.
 
+### Is a spell vendor with auto calculated spells
+Auto calculated spell lists tend to be trash.
+
 ### Is not using unique head/hair
 This NPC should be using the asset designed for it.
 

crates/codegen/data/services.json

@@ -20,5 +20,14 @@
 		"Trader Service",
 		"T_Glb_TraderService",
 		"Wise Woman Service"
+	],
+	"spells": [
+		"Battlemage Service",
+		"T_Sky_Clever-Man",
+		"Healer Service",
+		"Mage Service",
+		"Nightblade Service",
+		"Priest Service",
+		"Sorcerer Service"
 	]
 }

crates/codegen/src/lib.rs

@@ -48,6 +48,11 @@ pub fn get_barter_classes(_: TokenStream) -> TokenStream {
     services_data::generate_barter_classes().into()
 }
 
+#[proc_macro]
+pub fn get_spell_vendor_classes(_: TokenStream) -> TokenStream {
+    services_data::generate_spell_vendor_classes().into()
+}
+
 #[proc_macro]
 pub fn get_spell_data(_: TokenStream) -> TokenStream {
     spells_data::generate().into()

crates/codegen/src/services_data.rs

@@ -5,13 +5,12 @@ use serde::Deserialize;
 #[derive(Deserialize)]
 pub struct Services {
     barter: Vec<String>,
+    spells: Vec<String>,
 }
 
-pub fn generate_barter_classes() -> TokenStream {
-    let data: Services = serde_json::from_str(include_str!("../data/services.json")).unwrap();
-
-    let len = data.barter.len();
-    let values = data.barter.iter().map(|id| id.to_ascii_lowercase());
+fn get_class_tokens(classes: Vec<String>) -> TokenStream {
+    let len = classes.len();
+    let values = classes.iter().map(|id| id.to_ascii_lowercase());
 
     quote! {
         {
@@ -24,3 +23,13 @@ pub fn generate_barter_classes() -> TokenStream {
     }
     .into_token_stream()
 }
+
+pub fn generate_barter_classes() -> TokenStream {
+    let data: Services = serde_json::from_str(include_str!("../data/services.json")).unwrap();
+    get_class_tokens(data.barter)
+}
+
+pub fn generate_spell_vendor_classes() -> TokenStream {
+    let data: Services = serde_json::from_str(include_str!("../data/services.json")).unwrap();
+    get_class_tokens(data.spells)
+}

src/validators/ids.rs

@@ -98,7 +98,8 @@ impl Handler<'_> for IdValidator {
                 println!("Found dirty {} {}", record.type_name(), record.editor_id());
             }
             TES3Object::GlobalVariable(_) => {
-                if context.mode != Mode::TD || !record.editor_id().eq_ignore_ascii_case("MWSE_BUILD")
+                if context.mode != Mode::TD
+                    || !record.editor_id().eq_ignore_ascii_case("MWSE_BUILD")
                 {
                     check_id(context, record);
                     self.check_known(record);

src/validators/services.rs

@@ -2,7 +2,7 @@ use std::collections::HashSet;
 
 use super::Context;
 use crate::{handlers::Handler, util::is_autocalc};
-use codegen::get_barter_classes;
+use codegen::{get_barter_classes, get_spell_vendor_classes};
 use tes3::esp::{AiData, ServiceFlags, TES3Object};
 
 const SERVICE_FLAGS_BARTERS_ANY: ServiceFlags = ServiceFlags::from_bits_truncate(
@@ -32,6 +32,7 @@ fn buy_magic_items(ai_data: &AiData) -> bool {
 
 pub struct ServiceValidator {
     barter_classes: HashSet<String>,
+    spell_vendor_classes: HashSet<String>,
 }
 
 impl Handler<'_> for ServiceValidator {
@@ -68,9 +69,14 @@ impl Handler<'_> for ServiceValidator {
                 let mut barter_menu = false;
                 if is_autocalc(npc) {
                     if !npc.class.is_empty() {
-                        barter_menu = self
-                            .barter_classes
-                            .contains(&npc.class.to_ascii_lowercase());
+                        let lower = npc.class.to_ascii_lowercase();
+                        barter_menu = self.barter_classes.contains(&lower);
+                        if self.spell_vendor_classes.contains(&lower) {
+                            println!(
+                                "Npc {} is a spell vendor with auto calculated spells",
+                                npc.id
+                            );
+                        }
                     }
                 } else {
                     barter_menu = barters(&npc.ai_data);
@@ -106,6 +112,7 @@ impl ServiceValidator {
     pub fn new() -> Self {
         Self {
             barter_classes: get_barter_classes!(),
+            spell_vendor_classes: get_spell_vendor_classes!(),
         }
     }
 }