reafactor: Vaildate Ids Add And Dto Apply #89

Author: oOccasio

src/main/java/sopt/comfit/report/job/AIReportJobService.java

@@ -8,6 +8,7 @@
 import sopt.comfit.global.exception.BaseException;
 import sopt.comfit.report.domain.AIReportJob;
 import sopt.comfit.report.domain.AIReportJobRepository;
+import sopt.comfit.report.dto.command.MatchExperienceCommandDto;
 import sopt.comfit.report.exception.AIReportErrorCode;
 
 @Service
@@ -18,14 +19,19 @@ public class AIReportJobService {
     private final StringRedisTemplate redisTemplate;
 
     @Transactional
-    public Long createJob(Long userId, Long companyId, Long experienceId, String jobDescription) {
+    public Long createJob(MatchExperienceCommandDto command) {
 
         Long queueSize = redisTemplate.opsForList().size(Constants.JOB_QUEUE_KEY);
 
         if (queueSize != null && queueSize > 200) {
             throw BaseException.type(AIReportErrorCode.JOB_QUEUE_FULL);
         }
-        AIReportJob job = AIReportJob.create(userId, companyId, experienceId, jobDescription);
+        AIReportJob job = AIReportJob.create(
+                command.userId(),
+                command.companyId(),
+                command.experienceId(),
+                command.jobDescription());
+
         reportJobRepository.save(job);
 
         redisTemplate.opsForList().leftPush(Constants.JOB_QUEUE_KEY, String.valueOf(job.getId()));

src/main/java/sopt/comfit/report/service/AIReportFacade.java

@@ -122,10 +122,8 @@ public AIReportResponseDto matchExperienceVirtualThread(MatchExperienceCommandDt
 
     public Long matchExperienceJob(MatchExperienceCommandDto command) {
 
-        return aiReportJobService.createJob(
-                    command.userId(),
-                    command.companyId(),
-                    command.experienceId(),
-                    command.jobDescription());
+        aiReportQueryService.validateIds(command);
+
+        return aiReportJobService.createJob(command);
     }
 }

src/main/java/sopt/comfit/report/service/AIReportQueryService.java

@@ -87,5 +87,15 @@ public PreparedDataDto prepareData(MatchExperienceCommandDto command) {
 
         return PreparedDataDto.of(company, experience, command.jobDescription(), issues);
     }
+
+    @Transactional(readOnly = true)
+    public void validateIds(MatchExperienceCommandDto command) {
+        if(!companyRepository.existsById(command.companyId())){
+            throw new BaseException(CompanyErrorCode.COMPANY_NOT_FOUND);
+        }
+        if(!experienceRepository.existsById(command.experienceId())){
+            throw new BaseException(ExperienceErrorCode.NOT_FOUND_EXPERIENCE);
+        }
+    }
 }