Commit c31ec7f
committed
Fix v_sa_p bug in gsw_specvol_second_derivatives
Fixed a bug in the calculation of v_sa_p in gsw_specvol_second_derivatives, in
which a division by the square root of offset-salinity was omitted. This bug
was detected by the MOM6 self-consistency testing, but it turns out that it was
previously corrected in the matlab version of the TEOS-10 code on Sept. 29,
2022, at github.com/TEOS-10/GSW-Matlab/commit/38c9635, and subsequently ported
to the C version of the code via github.com/TEOS-10/GSW-C/pull/53, on Oct. 3,
2022, but the Fortran version was somehow omitted. This commit makes the
analogous correction to the Fortran version of TEOS-10, and once this commit
is fully merged into the master branch of TEOS-10/GSW-Fortran, I expect that
github.com//issues/26 can be closed.
At this point we are not detecting any other self-inconsistencies in the
TEOS-10 Fortran code that we are using with MOM6. However, this bug might still
raise the question of whether there are other corrections that have been made to
the Matlab or C versions of TEOS-10 that have not propagated to the Fortran
version.1 parent 5d2271f commit c31ec7f
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
0 commit comments