Skip to content

Commit 754a058

Browse files
committed
Refactor action map to origin widget
1 parent 0de5ed7 commit 754a058

23 files changed

Lines changed: 42 additions & 146 deletions

android/src/org/testar/monkey/alayer/android/actions/AndroidActionClick.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public class AndroidActionClick extends TaggableBase implements Action {
4949

5050
public AndroidActionClick(State state, Widget w, String text, String accessibilityID, String className) {
5151
this.set(Tags.Role, ActionRoles.LeftClickAt);
52-
this.mapActionToWidget(w);
52+
this.mapOriginWidget(w);
5353
this.text = text;
5454
this.accessibilityID = accessibilityID;
5555
this.widget = w;

android/src/org/testar/monkey/alayer/android/actions/AndroidActionLongClick.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public class AndroidActionLongClick extends TaggableBase implements Action {
4848

4949
public AndroidActionLongClick(State state, Widget w, String accessibilityID) {
5050
this.set(Tags.Role, AndroidRoles.AndroidWidget);
51-
this.mapActionToWidget(w);
51+
this.mapOriginWidget(w);
5252
this.accessibilityId = accessibilityID;
5353
this.widget = w;
5454
this.widgetClass = w.get(AndroidTags.AndroidClassName);

android/src/org/testar/monkey/alayer/android/actions/AndroidActionPinch.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public class AndroidActionPinch extends TaggableBase implements Action {
4646

4747
public AndroidActionPinch(State state, Widget w, String accessibilityID, boolean zoomIn) {
4848
this.set(Tags.Role, AndroidRoles.AndroidWidget);
49-
this.mapActionToWidget(w);
49+
this.mapOriginWidget(w);
5050
this.accessibilityId = accessibilityID;
5151
this.widget = w;
5252
this.set(Tags.Desc, toShortString());

android/src/org/testar/monkey/alayer/android/actions/AndroidActionScroll.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public class AndroidActionScroll extends TaggableBase implements Action {
4545

4646
public AndroidActionScroll(State state, Widget w, String accessibilityID) {
4747
this.set(Tags.Role, AndroidRoles.AndroidWidget);
48-
this.mapActionToWidget(w);
48+
this.mapOriginWidget(w);
4949
this.accessibilityId = accessibilityID;
5050
this.widget = w;
5151
this.set(Tags.Desc, toShortString());

android/src/org/testar/monkey/alayer/android/actions/AndroidActionType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public class AndroidActionType extends TaggableBase implements Action {
5555

5656
public AndroidActionType(State state, Widget w, String type, String accessibilityId, String text, String className) {
5757
this.set(Tags.Role, ActionRoles.ClickTypeInto);
58-
this.mapActionToWidget(w);
58+
this.mapOriginWidget(w);
5959
this.type = type;
6060
this.accessibilityId = accessibilityId;
6161
this.widget = w;

android/src/org/testar/monkey/alayer/android/actions/AndroidBackAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public class AndroidBackAction extends TaggableBase implements Action {
4444
public AndroidBackAction(State state, Widget widget) {
4545
this.widget = widget;
4646
this.set(Tags.Role, AndroidRoles.AndroidWidget);
47-
this.mapActionToWidget(widget);
47+
this.mapOriginWidget(widget);
4848
this.set(Tags.Desc, toShortString());
4949
}
5050

android/src/org/testar/monkey/alayer/android/actions/AndroidSystemActionCall.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public class AndroidSystemActionCall extends TaggableBase implements Action {
4444
public AndroidSystemActionCall(State state, Widget widget) {
4545
this.widget = widget;
4646
this.set(Tags.Role, AndroidRoles.AndroidWidget);
47-
this.mapActionToWidget(widget);
47+
this.mapOriginWidget(widget);
4848
this.set(Tags.Desc, toShortString());
4949
}
5050

android/src/org/testar/monkey/alayer/android/actions/AndroidSystemActionOrientation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public class AndroidSystemActionOrientation extends TaggableBase implements Acti
4444
public AndroidSystemActionOrientation(State state, Widget widget) {
4545
this.widget = widget;
4646
this.set(Tags.Role, AndroidRoles.AndroidWidget);
47-
this.mapActionToWidget(widget);
47+
this.mapOriginWidget(widget);
4848
this.set(Tags.Desc, toShortString());
4949
}
5050

android/src/org/testar/monkey/alayer/android/actions/AndroidSystemActionText.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public class AndroidSystemActionText extends TaggableBase implements Action {
4444
public AndroidSystemActionText(State state, Widget widget) {
4545
this.widget = widget;
4646
this.set(Tags.Role, AndroidRoles.AndroidWidget);
47-
this.mapActionToWidget(widget);
47+
this.mapOriginWidget(widget);
4848
this.set(Tags.Desc, toShortString());
4949
}
5050

android/test/org/testar/monkey/alayer/android/actions/BuildAndroidActions.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ public void buildAndroidActionClick() {
4141
// Verify Action <-> Widget mapping
4242
Assert.notNull(androidClick.get(Tags.OriginWidget));
4343
Assert.isTrue(androidClick.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
44-
Assert.notNull(widget.get(Tags.ActionSet));
45-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
46-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidActionClick.class.getName()));
4744
}
4845

4946
@Test
@@ -53,9 +50,6 @@ public void buildAndroidActionLongClick() {
5350
// Verify Action <-> Widget mapping
5451
Assert.notNull(androidLongClick.get(Tags.OriginWidget));
5552
Assert.isTrue(androidLongClick.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
56-
Assert.notNull(widget.get(Tags.ActionSet));
57-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
58-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidActionLongClick.class.getName()));
5953
}
6054

6155
@Test
@@ -66,9 +60,6 @@ public void buildAndroidActionPinch() {
6660
// Verify Action <-> Widget mapping
6761
Assert.notNull(androidPinch.get(Tags.OriginWidget));
6862
Assert.isTrue(androidPinch.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
69-
Assert.notNull(widget.get(Tags.ActionSet));
70-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
71-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidActionPinch.class.getName()));
7263
}
7364

7465
@Test
@@ -78,9 +69,6 @@ public void buildAndroidActionScroll() {
7869
// Verify Action <-> Widget mapping
7970
Assert.notNull(androidScroll.get(Tags.OriginWidget));
8071
Assert.isTrue(androidScroll.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
81-
Assert.notNull(widget.get(Tags.ActionSet));
82-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
83-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidActionScroll.class.getName()));
8472
}
8573

8674
@Test
@@ -93,9 +81,6 @@ public void buildAndroidActionType() {
9381
// Verify Action <-> Widget mapping
9482
Assert.notNull(androidType.get(Tags.OriginWidget));
9583
Assert.isTrue(androidType.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
96-
Assert.notNull(widget.get(Tags.ActionSet));
97-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
98-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidActionType.class.getName()));
9984
}
10085

10186
@Test
@@ -104,9 +89,6 @@ public void buildAndroidBackAction() {
10489
// Verify Action <-> Widget mapping
10590
Assert.notNull(androidBack.get(Tags.OriginWidget));
10691
Assert.isTrue(androidBack.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
107-
Assert.notNull(widget.get(Tags.ActionSet));
108-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
109-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidBackAction.class.getName()));
11092
}
11193

11294
@Test
@@ -115,9 +97,6 @@ public void buildAndroidSystemActionCall() {
11597
// Verify Action <-> Widget mapping
11698
Assert.notNull(androidSystemCall.get(Tags.OriginWidget));
11799
Assert.isTrue(androidSystemCall.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
118-
Assert.notNull(widget.get(Tags.ActionSet));
119-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
120-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidSystemActionCall.class.getName()));
121100
}
122101

123102
@Test
@@ -126,9 +105,6 @@ public void buildAndroidSystemActionOrientation() {
126105
// Verify Action <-> Widget mapping
127106
Assert.notNull(androidSystemOrientation.get(Tags.OriginWidget));
128107
Assert.isTrue(androidSystemOrientation.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
129-
Assert.notNull(widget.get(Tags.ActionSet));
130-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
131-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidSystemActionOrientation.class.getName()));
132108
}
133109

134110
@Test
@@ -137,8 +113,5 @@ public void buildAndroidSystemActionText() {
137113
// Verify Action <-> Widget mapping
138114
Assert.notNull(androidSystemText.get(Tags.OriginWidget));
139115
Assert.isTrue(androidSystemText.get(Tags.OriginWidget).get(AndroidTags.AndroidXpath).equals(pathTest));
140-
Assert.notNull(widget.get(Tags.ActionSet));
141-
Assert.isTrue(widget.get(Tags.ActionSet).size() == 1);
142-
Assert.isTrue(widget.get(Tags.ActionSet).iterator().next().getClass().getName().equals(AndroidSystemActionText.class.getName()));
143116
}
144117
}

0 commit comments

Comments
 (0)