Skip to content

Commit cea7308

Browse files
committed
to_zarr() fix compression
1 parent e772a4f commit cea7308

6 files changed

Lines changed: 592 additions & 707 deletions

File tree

_dev/DEVELOPERS_NOTES.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,12 @@ src/mdio/schemas/v1/dataset_serializer.py
44

55
## Issues encountered
66

7-
1. Non-zero size of the serialized data files
8-
2. Not clear how to properly set `compressor`, `dimension_separator`, and `fill_value`
9-
* Should `fill_value` be a part f the model?
10-
3. For image_inline chunks[2] are somehow different?
7+
1. FIXED: Non-zero size of the serialized data files
8+
2. FIXED: Not clear how to properly set `compressor`, `dimension_separator`, and `fill_value`
9+
3. FIXED: For image_inline chunks[2] are somehow different?
10+
11+
4. `fill_value` for StructuredType is set to null, but "AAAAAAAAAAAAAAAA" is expected
12+
13+
## TO DO:
14+
* Add more unit tests for internal functions
15+
* Add a trest comparing expected and actual .zmetadata for the serialized dataset

0 commit comments

Comments
 (0)