Converter for MDIO dataset spec to Xarray Dataset and serialize it to Zarr#571
Merged
Conversation
…alidate* functions
BrianMichell
requested changes
Jul 13, 2025
tasansal
suggested changes
Jul 14, 2025
tasansal
left a comment
Contributor
There was a problem hiding this comment.
looks good! i put in lots of nitpick
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1 #571 +/- ##
==========================================
+ Coverage 84.32% 90.60% +6.28%
==========================================
Files 46 72 +26
Lines 2194 3948 +1754
Branches 305 278 -27
==========================================
+ Hits 1850 3577 +1727
- Misses 301 304 +3
- Partials 43 67 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tasansal
reviewed
Jul 15, 2025
BrianMichell
requested changes
Jul 16, 2025
This reverts commit 0447659.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outstanding work