Skip to content

Rename emsembleType to gatherType across templates #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tasansal merged 1 commit into from
Nov 6, 2025
Merged

Rename emsembleType to gatherType across templates #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mdio/builder/templates/seismic_2d_streamer_shot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def _name(self) -> str:
return "StreamerShotGathers2D"

def _load_dataset_attributes(self) -> dict[str, Any]:
return {"surveyType": "2D", "ensembleType": "common_source"}
return {"surveyType": "2D", "gatherType": "common_source"}

def _add_coordinates(self) -> None:
# Add dimension coordinates
Expand Down
2 changes: 1 addition & 1 deletion src/mdio/builder/templates/seismic_3d_streamer_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def _name(self) -> str:
return "StreamerFieldRecords3D"

def _load_dataset_attributes(self) -> dict[str, Any]:
return {"surveyDimensionality": "3D", "ensembleType": "common_source_by_gun"}
return {"surveyDimensionality": "3D", "gatherType": "common_source"}

def _add_coordinates(self) -> None:
# Add dimension coordinates
Expand Down
2 changes: 1 addition & 1 deletion src/mdio/builder/templates/seismic_3d_streamer_shot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def _name(self) -> str:
return "StreamerShotGathers3D"

def _load_dataset_attributes(self) -> dict[str, Any]:
return {"surveyType": "3D", "ensembleType": "common_source"}
return {"surveyType": "3D", "gatherType": "common_source"}

def _add_coordinates(self) -> None:
# Add dimension coordinates
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/v1/templates/test_seismic_2d_streamer_shot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def test_configuration(self) -> None:

# Verify prestack shot attributes
attrs = t._load_dataset_attributes()
assert attrs == {"surveyType": "2D", "ensembleType": "common_source"}
assert attrs == {"surveyType": "2D", "gatherType": "common_source"}

assert t.name == "StreamerShotGathers2D"

Expand All @@ -140,7 +140,7 @@ def test_build_dataset(self, structured_headers: StructuredType) -> None:

assert dataset.metadata.name == "North Sea 2D Shot Time"
assert dataset.metadata.attributes["surveyType"] == "2D"
assert dataset.metadata.attributes["ensembleType"] == "common_source"
assert dataset.metadata.attributes["gatherType"] == "common_source"

_validate_coordinates_headers_trace_mask(dataset, structured_headers, "time")

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/v1/templates/test_seismic_3d_streamer_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def test_configuration(self) -> None:

# Verify dataset attributes
attrs = t._load_dataset_attributes()
assert attrs == {"surveyDimensionality": "3D", "ensembleType": "common_source_by_gun"}
assert attrs == {"surveyDimensionality": "3D", "gatherType": "common_source"}
assert t.default_variable_name == "amplitude"

def test_build_dataset(self, structured_headers: StructuredType) -> None:
Expand All @@ -138,7 +138,7 @@ def test_build_dataset(self, structured_headers: StructuredType) -> None:

assert dataset.metadata.name == "Survey3D"
assert dataset.metadata.attributes["surveyDimensionality"] == "3D"
assert dataset.metadata.attributes["ensembleType"] == "common_source_by_gun"
assert dataset.metadata.attributes["gatherType"] == "common_source"

_validate_coordinates_headers_trace_mask(dataset, structured_headers, "time")

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/v1/templates/test_seismic_3d_streamer_shot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def test_configuration(self) -> None:

# Verify prestack shot attributes
attrs = t._load_dataset_attributes()
assert attrs == {"surveyType": "3D", "ensembleType": "common_source"}
assert attrs == {"surveyType": "3D", "gatherType": "common_source"}

assert t.name == "StreamerShotGathers3D"

Expand All @@ -157,7 +157,7 @@ def test_build_dataset(self, structured_headers: StructuredType) -> None:

assert dataset.metadata.name == "North Sea 3D Shot Time"
assert dataset.metadata.attributes["surveyType"] == "3D"
assert dataset.metadata.attributes["ensembleType"] == "common_source"
assert dataset.metadata.attributes["gatherType"] == "common_source"

_validate_coordinates_headers_trace_mask(dataset, structured_headers, "time")

Expand Down