Skip to content

Commit 08d53eb

Browse files
Merge pull request #270 from THEOplayer/bugfix/android-hashmap
Bugfix/android hashmap
2 parents 1a341df + 3ed2f69 commit 08d53eb

4 files changed

Lines changed: 25 additions & 27 deletions

File tree

.changeset/tiny-humans-repair.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@theoplayer/react-native-analytics-conviva': patch
3+
'@theoplayer/react-native-analytics-nielsen': patch
4+
---
5+
6+
Fixed an issue where the connector would output a `HashMap` conversion build error for Android platforms.

conviva/android/src/main/java/com/theoplayerconviva/ReactTHEOplayerConvivaModule.kt

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,10 @@ private const val PROP_GATEWAY_URL = "gatewayUrl"
1717
class ReactTHEOplayerConvivaModule(context: ReactApplicationContext) :
1818
ReactContextBaseJavaModule(context) {
1919

20-
private val viewResolver: ViewResolver
20+
private val viewResolver: ViewResolver = ViewResolver(context)
2121

2222
private var convivaConnectors: HashMap<Int, ConvivaConnector> = HashMap()
2323

24-
init {
25-
viewResolver = ViewResolver(context)
26-
}
27-
2824
override fun getName(): String {
2925
return TAG
3026
}
@@ -48,11 +44,11 @@ class ReactTHEOplayerConvivaModule(context: ReactApplicationContext) :
4844
ConvivaConnector(
4945
reactApplicationContext,
5046
player,
51-
convivaMetadata.toHashMap(),
47+
convivaMetadata.toHashMap() as Map<String, Any>,
5248
config,
5349
view.broadcast as EventDispatcher<AdEvent<*>>
5450
)
55-
convivaConnectors[tag]?.setContentInfo(convivaMetadata.toHashMap())
51+
convivaConnectors[tag]?.setContentInfo(convivaMetadata.toHashMap() as Map<String, Any>)
5652
}
5753
}
5854
}
@@ -61,7 +57,7 @@ class ReactTHEOplayerConvivaModule(context: ReactApplicationContext) :
6157
@ReactMethod
6258
fun stopAndStartNewSession(tag: Int, convivaMetadata: ReadableMap) {
6359
viewResolver.resolveViewByTag(tag) { _: ReactTHEOplayerView? ->
64-
convivaConnectors[tag]?.stopAndStartNewSession(convivaMetadata.toHashMap())
60+
convivaConnectors[tag]?.stopAndStartNewSession(convivaMetadata.toHashMap() as Map<String, Any>)
6561
}
6662
}
6763

@@ -75,21 +71,21 @@ class ReactTHEOplayerConvivaModule(context: ReactApplicationContext) :
7571
@ReactMethod
7672
fun reportPlaybackEvent(tag: Int, eventName: String, eventDetail: ReadableMap) {
7773
viewResolver.resolveViewByTag(tag) { _: ReactTHEOplayerView? ->
78-
convivaConnectors[tag]?.reportPlaybackEvent(eventName, eventDetail.toHashMap())
74+
convivaConnectors[tag]?.reportPlaybackEvent(eventName, eventDetail.toHashMap() as Map<String, Any>)
7975
}
8076
}
8177

8278
@ReactMethod
8379
fun setContentInfo(tag: Int, convivaMetadata: ReadableMap) {
8480
viewResolver.resolveViewByTag(tag) { _: ReactTHEOplayerView? ->
85-
convivaConnectors[tag]?.setContentInfo(convivaMetadata.toHashMap())
81+
convivaConnectors[tag]?.setContentInfo(convivaMetadata.toHashMap() as Map<String, Any>)
8682
}
8783
}
8884

8985
@ReactMethod
9086
fun setAdInfo(tag: Int, convivaMetadata: ReadableMap) {
9187
viewResolver.resolveViewByTag(tag) { _: ReactTHEOplayerView? ->
92-
convivaConnectors[tag]?.setAdInfo(convivaMetadata.toHashMap())
88+
convivaConnectors[tag]?.setAdInfo(convivaMetadata.toHashMap() as Map<String, Any>)
9389
}
9490
}
9591

nielsen/android/src/main/java/com/theoplayernielsen/ReactTHEOplayerNielsenModule.kt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,10 @@ private const val TAG = "NielsenModule"
1212
class ReactTHEOplayerNielsenModule(context: ReactApplicationContext) :
1313
ReactContextBaseJavaModule(context) {
1414

15-
private val viewResolver: ViewResolver
15+
private val viewResolver: ViewResolver = ViewResolver(context)
1616

1717
private var nielsenConnectors: HashMap<Int, NielsenConnector> = HashMap()
1818

19-
init {
20-
viewResolver = ViewResolver(context)
21-
}
22-
2319
override fun getName(): String {
2420
return TAG
2521
}
@@ -39,7 +35,7 @@ class ReactTHEOplayerNielsenModule(context: ReactApplicationContext) :
3935

4036
@ReactMethod
4137
fun updateMetadata(tag: Int, metadata: ReadableMap) {
42-
nielsenConnectors[tag]?.updateMetadata(metadata.toHashMap())
38+
nielsenConnectors[tag]?.updateMetadata(metadata.toHashMap() as HashMap<String, Any>)
4339
}
4440

4541
@ReactMethod

package-lock.json

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)