Add externalId in TheoLiveDistribution#853
Conversation
|
Thanks for this contribution, @OlegRyz! Great to see the THEOlive distribution API getting richer. 🎉 A distribution arrives, bearing its name, Review SummaryCode AnalysisThe change adds an optional TypeScript API (
Android (
iOS/tvOS (
Web platform:
Cross-platform consistency: All three platforms (Android, iOS, Web) are covered. The pattern is consistent across each.
|
| Check | Status | Error |
|---|---|---|
| Build for API Level 36 | ❌ | THEOliveEventAdapter.kt:72:49 Cannot infer type for this parameter — externalId does not exist on DistributionAPI in Android SDK [11.5.0, 12.0.0) |
| Build for iOS (Xcode 26.2.0) | ❌ | value of type 'any DistributionAPI' has no member 'externalId' — externalId does not exist on DistributionAPI in iOS SDK ~> 11.4 |
| Build for tvOS (Xcode 26.2.0) | ❌ | Same iOS SDK error as above |
| lint | ✅ | |
| build (TS) | ✅ |
Note: The tvOS check has a preexisting e2e flake on develop (exit code 42), but on this PR the tvOS failure is a new build error (
no member 'externalId').
Root cause: The current THEOplayer native SDKs (Android [11.5.0, 12.0.0), iOS ~> 11.4) do not yet expose externalId on the DistributionAPI type. This PR will only compile once a native SDK version including this property is released.
⚠️ Caution: This PR requires a newer THEOplayer native player SDK version (both Android and iOS) that includes theexternalIdproperty onDistributionAPI. The current SDK version constraints inbuild.gradleand the.podspecdo not resolve to a version that has this API. This PR should be merged only after the native SDKs are updated, or the version constraints should be bumped to the minimum version that includes this property.
📋 Missing CHANGELOG Entry
No CHANGELOG entry was added. Here's a suggested entry that can be committed directly:
## [Unreleased]
### Added
- Added `externalId` to `TheoLiveDistribution`, bridged from native Android and iOS SDKs.Summary
The code itself is clean and follows existing patterns well. The only blocker is native SDK compatibility — once the THEOplayer Android and iOS SDKs ship with externalId on DistributionAPI, this PR is ready to go (after adding the CHANGELOG entry and bumping SDK version constraints if needed).
Co-Authored-By: tom.vanlaerhoven <tom.vanlaerhoven@dolby.com>
Caution
Needs native Player SDK v11.6.0 for Android and iOS.