Skip to content

Commit de7165d

Browse files
authored
Merge pull request #147 from Nico1eKim/refactor/#144-qa4
[REFACTOR] 4차 QA 진행
2 parents 8aedb16 + 3574a70 commit de7165d

25 files changed

Lines changed: 116 additions & 444 deletions

File tree

app/src/main/AndroidManifest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
<uses-permission android:name="android.permission.INTERNET" />
66
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
7+
<uses-permission android:name="com.google.android.gms.permission.AD_ID"
8+
tools:ignore="AdvertisingIdPolicy" />
79

810
<application
911
android:name=".ThipApplication"

app/src/main/java/com/texthip/thip/MainActivity.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import androidx.activity.ComponentActivity
77
import androidx.activity.compose.setContent
88
import androidx.activity.enableEdgeToEdge
99
import androidx.activity.result.contract.ActivityResultContracts
10+
import androidx.compose.animation.EnterTransition
11+
import androidx.compose.animation.ExitTransition
1012
import androidx.compose.runtime.Composable
1113
import androidx.compose.runtime.DisposableEffect
1214
import androidx.compose.runtime.LaunchedEffect
@@ -177,7 +179,11 @@ fun RootNavHost(
177179

178180
NavHost(
179181
navController = navController,
180-
startDestination = CommonRoutes.Splash
182+
startDestination = CommonRoutes.Splash,
183+
enterTransition = { EnterTransition.None },
184+
exitTransition = { ExitTransition.None },
185+
popEnterTransition = { EnterTransition.None },
186+
popExitTransition = { ExitTransition.None }
181187
) {
182188
// --- 인증 관련 화면들 ---
183189
authNavigation(

app/src/main/java/com/texthip/thip/ui/common/cards/CardItemRoom.kt

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ fun CardItemRoom(
4545
imageUrl: String? = null,
4646
hasBorder: Boolean = false,
4747
isSecret: Boolean? = null,
48+
isExpired: Boolean = false,
4849
onClick: () -> Unit = {}
4950
) {
5051
Card(
@@ -161,19 +162,21 @@ fun CardItemRoom(
161162
}
162163
}
163164
}
164-
endDate?.let {
165-
Spacer(modifier = Modifier.height(5.dp))
165+
if (!isExpired) {
166+
endDate?.let {
167+
Spacer(modifier = Modifier.height(5.dp))
166168

167-
Text(
168-
text = endDate
169-
+ if (isRecruiting) stringResource(
170-
R.string.card_item_end
171-
) else stringResource(R.string.card_item_finish),
169+
Text(
170+
text = endDate
171+
+ if (isRecruiting) stringResource(
172+
R.string.card_item_end
173+
) else stringResource(R.string.card_item_finish),
172174

173-
color = if (isRecruiting) colors.Red else colors.Grey01,
174-
style = typography.menu_sb600_s12_h20,
175-
maxLines = 1
176-
)
175+
color = if (isRecruiting) colors.Red else colors.Grey01,
176+
style = typography.menu_sb600_s12_h20,
177+
maxLines = 1
178+
)
179+
}
177180
}
178181
}
179182
}

app/src/main/java/com/texthip/thip/ui/common/topappbar/LogoTopAppBar.kt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import com.texthip.thip.ui.theme.ThipTheme.colors
2424
@Composable
2525
fun LogoTopAppBar(
2626
modifier: Modifier = Modifier,
27-
leftIcon: Painter,
27+
leftIcon: Painter? = null,
2828
hasNotification: Boolean,
2929
onLeftClick: () -> Unit = {},
3030
onRightClick: () -> Unit = {}
@@ -56,12 +56,14 @@ fun LogoTopAppBar(
5656
horizontalArrangement = Arrangement.spacedBy(20.dp),
5757
verticalAlignment = Alignment.CenterVertically
5858
) {
59-
Icon(
60-
painter = leftIcon,
61-
contentDescription = "Left Icon",
62-
tint = Color.Unspecified,
63-
modifier = Modifier.clickable { onLeftClick() }
64-
)
59+
leftIcon?.let {
60+
Icon(
61+
painter = it,
62+
contentDescription = "Left Icon",
63+
tint = Color.Unspecified,
64+
modifier = Modifier.clickable { onLeftClick() }
65+
)
66+
}
6567
Icon(
6668
painter = rightIcon,
6769
contentDescription = "Right Icon",

app/src/main/java/com/texthip/thip/ui/feed/component/FeedSubscribelistBar.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import com.texthip.thip.ui.theme.ThipTheme.typography
3636
@Composable
3737
fun FeedSubscribeBarlist(
3838
modifier: Modifier = Modifier,
39+
followerNum: Int = 0,
3940
followerProfileImageUrls: List<String>,
4041
onClick: () -> Unit
4142
) {
@@ -59,7 +60,8 @@ fun FeedSubscribeBarlist(
5960
color = colors.White
6061
)
6162
) {
62-
append(stringResource(R.string.thip_num, followerProfileImageUrls.size)) }
63+
append(stringResource(R.string.thip_num, followerNum))
64+
}
6365
withStyle(
6466
style = SpanStyle(
6567
color = colors.Grey

app/src/main/java/com/texthip/thip/ui/feed/screen/FeedMyScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ fun FeedMyContent(
121121
Spacer(modifier = Modifier.height(16.dp))
122122
FeedSubscribeBarlist(
123123
modifier = Modifier.padding(horizontal = 20.dp),
124-
followerProfileImageUrls = userInfo.latestFollowerProfileImageUrls
125-
?: emptyList(),
124+
followerNum = userInfo.followerCount,
125+
followerProfileImageUrls = userInfo.latestFollowerProfileImageUrls,
126126
onClick = { onNavigateToSubscriptionList(userInfo.creatorId) }
127127
)
128128
Spacer(modifier = Modifier.height(40.dp))

app/src/main/java/com/texthip/thip/ui/feed/screen/FeedOthersScreen.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ fun FeedOthersContent(
133133
Spacer(modifier = Modifier.height(16.dp))
134134
FeedSubscribeBarlist(
135135
modifier = Modifier.padding(horizontal = 20.dp),
136+
followerNum = userInfo.followerCount,
136137
followerProfileImageUrls = userInfo.latestFollowerProfileImageUrls,
137138
onClick = { onNavigateToSubscriptionList(userInfo.creatorId) }
138139
)

app/src/main/java/com/texthip/thip/ui/group/done/mock/MyRoomCardData.kt

Lines changed: 0 additions & 39 deletions
This file was deleted.

app/src/main/java/com/texthip/thip/ui/group/done/screen/GroupDoneScreen.kt

Lines changed: 0 additions & 199 deletions
This file was deleted.

app/src/main/java/com/texthip/thip/ui/group/done/viewmodel/GroupDoneUiState.kt

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)