Skip to content

Commit f90a225

Browse files
committed
[refactor]: PR에 맞게 기타 코드 수정 (#44)
1 parent d98df3e commit f90a225

8 files changed

Lines changed: 26 additions & 32 deletions

File tree

app/src/main/java/com/texthip/thip/ui/common/cards/CardItemRoom.kt

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ fun CardItemRoom(
4646
hasBorder: Boolean = false,
4747
onClick: () -> Unit = {}
4848
) {
49-
val paddingValues = if (endDate == null) 27.5.dp else 16.dp
50-
5149
Card(
5250
modifier = modifier
5351
.fillMaxWidth()
@@ -93,10 +91,11 @@ fun CardItemRoom(
9391
Spacer(modifier = Modifier.width(16.dp))
9492

9593
Column(
96-
modifier = Modifier.fillMaxWidth()
94+
modifier = Modifier
95+
.fillMaxWidth()
96+
.height(107.dp), // 이미지와 높이 맞추면 더 정확
97+
verticalArrangement = Arrangement.Center // 여기!
9798
) {
98-
99-
Spacer(modifier = Modifier.height(paddingValues))
10099
Text(
101100
text = title,
102101
color = colors.White,
@@ -143,7 +142,7 @@ fun CardItemRoom(
143142
) {
144143
Text(
145144
text = stringResource(
146-
R.string.card_item_participant,
145+
R.string.card_item_participating_count,
147146
participants
148147
),
149148
style = typography.menu_sb600_s12,

app/src/main/java/com/texthip/thip/ui/common/cards/CardItemRoomSmall.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ fun CardItemRoomSmall(
4848
val cardModifier = if (isWide) {
4949
modifier
5050
.fillMaxWidth()
51-
.height(104.dp)
5251
} else {
5352
modifier
54-
.size(width = 232.dp, height = 104.dp)
53+
.width(232.dp)
5554
}
5655
val bgColor = if (isWide) colors.Black else colors.DarkGrey50
5756

5857
Card(
5958
modifier = cardModifier
59+
.height(104.dp)
6060
.clickable { onClick() },
6161
colors = CardDefaults.cardColors(
6262
containerColor = bgColor

app/src/main/java/com/texthip/thip/ui/common/forms/SearchBookTextField.kt

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,25 @@ package com.texthip.thip.ui.common.forms
22

33
import androidx.compose.foundation.background
44
import androidx.compose.foundation.clickable
5-
import androidx.compose.foundation.layout.*
5+
import androidx.compose.foundation.layout.Box
6+
import androidx.compose.foundation.layout.Row
7+
import androidx.compose.foundation.layout.Spacer
8+
import androidx.compose.foundation.layout.fillMaxSize
9+
import androidx.compose.foundation.layout.fillMaxWidth
10+
import androidx.compose.foundation.layout.height
11+
import androidx.compose.foundation.layout.padding
12+
import androidx.compose.foundation.layout.width
613
import androidx.compose.foundation.shape.RoundedCornerShape
714
import androidx.compose.foundation.text.BasicTextField
815
import androidx.compose.foundation.text.KeyboardActions
916
import androidx.compose.foundation.text.KeyboardOptions
1017
import androidx.compose.material3.Icon
1118
import androidx.compose.material3.Text
12-
import androidx.compose.runtime.*
19+
import androidx.compose.runtime.Composable
20+
import androidx.compose.runtime.getValue
21+
import androidx.compose.runtime.mutableStateOf
1322
import androidx.compose.runtime.saveable.rememberSaveable
23+
import androidx.compose.runtime.setValue
1424
import androidx.compose.ui.Alignment
1525
import androidx.compose.ui.Modifier
1626
import androidx.compose.ui.draw.clip
@@ -20,7 +30,6 @@ import androidx.compose.ui.res.painterResource
2030
import androidx.compose.ui.text.input.ImeAction
2131
import androidx.compose.ui.tooling.preview.Preview
2232
import androidx.compose.ui.unit.dp
23-
import androidx.compose.ui.unit.sp
2433
import com.texthip.thip.R
2534
import com.texthip.thip.ui.theme.ThipTheme
2635
import com.texthip.thip.ui.theme.ThipTheme.colors
@@ -35,19 +44,16 @@ fun SearchBookTextField(
3544
onSearch: (String) -> Unit = {}
3645
) {
3746
val myStyle = typography.menu_r400_s14_h24.copy(
38-
fontSize = 14.sp,
39-
lineHeight = 16.sp,
4047
color = colors.White
4148
)
4249
val shape = RoundedCornerShape(12.dp)
43-
val backgroundColor = colors.DarkGrey02
4450

4551
Box(
4652
modifier = modifier
4753
.fillMaxWidth()
4854
.height(40.dp)
4955
.clip(shape)
50-
.background(backgroundColor),
56+
.background(colors.DarkGrey02),
5157
contentAlignment = Alignment.CenterStart
5258
) {
5359
Row(

app/src/main/java/com/texthip/thip/ui/common/forms/SingleDigitTextBox.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.texthip.thip.ui.common.forms
22

3+
import android.view.KeyEvent
34
import androidx.compose.foundation.background
45
import androidx.compose.foundation.border
56
import androidx.compose.foundation.layout.Box
@@ -17,6 +18,7 @@ import androidx.compose.ui.Alignment
1718
import androidx.compose.ui.Modifier
1819
import androidx.compose.ui.graphics.Color
1920
import androidx.compose.ui.graphics.SolidColor
21+
import androidx.compose.ui.input.key.KeyEventType
2022
import androidx.compose.ui.input.key.onKeyEvent
2123
import androidx.compose.ui.input.key.type
2224
import androidx.compose.ui.text.input.KeyboardType
@@ -63,8 +65,8 @@ fun SingleDigitBox(
6365
.background(containerColor, RoundedCornerShape(12.dp))
6466
.border(1.dp, borderColor, RoundedCornerShape(12.dp))
6567
.onKeyEvent { keyEvent ->
66-
if (keyEvent.nativeKeyEvent.keyCode == android.view.KeyEvent.KEYCODE_DEL &&
67-
keyEvent.type == androidx.compose.ui.input.key.KeyEventType.KeyDown
68+
if (keyEvent.nativeKeyEvent.keyCode == KeyEvent.KEYCODE_DEL &&
69+
keyEvent.type == KeyEventType.KeyDown
6870
) {
6971
if (value.isEmpty()) {
7072
onBackspace?.invoke()

app/src/main/java/com/texthip/thip/ui/group/myroom/component/GroupDeadlineRoomSection.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ fun GroupRoomDeadlineSection(
103103
)
104104
Spacer(Modifier.height(20.dp))
105105

106-
val cards = section.rooms.filter { it.genreIndex == selectedGenre }.take(4)
106+
val cards = section.rooms.filter { it.genreIndex == selectedGenre }
107107
Column(
108108
verticalArrangement = Arrangement.spacedBy(20.dp),
109109
modifier = Modifier

app/src/main/java/com/texthip/thip/ui/group/myroom/component/GroupEmptyCard.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,21 @@
11
package com.texthip.thip.ui.group.myroom.component
22

3-
import android.R.attr.data
4-
import android.R.attr.top
5-
import androidx.compose.foundation.Image
63
import androidx.compose.foundation.background
74
import androidx.compose.foundation.clickable
85
import androidx.compose.foundation.layout.Arrangement
96
import androidx.compose.foundation.layout.Box
107
import androidx.compose.foundation.layout.Column
11-
import androidx.compose.foundation.layout.Row
128
import androidx.compose.foundation.layout.Spacer
13-
import androidx.compose.foundation.layout.fillMaxHeight
149
import androidx.compose.foundation.layout.fillMaxSize
1510
import androidx.compose.foundation.layout.fillMaxWidth
1611
import androidx.compose.foundation.layout.height
1712
import androidx.compose.foundation.layout.padding
18-
import androidx.compose.foundation.layout.size
19-
import androidx.compose.foundation.layout.width
2013
import androidx.compose.foundation.shape.RoundedCornerShape
2114
import androidx.compose.material3.Card
2215
import androidx.compose.material3.CardDefaults
2316
import androidx.compose.material3.Icon
24-
import androidx.compose.material3.LinearProgressIndicator
2517
import androidx.compose.material3.Text
2618
import androidx.compose.runtime.Composable
27-
import androidx.compose.runtime.getValue
28-
import androidx.compose.runtime.mutableFloatStateOf
29-
import androidx.compose.runtime.remember
3019
import androidx.compose.ui.Alignment
3120
import androidx.compose.ui.Modifier
3221
import androidx.compose.ui.geometry.Offset
@@ -37,7 +26,6 @@ import androidx.compose.ui.res.stringResource
3726
import androidx.compose.ui.tooling.preview.Preview
3827
import androidx.compose.ui.unit.dp
3928
import com.texthip.thip.R
40-
import com.texthip.thip.ui.group.myroom.mock.GroupCardData
4129
import com.texthip.thip.ui.theme.ThipTheme
4230
import com.texthip.thip.ui.theme.ThipTheme.colors
4331
import com.texthip.thip.ui.theme.ThipTheme.typography

app/src/main/java/com/texthip/thip/ui/group/screen/GroupDoneScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ fun GroupDoneScreen(
3636

3737
Column(
3838
Modifier
39-
.background(colors.Black)
4039
.fillMaxSize()
4140
) {
4241
DefaultTopAppBar(

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
<string name="card_item_end_date">"%1$s일 뒤 "</string>
4343
<string name="card_item_end">모집 마감</string>
4444
<string name="card_item_finish">종료</string>
45-
<string name="card_item_participant">%1$s명</string>
45+
<string name="card_item_participating_count">%1$s명</string>
4646
<string name="card_item_participant_string">참여</string>
4747
<string name="card_item_participant_count">%1$s</string>
4848
<string name="card_item_participant_count_max"> / %1$s명</string>

0 commit comments

Comments
 (0)