fix: handle empty colocated weight buckets#2134
Merged
zhuzilin merged 1 commit intoJun 29, 2026
Merged
Conversation
This was referenced Jun 26, 2026
Contributor
|
nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes colocated raw weight sync when a tensor-parallel rank has no HF tensors for a chunk.
Today
_send_to_colocated_enginestill tries to build aFlattenedTensorBucket(named_tensors=[])for the empty local chunk. That path raises before the rank can participate in the Gloogather_object, so a valid uneven bucket layout can crash raw weight updates.The fix keeps the collective behavior unchanged:
gather_objectWhy this matters
This can show up when HF tensor chunks are uneven across TP ranks, especially with PP/EP/MoE layouts where some ranks legitimately have no tensors for a given chunk. The update path should treat that as an empty contribution, not as an invalid bucket construction.
Validation
uv run --with pytest python tests/test_empty_colocated_weight_bucket.pyuv run --with pytest python -m pytest tests/test_empty_colocated_weight_bucket.py -quv run --with ruff ruff check slime/backends/megatron_utils/update_weight/update_weight_from_tensor.py tests/test_empty_colocated_weight_bucket.pyuv run --with black black --check slime/backends/megatron_utils/update_weight/update_weight_from_tensor.py tests/test_empty_colocated_weight_bucket.py