Skip to content

Commit c4594d0

Browse files
committed
_opt suffix
1 parent 6b7c9b3 commit c4594d0

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

prime_backup/action/delete_chunk_group_action.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def __collect_chunk_group_ids_to_delete(self, session: DbSession) -> List[int]:
5353
self_chunk_group_hashes_set = set(self.chunk_group_hashes)
5454
all_to_delete_chunk_groups: Dict[int, None] = {} # ordered set
5555

56-
chunk_groups_by_id: Dict[int, Optional[schema.ChunkGroup]] = session.get_chunk_groups_by_ids(self.chunk_group_ids)
56+
chunk_groups_by_id: Dict[int, Optional[schema.ChunkGroup]] = session.get_chunk_groups_by_ids_opt(self.chunk_group_ids)
5757
for chunk_group_id, chunk_group in chunk_groups_by_id.items():
5858
if chunk_group is None:
5959
if self.raise_if_not_found:
@@ -65,7 +65,7 @@ def __collect_chunk_group_ids_to_delete(self, session: DbSession) -> List[int]:
6565
raise AssertionError('got unexpected chunk group id {!r}, should be in {}'.format(chunk_group_id, self_chunk_group_ids_set))
6666
all_to_delete_chunk_groups[chunk_group.id] = None
6767

68-
chunk_groups_by_hash: Dict[str, Optional[schema.ChunkGroup]] = session.get_chunk_groups_by_hashes(self.chunk_group_hashes)
68+
chunk_groups_by_hash: Dict[str, Optional[schema.ChunkGroup]] = session.get_chunk_groups_by_hashes_opt(self.chunk_group_hashes)
6969
for chunk_group_hash, chunk_group in chunk_groups_by_hash.items():
7070
if chunk_group is None:
7171
if self.raise_if_not_found:

prime_backup/action/migrate_compress_method_action.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ def __update_chunk_group_and_blobs_for_chunk_changes(self, session: DbSession):
186186
return
187187

188188
chunk_group_id_list = list(self.__affected_chunk_groups_ids)
189-
chunk_groups = session.get_chunk_groups_by_ids(chunk_group_id_list)
189+
chunk_groups = session.get_chunk_groups_by_ids_opt(chunk_group_id_list)
190190
for chunk_group_id, chunk_group in chunk_groups.items():
191191
if chunk_group is None:
192192
raise AssertionError('Chunk group with id {!r} does not exists'.format(chunk_group_id))

prime_backup/action/validate_blobs_action.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def blob_binding_key_getter(b_: schema.BlobChunkGroupBinding):
141141
return b_.chunk_group_offset
142142

143143
bd_lst.sort(key=blob_binding_key_getter)
144-
all_chunk_groups_by_id = session.get_chunk_groups_by_ids([bd.chunk_group_id for bd in all_bindings])
144+
all_chunk_groups_by_id = session.get_chunk_groups_by_ids_opt([bd.chunk_group_id for bd in all_bindings])
145145
all_chunks_by_chunk_group_id = session.get_chunk_group_chunks_batch([bd.chunk_group_id for bd in all_bindings])
146146

147147
def validate_one_blob(blob: BlobInfo):

prime_backup/db/session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -712,7 +712,7 @@ def get_chunk_group_by_hash(self, h: str) -> schema.ChunkGroup:
712712
raise ChunkGroupHashNotFound(h)
713713
return chunk_group
714714

715-
def get_chunk_groups_by_ids(self, chunk_group_ids: List[int]) -> Dict[int, Optional[schema.ChunkGroup]]:
715+
def get_chunk_groups_by_ids_opt(self, chunk_group_ids: List[int]) -> Dict[int, Optional[schema.ChunkGroup]]:
716716
"""
717717
:return: a dict, id -> optional chunk group. All given ids are in the dict
718718
"""
@@ -723,7 +723,7 @@ def get_chunk_groups_by_ids(self, chunk_group_ids: List[int]) -> Dict[int, Optio
723723
result[chunk_group.id] = chunk_group
724724
return result
725725

726-
def get_chunk_groups_by_hashes(self, hashes: List[str]) -> Dict[str, Optional[schema.ChunkGroup]]:
726+
def get_chunk_groups_by_hashes_opt(self, hashes: List[str]) -> Dict[str, Optional[schema.ChunkGroup]]:
727727
"""
728728
:return: a dict, hash -> optional chunk group. All given hashes are in the dict
729729
"""

0 commit comments

Comments
 (0)