Skip to content

Commit ffcb9f2

Browse files
committed
show affected backup ids for fileset validation
1 parent 1412ba7 commit ffcb9f2

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

prime_backup/action/validate_filesets_action.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ class ValidateFilesetsResult:
2222
total: int = 0
2323
validated: int = 0
2424
bad_filesets: Dict[int, BadFilesetItem] = dataclasses.field(default_factory=dict)
25+
affected_backup_ids: List[int] = dataclasses.field(default_factory=list)
2526

2627
@property
2728
def ok(self) -> int:
@@ -145,6 +146,8 @@ def run(self) -> ValidateFilesetsResult:
145146
self.logger.info('Validating {} / {} fileset objects'.format(cnt, result.total))
146147
self.__validate(session, result, [FilesetInfo.of(fileset) for fileset in filesets])
147148

149+
result.affected_backup_ids = session.get_backup_ids_by_fileset_ids(list(result.bad_filesets.keys()))
150+
148151
self.logger.info('Fileset validation done: total {}, validated {}, ok {}, bad {}'.format(
149152
result.total, result.validated, result.ok, len(result.bad_filesets),
150153
))

prime_backup/mcdr/task/db/validate_db_task.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def show(what: str, lst: List[BadBlobItem]):
8383
for file in result.affected_file_samples:
8484
vlogger.info('- {!r}'.format(file))
8585
vlogger.info('Affected backup / total backups: {} / {}'.format(len(result.affected_backup_ids), counts.backup_count))
86-
vlogger.info('Affected backup IDs: {}'.format(result.affected_backup_ids))
86+
vlogger.info('Affected backup IDs (bad blobs): {}'.format(result.affected_backup_ids))
8787

8888
sampled_backup_ids = result.affected_backup_ids[:100]
8989
sampled_fileset_ids = result.affected_fileset_ids[:100]
@@ -143,6 +143,8 @@ def __validate_filesets(self, vlogger: logging.Logger):
143143
vlogger.info(text.to_plain_text())
144144
self.reply(text)
145145

146+
vlogger.info('Affected backup IDs (bad filesets): {}'.format(result.affected_backup_ids))
147+
146148
def __validate_backups(self, vlogger: logging.Logger):
147149
result = self.run_action(ValidateBackupsAction())
148150
vlogger.info('Validate backups result: total={} validated={} ok={}'.format(result.total, result.validated, result.ok))

0 commit comments

Comments
 (0)