Skip to content

Commit 75512aa

Browse files
committed
Remove obsolete third-party cleanup task
This task caused build failures on Windows. After some investigation, I concluded that it is no longer needed - the existing `dependencies.exclude()` make this transformation an identity operation. Also, there is test coverage for missing `exclude` statements (see `:checkArtifact`), so we can't accidentally publish a release where the problem that this code meant to address is present. Signed-off-by: Dr. Jonathan Schulz <jonathan.schulz@tngtech.com>
1 parent 1bc10ea commit 75512aa

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

archunit-junit/build.gradle

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -59,27 +59,8 @@ shadowJar {
5959
}
6060
}
6161

62-
def addCleanThirdPartyTask = {
63-
// These files are already relocated into archunit.jar, so they're transitively available
64-
tasks.create(name: 'removeDuplicateThirdParty', type: Jar, dependsOn: shadowJar) {
65-
exclude "${thirdPartyRelocationPackage.replace('.', '/')}/**"
66-
67-
File tempPath = tempJar(jar.archiveFile.get().getAsFile())
68-
File jarPath = shadowJar.archiveFile.get().getAsFile()
69-
inputs.file(jarPath)
70-
from zipTree(jarPath)
71-
archiveFileName = tempPath.name
72-
73-
doLast {
74-
assert jarPath.delete()
75-
assert tempPath.renameTo(jarPath)
76-
}
77-
}
78-
finishArchive.dependsOn removeDuplicateThirdParty
79-
}
8062
ext.configureJUnitArchive = { configureDependencies ->
8163
return {
82-
delegate.with addCleanThirdPartyTask
8364
compileJava.dependsOn project(':archunit-junit').finishArchive
8465

8566
publishing{
@@ -94,6 +75,4 @@ ext.configureJUnitArchive = { configureDependencies ->
9475
}
9576
}
9677

97-
this.with addCleanThirdPartyTask
98-
9978
javadoc.enabled = false

0 commit comments

Comments
 (0)