Update Maven examples (and Gradle wrapper)#1450
Open
hankem wants to merge 4 commits into
Open
Conversation
hankem
force-pushed
the
update-Maven-examples
branch
from
16def1b to
c61e9e0
Compare
Signed-off-by: Manfred Hanke <manfred.hanke@tngtech.com>
which were introduced with TNG/ArchUnit-Examples#14 so `./gradlew updateArchUnitExample` also updates them, not only the Gradle build files (see result in `build/example-update/`) Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
using the Gradle wrapper from the ArchUnit repository, which is automatically updated, so `./gradlew updateArchUnitExample` also updates it for the ArchUnit-Examples repository (see result in `build/example-update/`) Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
Not updating maven-surefire-plugin beyond 3.0.0-M3: Since apache/maven-surefire#214, `surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java` uses `className = testPlan.getParent(testIdentifier).getDisplayName()` instead of `org.junit.platform.launcher.listeners.LegacyReportingUtils.getClassName(testPlan, testIdentifier)` for `TestSource`s that are neither a `MethodSource` nor a `ClassSource` (including ArchUnit's `FieldSource`, created by `ArchUnitRuleDescriptor`), which causes the test report's testcase/@classname to not contain fully qualified class names anymore, which breaks `TestResultTest` (`./gradlew :archunit-maven-test:verifyRulesJUnit5`). Signed-off-by: Manfred Hanke <manfred.hanke@tngtech.com>
hankem
force-pushed
the
update-Maven-examples
branch
from
c61e9e0 to
2ceef68
Compare
hankem
commented
Jul 3, 2026
| @@ -4,17 +4,19 @@ ext.archunitExamplesGitRepo = 'TNG/ArchUnit-Examples.git' | |||
| ext.updateArchUnitExampleVersion = { File archUnitExampleDir -> | |||
Member
Author
There was a problem hiding this comment.
can be tested with
./gradlew clean updateArchUnitExample && cd build/example-update/ && git diff
(noting that release.sh additionally does && git add -A && git commit -s -m "release ArchUnit $VERSION" && git push).
Comment on lines
-73
to
+81
| <version>2.22.2</version> | ||
| <version>3.0.0-M3</version> <!-- Since 3.0.0-M4, the test report for JUnit5 tests does not contain fully qualified names in testcase/@classname anymore. --> | ||
| <configuration> | ||
| <argLine>-Xmx2G</argLine> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.8.1</version> | ||
| <version>3.15.0</version> |
Contributor
There was a problem hiding this comment.
These collide with a change on #1659:
I prefer my approach where this is covered by dependabot
Member
Author
There was a problem hiding this comment.
I like your approach, and I don't think it's a semantic conflict, but that they complement each other nicely:
- This PR is to update https://github.com/TNG/ArchUnit-Examples based on the version in the ArchUnit repository
- Your PR allows the version in the ArchUnit repository to be updated automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the tasks triggered by
updateArchUnitExample(in particular for every release), which update the ArchUnit-Examples, byIt also updates the example dependencies and Maven & Maven plugin version used in archunit-maven-test