Update Gradle Wrapper from 8.14.3 to 9.5.0 & also run tests with JDK 25

.github/workflows/build.yml

@@ -8,7 +8,7 @@ on:
   pull_request:
 
 env:
-  build_java_version: 21
+  build_java_version: 25
 
 jobs:
   build:
@@ -48,6 +48,7 @@ jobs:
           - 11
           - 17
           - 21
+          - 25
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout
@@ -97,6 +98,7 @@ jobs:
           - 11
           - 17
           - 21
+          - 25
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout

.github/workflows/update-gradle-wrapper.yml

@@ -15,7 +15,7 @@ jobs:
         uses: actions/setup-java@v5.2.0
         with:
           distribution: 'zulu'
-          java-version: 17
+          java-version: 25
 
       - name: Update Gradle Wrapper
         uses: gradle-update/update-gradle-wrapper-action@v2.1.0

CONTRIBUTING.md

@@ -4,14 +4,14 @@ Contributions are very welcome. The following will provide some helpful guidelin
 
 ## How to build the project
 
-ArchUnit requires at least JDK 15 to build.
+ArchUnit requires at least JDK 25 to build.
 The following is just an example input/output from a Unix command line.
 Windows users should use `gradlew.bat` instead.
 
 ```
 $ cd /path/to/git/clone/of/ArchUnit
 $ ./gradlew showJdkVersion
-Configured JDK: 15
+Configured JDK: 25
 $ ./gradlew build
 ```
 

archunit/build.gradle

@@ -92,7 +92,7 @@ compileJdk9mainJava {
     dependsOn(compileJava)
     ext.minimumJavaVersion = JavaVersion.VERSION_1_9
 
-    destinationDir = compileJava.destinationDir
+    destinationDirectory.set(compileJava.destinationDirectory.get())
 }
 javadoc.dependsOn(compileJdk9mainJava)
 spotbugsMain.dependsOn(compileJdk9mainJava)

archunit/src/test/java/com/tngtech/archunit/core/importer/ClassFileImporterAccessesTest.java

@@ -104,6 +104,7 @@
 import static com.tngtech.archunit.core.domain.TestUtils.targetFrom;
 import static com.tngtech.archunit.core.importer.ClassFileImporterTestUtils.findAnyByName;
 import static com.tngtech.archunit.core.importer.ClassFileImporterTestUtils.getByName;
+import static com.tngtech.archunit.core.importer.ClassFileImporterTestUtils.getMethodCallsFromClassWithoutAutomaticNullCheck;
 import static com.tngtech.archunit.core.importer.DomainBuilders.newMethodCallTargetBuilder;
 import static com.tngtech.archunit.testutil.Assertions.assertThat;
 import static com.tngtech.archunit.testutil.Assertions.assertThatAccess;
@@ -457,9 +458,10 @@ String covariantlyOverriddenCausingBridgeMethod() {
         }
 
         JavaMethodCall callFromBridgeMethodToOverriddenOne = getOnlyElement(
-                new ClassFileImporter().importClasses(Parent.class, Child.class)
-                        .get(Child.class)
-                        .getMethodCallsFromSelf());
+                getMethodCallsFromClassWithoutAutomaticNullCheck(
+                        new ClassFileImporter().importClasses(Parent.class, Child.class)
+                                .get(Child.class)
+                ));
         JavaCodeUnit bridgeMethod = callFromBridgeMethodToOverriddenOne.getOrigin();
 
         assertThat(bridgeMethod.getName()).isEqualTo("covariantlyOverriddenCausingBridgeMethod");
@@ -1146,10 +1148,11 @@ void call(Target target) {
             }
         }
 
-        JavaMethodCall call = getOnlyElement(new ClassFileImporter()
-                .importClasses(Origin.class, Target.class)
-                .get(Origin.class)
-                .getMethodCallsFromSelf());
+        JavaMethodCall call = getOnlyElement(
+                getMethodCallsFromClassWithoutAutomaticNullCheck(
+                        new ClassFileImporter().importClasses(Origin.class, Target.class)
+                                .get(Origin.class)
+                ));
 
         assertThat(call.getTarget().getParameterTypes())
                 .isEqualTo(call.getTarget().getRawParameterTypes());
@@ -1193,10 +1196,11 @@ void call(Target target) {
             }
         }
 
-        JavaClass origin = new ClassFileImporter().importClasses(Origin.class, Target.class).get(Origin.class);
-
-        assertThat(origin.getMethodCallsFromSelf()).hasSize(2);
-        for (JavaMethodCall call : origin.getMethodCallsFromSelf()) {
+        JavaClass origin = new ClassFileImporter().importClasses(Origin.class, Target.class)
+                .get(Origin.class);
+        Set<JavaMethodCall> methodCallsFromSelf = getMethodCallsFromClassWithoutAutomaticNullCheck(origin);
+        assertThat(methodCallsFromSelf).hasSize(2);
+        for (JavaMethodCall call : methodCallsFromSelf) {
             assertThatCall(call).isTo("callMe");
         }
     }

archunit/src/test/java/com/tngtech/archunit/core/importer/ClassFileImporterAutomaticResolutionTest.java

@@ -51,6 +51,7 @@
 import org.junit.runner.RunWith;
 
 import static com.google.common.collect.Iterables.getOnlyElement;
+import static com.tngtech.archunit.core.importer.ClassFileImporterTestUtils.getMethodCallsFromClassWithoutAutomaticNullCheck;
 import static com.tngtech.archunit.core.importer.DependencyResolutionProcess.MAX_ITERATIONS_FOR_ACCESSES_TO_TYPES_PROPERTY_NAME;
 import static com.tngtech.archunit.core.importer.DependencyResolutionProcess.MAX_ITERATIONS_FOR_ANNOTATION_TYPES_PROPERTY_NAME;
 import static com.tngtech.archunit.core.importer.DependencyResolutionProcess.MAX_ITERATIONS_FOR_ENCLOSING_TYPES_DEFAULT_VALUE;
@@ -351,7 +352,7 @@ void resolvesMethodCallTargetOwner() {
 
         JavaClass javaClass = ImporterWithAdjustedResolutionRuns.disableAllIterationsExcept(MAX_ITERATIONS_FOR_ACCESSES_TO_TYPES_PROPERTY_NAME)
                 .importClass(Origin.class);
-        JavaMethodCall call = getOnlyElement(javaClass.getMethodCallsFromSelf());
+        JavaMethodCall call = getOnlyElement(getMethodCallsFromClassWithoutAutomaticNullCheck(javaClass));
 
         assertThat(call.getTargetOwner()).isFullyImported(true);
     }

archunit/src/test/java/com/tngtech/archunit/core/importer/ClassFileImporterLambdaDependenciesTest.java

@@ -34,6 +34,7 @@
 import static com.tngtech.archunit.core.domain.Formatters.formatNamesOf;
 import static com.tngtech.archunit.core.domain.JavaConstructor.CONSTRUCTOR_NAME;
 import static com.tngtech.archunit.core.domain.properties.HasName.Utils.namesOf;
+import static com.tngtech.archunit.core.importer.ClassFileImporterTestUtils.getMethodCallsFromClassWithoutAutomaticNullCheck;
 import static com.tngtech.archunit.core.importer.JavaClassDescriptorImporterTestUtils.isLambdaMethodName;
 import static com.tngtech.archunit.testutil.Assertions.assertThat;
 import static com.tngtech.archunit.testutil.Assertions.assertThatAccess;
@@ -68,7 +69,7 @@ Runnable call() {
         }
 
         JavaClasses classes = new ClassFileImporter().importClasses(Target.class, Caller.class);
-        JavaMethodCall call = getOnlyElement(classes.get(Caller.class).getMethodCallsFromSelf());
+        JavaMethodCall call = getOnlyElement(getMethodCallsFromClassWithoutAutomaticNullCheck(classes.get(Caller.class)));
 
         assertThatCall(call).isFrom("call").isTo(Target.class, "target");
     }
@@ -172,7 +173,7 @@ Consumer<String> call() {
         }
 
         JavaClasses classes = new ClassFileImporter().importClasses(Target.class, Caller.class);
-        JavaMethodCall call = getOnlyElement(classes.get(Caller.class).getMethodCallsFromSelf());
+        JavaMethodCall call = getOnlyElement(getMethodCallsFromClassWithoutAutomaticNullCheck(classes.get(Caller.class)));
 
         assertThatCall(call).isFrom("call").isTo(Target.class, "target", String.class);
     }
@@ -196,7 +197,7 @@ Supplier<String> call() {
         }
 
         JavaClasses classes = new ClassFileImporter().importClasses(Target.class, Caller.class);
-        JavaMethodCall call = getOnlyElement(classes.get(Caller.class).getMethodCallsFromSelf());
+        JavaMethodCall call = getOnlyElement(getMethodCallsFromClassWithoutAutomaticNullCheck(classes.get(Caller.class)));
 
         assertThatCall(call).isFrom("call").isTo(Target.class, "target");
     }
@@ -252,7 +253,7 @@ Runnable call() {
         }
 
         JavaClasses classes = new ClassFileImporter().importClasses(Target.class, Caller.class);
-        Set<JavaMethodCall> calls = classes.get(Caller.class).getMethodCallsFromSelf();
+        Set<JavaMethodCall> calls = getMethodCallsFromClassWithoutAutomaticNullCheck(classes.get(Caller.class));
 
         assertThat(calls).hasSize(2);
         calls.forEach(call -> assertThatCall(call).isFrom("call").isTo(Target.class, "target"));
@@ -285,7 +286,7 @@ Function<String, Target> call2() {
         }
 
         JavaClasses classes = new ClassFileImporter().importClasses(Target.class, Caller.class);
-        Set<JavaMethodCall> calls = classes.get(Caller.class).getMethodCallsFromSelf();
+        Set<JavaMethodCall> calls = getMethodCallsFromClassWithoutAutomaticNullCheck(classes.get(Caller.class));
         assertThat(calls).hasSize(5);
 
         assertThat(filterOriginByName(calls, "call1"))
@@ -361,10 +362,10 @@ Supplier<String> call() {
 
         JavaClasses classes = new ClassFileImporter().importClasses(Target.class, Caller1.class, Caller2.class);
 
-        JavaMethodCall call1 = getOnlyElement(classes.get(Caller1.class).getMethodCallsFromSelf());
+        JavaMethodCall call1 = getOnlyElement(getMethodCallsFromClassWithoutAutomaticNullCheck(classes.get(Caller1.class)));
         assertThatCall(call1).isFrom("call").isTo(Target.class, "target");
 
-        JavaMethodCall call2 = getOnlyElement(classes.get(Caller2.class).getMethodCallsFromSelf());
+        JavaMethodCall call2 = getOnlyElement(getMethodCallsFromClassWithoutAutomaticNullCheck(classes.get(Caller2.class)));
         assertThatCall(call2).isFrom("call").isTo(Target.class, "target");
     }
 

archunit/src/test/java/com/tngtech/archunit/core/importer/ClassFileImporterTestUtils.java

@@ -4,19 +4,22 @@
 import java.net.JarURLConnection;
 import java.net.URLConnection;
 import java.util.HashSet;
+import java.util.Objects;
 import java.util.Set;
 import java.util.jar.JarFile;
 
 import com.tngtech.archunit.core.domain.JavaClass;
 import com.tngtech.archunit.core.domain.JavaCodeUnit;
 import com.tngtech.archunit.core.domain.JavaField;
 import com.tngtech.archunit.core.domain.JavaMethod;
+import com.tngtech.archunit.core.domain.JavaMethodCall;
 import com.tngtech.archunit.core.domain.properties.HasName;
 
 import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.collect.Iterables.getFirst;
 import static com.tngtech.archunit.testutil.TestUtils.urlOf;
+import static java.util.stream.Collectors.toSet;
 
 class ClassFileImporterTestUtils {
 
@@ -64,4 +67,19 @@ static JarFile jarFileOf(Class<?> clazzInJar) throws IOException {
         checkArgument(connection instanceof JarURLConnection, "Class %s is not contained in a JAR", clazzInJar.getName());
         return ((JarURLConnection) connection).getJarFile();
     }
+
+    /**
+     * @return {@link JavaClass#getMethodCallsFromSelf()} excluding {@link Objects#requireNonNull(Object)} calls
+     * from the constructor, which the JDK 25+ compiler automatically emits in inner classes,
+     * to normalize test results over multiple JDKs
+     * @see <a href="https://inside.java/2025/04/04/quality-heads-up/">New Null Checks in Inner Class Constructors</a>
+     */
+    static Set<JavaMethodCall> getMethodCallsFromClassWithoutAutomaticNullCheck(JavaClass javaClass) {
+        return javaClass.getMethodCallsFromSelf().stream()
+                .filter(call -> {
+                    return !(call.getOrigin().isConstructor() && call.getOriginOwner().isInnerClass() &&
+                            call.getTargetOwner().isEquivalentTo(Objects.class) && call.getTarget().getName().equals("requireNonNull"));
+                })
+                .collect(toSet());
+    }
 }

build.gradle

@@ -46,7 +46,7 @@ ext {
     ]
 
     minSupportedJavaVersion = JavaVersion.VERSION_1_8
-    maxSupportedJavaVersion = JavaVersion.VERSION_21
+    maxSupportedJavaVersion = JavaVersion.VERSION_25
     isTestBuild = project.hasProperty('testJavaVersion')
     configuredTestJavaVersion = project.findProperty('testJavaVersion')?.toString()?.with { JavaVersion.toVersion(it) }
     assert configuredTestJavaVersion <= maxSupportedJavaVersion:

buildSrc/src/main/groovy/archunit.java-release-publishing-conventions.gradle

@@ -28,7 +28,7 @@ tasks.withType(AbstractPublishToMaven) {
 publishing {
     publications {
         mavenJava(MavenPublication) {
-            artifactId = project.archivesBaseName
+            artifactId = project.name
             from components.java
             pom {
                 name = app.name

buildSrc/src/main/groovy/archunit.java-version-conventions.gradle

@@ -3,7 +3,8 @@ class VersionSpec {
             JavaVersion.VERSION_1_8,
             JavaVersion.VERSION_11,
             JavaVersion.VERSION_17,
-            JavaVersion.VERSION_21
+            JavaVersion.VERSION_21,
+            JavaVersion.VERSION_25,
     ] as SortedSet
 
     JavaVersion desiredJdkVersion
@@ -43,11 +44,10 @@ afterEvaluate {
         toolchain {
             languageVersion = versionSpec.desiredJavaLanguageVersion
         }
+        sourceCompatibility = versionSpec.desiredSourceCompatibility
+        targetCompatibility = versionSpec.desiredSourceCompatibility
     }
 
-    sourceCompatibility = versionSpec.desiredSourceCompatibility
-    targetCompatibility = versionSpec.desiredSourceCompatibility
-
     tasks.withType(JavaCompile) { Task task ->
         VersionSpec taskVersionSpec = versionSpec.withLowerLtsVersionBoundCompatibleWith(getMinTaskJavaVersion(task))
         println "Task ${task.name} configured: ${taskVersionSpec.describe()}"

buildSrc/src/main/groovy/archunit.license-conventions.gradle

@@ -29,7 +29,7 @@ dependencies {
 def parseLicenseInfoFrom = { config ->
     def pom = config.resolve().find { it.name.endsWith('.pom') }
 
-    def projectNode = new XmlParser().parse(pom)
+    def projectNode = new groovy.xml.XmlParser().parse(pom)
     def licenses = projectNode.licenses.license
     assert licenses.size() == 1: 'Can only handle one declared license at the moment'
 

gradle/wrapper/gradle-wrapper.properties

@@ -1,8 +1,10 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionSha256Sum=bd71102213493060956ec229d946beee57158dbd89d0e62b91bca0fa2c5f3531
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
+distributionSha256Sum=553c78f50dafcd54d65b9a444649057857469edf836431389695608536d6b746
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
 networkTimeout=10000
+retries=0
+retryBackOffMs=500
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists