Skip to content

Commit 9318d25

Browse files
committed
fix aliases to be just list of names
1 parent bdf82a2 commit 9318d25

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

tom_dataservices/dataservices.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -220,17 +220,17 @@ def query_reduced_data(self, query_parameters, **kwargs):
220220
'spectroscopy': spec_results,
221221
'forced_photometry': forced_phot_results}
222222

223-
def query_aliases(self, query_parameters, **kwargs) -> List[dict]:
223+
def query_aliases(self, query_parameters, **kwargs) -> List:
224224
"""
225225
Set up and run a specialized query for retrieving target names from a DataService.
226226
This method will usually call `query_service()` and translate the results from the dataservice into a
227-
list of dictionaries describing the returned target names.
227+
list of target names.
228228
229229
:param query_parameters: This is the output from build_query_parameters()
230-
:return: A list of dictionaries describing the resulting target names
231-
:rtype: List[dict]
230+
:return: A list of target names
231+
:rtype: List
232232
"""
233-
return [{}]
233+
return []
234234

235235
def query_targets(self, query_parameters, **kwargs) -> List[dict]:
236236
"""
@@ -297,7 +297,7 @@ def to_target(self, target_result=None, **kwargs) -> Tuple[dict, dict, dict]:
297297
else:
298298
target = self.create_target_from_query(target_result, **kwargs)
299299
extras = self.create_target_extras_from_query(target_result, **kwargs)
300-
aliases = self.create_aliases_from_query(target_result.get('aliases', [{}]), **kwargs)
300+
aliases = self.create_aliases_from_query(target_result.get('aliases', []), **kwargs)
301301
return target, extras, aliases
302302

303303
def create_target_from_query(self, target_result, **kwargs):
@@ -315,7 +315,7 @@ def create_target_extras_from_query(self, query_results, **kwargs):
315315
"""
316316
return {}
317317

318-
def create_aliases_from_query(self, alias_results:List[dict], **kwargs)->List:
318+
def create_aliases_from_query(self, alias_results:List, **kwargs)->List:
319319
"""Create a new target from the query results
320320
This method should be over ridden with a method that creates a list of TargetName objects:
321321
`TargetName(name=alias)` that will be saved as part of the `Target.save(extras=extras, names=aliases)` call.

0 commit comments

Comments
 (0)