1485 remove broker code in v3#1559
Conversation
There was a problem hiding this comment.
We are skipping all of the tom_alerts tests for now, so they don't pollute our test suite.
There was a problem hiding this comment.
This change allows for this migration to be referenced by TOMS that have already run this migration.
New TOMs should use the squashed 11-15 migration below.
This migration should be able to be removed a reasonable time after release of V3 once TOMs have fully migrated.
There was a problem hiding this comment.
This squashed migration will replace migrations 11-15 for new TOMs and TOMs that have already completed all 5 migrations.
There was a problem hiding this comment.
New migration to remove reference to tom_alerts.
Needs to be run before squashed migration applies if 0011-0014 has been run
There was a problem hiding this comment.
Removed this functionality since it didn't work. Could be re-routed to use refactored updatereduceddata.py management command above.
There was a problem hiding this comment.
We should re-establish these tests when we fix sharing, but these only use Hermes at the moment.
| source_location = models.CharField(max_length=200, default='', blank=True) | ||
| timestamp = models.DateTimeField(null=False, blank=False, default=timezone.now, db_index=True) | ||
| value = models.JSONField(null=False, blank=False) | ||
| message = models.ManyToManyField(AlertStreamMessage, blank=True) |
There was a problem hiding this comment.
This is the problem field that we removed.
This was used to track provenience of a datum that was retrieved via a hermes alert message.
1 participant
This severs the broker code in tom_alerts from the rest of tom_base
24 of these files are docs changes. Mostly changing wording from alerts to dataservices
Currently we are not removing either
tom_catalogsortom_alerts. These apps will still be available if they are used by custom code. They should be considered deprecated though, and users should work on transferring any references to tom_dataservices.There is a little bit of complicated migration magic that needs to happen here. I think it should all be transparent and seamless as long as the
tom_alertsapp is removed from installed apps AFTER a migration is run for existing TOMs. The other situation is that someone has migrated tom_dataproducts migration 0011, but not 0013. This seems very unlikely though.