Skip to content

chore: cut AMP (provekit-mint-amp + algebraic_mint subcommands)#1545

Merged
TSavo merged 1 commit into
mainfrom
chore/cut-amp-algebraic-mint
May 27, 2026
Merged

chore: cut AMP (provekit-mint-amp + algebraic_mint subcommands)#1545
TSavo merged 1 commit into
mainfrom
chore/cut-amp-algebraic-mint

Conversation

@TSavo

@TSavo TSavo commented May 27, 2026

Copy link
Copy Markdown
Owner

Scope-census deletion (cut 3 of 8)

Removes the Algebraic Memento Protocol layer: provekit-mint-amp crate + the seven mint subcommands (algorithm/binding/sort/equation/effect-signature/language-signature/language-morphism) and their run_algebraic_mint dispatch + signer_from_args/print_algebraic_error helpers in cmd_mint.

AMP is the algebraic cross-language experiment (sorts/equations/algorithms/morphisms) tied to the homomorphic-algebra/migrate direction. Not in the shared-language dictionary. Out of scope per CODE-VS-DICTIONARY.md (T + grounded). The core loop (ir-symbolic, claim-envelope, lifters, realizers, verifier) has zero dependency on it; contracts carry sorts inline, emission/verify never consume AMP equations.

IR sorts in ir-types/ir-symbolic (FOL core) are untouched — that's the dictionary-recognized sort handling, distinct from AMP's mint_sort.

Consumer map (verified)

  • Only cmd_mint referenced it (now pruned) + the crate's own tests.
  • No CI/Makefile/menagerie wiring (the only amp hits in ci.yml are "Vampire").
  • No test invokes the algebraic mint subcommands; cli_surface uses only the flag-based mint path.

Verification

  • Workspace resolves clean; cmd_mint surgery compiles.
  • Rust suite: zero new failures vs the prior env baseline — identical 14 kit-provisioning failures (python-sqlite3 shim / C projector / local swift), no mint/amp/algebraic failures. CI is the authoritative gate.

🤖 Generated with Claude Code

Removes the Algebraic Memento Protocol (AMP) layer: provekit-mint-amp
crate + the seven `mint` subcommands (algorithm/binding/sort/equation/
effect-signature/language-signature/language-morphism) and their
run_algebraic_mint dispatch + helpers in cmd_mint.

AMP is the algebraic cross-language experiment (sorts/equations/algorithms/
morphisms) tied to the homomorphic-algebra/migrate direction, not in the
shared-language dictionary. Out of scope per CODE-VS-DICTIONARY.md
(T + grounded). The core loop (ir-symbolic, claim-envelope, lifters,
realizers, verifier) has ZERO dependency on it; contracts carry sorts
inline and emission/verify never consume AMP equations/algorithms.

IR sorts in ir-types/ir-symbolic (FOL core) are untouched.

Consumer surface: only cmd_mint referenced it (now pruned) + the crate's
own tests. No CI/Makefile/menagerie wiring. Workspace resolves clean;
rust suite shows zero new failures vs the prior env baseline (same 14
kit-provisioning failures: python-sqlite3 shim / C projector / local swift).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@TSavo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 5 minutes and 2 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 97324990-f01e-44ec-b87f-1dfec7bc8030

📥 Commits

Reviewing files that changed from the base of the PR and between f7202b9 and 1a1e4a4.

⛔ Files ignored due to path filters (1)
  • implementations/rust/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (25)
  • implementations/rust/Cargo.toml
  • implementations/rust/provekit-cli/Cargo.toml
  • implementations/rust/provekit-cli/src/cmd_mint.rs
  • implementations/rust/provekit-mint-amp/Cargo.toml
  • implementations/rust/provekit-mint-amp/README.md
  • implementations/rust/provekit-mint-amp/src/catalog.rs
  • implementations/rust/provekit-mint-amp/src/lib.rs
  • implementations/rust/provekit-mint-amp/src/signer.rs
  • implementations/rust/provekit-mint-amp/src/spec.rs
  • implementations/rust/provekit-mint-amp/tests/cid_collision_refused.rs
  • implementations/rust/provekit-mint-amp/tests/common.rs
  • implementations/rust/provekit-mint-amp/tests/fixtures/algorithm_branch_on_nonzero.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/binding_c_branch_on_nonzero.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/binding_python_branch_on_nonzero.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/effect_signature_c_control.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/equation_c_branch_identity.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/language_signature_c_c11.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/language_signature_llvm_ir.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/morphism_c_to_llvm_ir.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/sort_c_bool.spec.json
  • implementations/rust/provekit-mint-amp/tests/fixtures/sort_c_int.spec.json
  • implementations/rust/provekit-mint-amp/tests/mint_then_read_round_trips.rs
  • implementations/rust/provekit-mint-amp/tests/same_spec_yields_same_cid.rs
  • implementations/rust/provekit-mint-amp/tests/signature_roundtrips.rs
  • implementations/rust/provekit-mint-amp/tests/unsigned_refuses_production_path.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cut-amp-algebraic-mint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TSavo TSavo merged commit 6002316 into main May 27, 2026
18 checks passed
@TSavo TSavo deleted the chore/cut-amp-algebraic-mint branch May 27, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant