chore: cut AMP (provekit-mint-amp + algebraic_mint subcommands)#1545
Conversation
Removes the Algebraic Memento Protocol (AMP) layer: provekit-mint-amp crate + the seven `mint` subcommands (algorithm/binding/sort/equation/ effect-signature/language-signature/language-morphism) and their run_algebraic_mint dispatch + helpers in cmd_mint. AMP is the algebraic cross-language experiment (sorts/equations/algorithms/ morphisms) tied to the homomorphic-algebra/migrate direction, not in the shared-language dictionary. Out of scope per CODE-VS-DICTIONARY.md (T + grounded). The core loop (ir-symbolic, claim-envelope, lifters, realizers, verifier) has ZERO dependency on it; contracts carry sorts inline and emission/verify never consume AMP equations/algorithms. IR sorts in ir-types/ir-symbolic (FOL core) are untouched. Consumer surface: only cmd_mint referenced it (now pruned) + the crate's own tests. No CI/Makefile/menagerie wiring. Workspace resolves clean; rust suite shows zero new failures vs the prior env baseline (same 14 kit-provisioning failures: python-sqlite3 shim / C projector / local swift). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 5 minutes and 2 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (25)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Scope-census deletion (cut 3 of 8)
Removes the Algebraic Memento Protocol layer:
provekit-mint-ampcrate + the sevenmintsubcommands (algorithm/binding/sort/equation/effect-signature/language-signature/language-morphism) and theirrun_algebraic_mintdispatch +signer_from_args/print_algebraic_errorhelpers incmd_mint.AMP is the algebraic cross-language experiment (sorts/equations/algorithms/morphisms) tied to the homomorphic-algebra/migrate direction. Not in the shared-language dictionary. Out of scope per
CODE-VS-DICTIONARY.md(T + grounded). The core loop (ir-symbolic, claim-envelope, lifters, realizers, verifier) has zero dependency on it; contracts carry sorts inline, emission/verify never consume AMP equations.IR sorts in ir-types/ir-symbolic (FOL core) are untouched — that's the dictionary-recognized sort handling, distinct from AMP's
mint_sort.Consumer map (verified)
cmd_mintreferenced it (now pruned) + the crate's own tests.amphits in ci.yml are "Vampire").cli_surfaceuses only the flag-basedmintpath.Verification
🤖 Generated with Claude Code