Skip to content

Metadata reading#67

Merged
rogerkuou merged 18 commits into
mainfrom
metadata_reading
Jul 21, 2025
Merged

Metadata reading#67
rogerkuou merged 18 commits into
mainfrom
metadata_reading

Conversation

@rogerkuou
Copy link
Copy Markdown
Member

@rogerkuou rogerkuou commented Jul 14, 2025

Add functionalities to read res file metadata generated by doris v4 or v5.

Example files and file strutures are included as test data files under tests/data/metadata)

@rogerkuou rogerkuou requested a review from Copilot July 15, 2025 18:16

This comment was marked as resolved.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rogerkuou rogerkuou marked this pull request as ready for review July 15, 2025 18:19
@rogerkuou rogerkuou requested a review from fnattino July 15, 2025 18:25
@rogerkuou
Copy link
Copy Markdown
Member Author

@fnattino sorry for the delay! Can you help me review this PR?

This is regarding reading two types of metadata from Doris. I included the examples in test/data/metadata

Copy link
Copy Markdown
Contributor

@fnattino fnattino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rogerkuou, very nicely written and documented, very clear! I have left a couple of suggestions. Maybe these things do not make sense in the optics of the people that will actually make use of it, so feel free to discard any comment..

Comment thread sarxarray/_io.py Outdated
Comment thread sarxarray/_io.py
Comment thread sarxarray/_io.py Outdated
Comment thread sarxarray/_io.py
Comment thread sarxarray/_io.py
Comment thread sarxarray/_io.py Outdated
@rogerkuou
Copy link
Copy Markdown
Member Author

Hi @fnattino, I adapted most of your comments. Can you give another look when you have time? Thanks a lot for your review!

@rogerkuou rogerkuou requested a review from fnattino July 18, 2025 14:25
Copy link
Copy Markdown
Contributor

@fnattino fnattino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very minor (and probably un-necessary 🙂) suggestion - feel free to merge otherwise!

Comment thread sarxarray/_io.py Outdated
@sonarqubecloud
Copy link
Copy Markdown

@rogerkuou rogerkuou merged commit afdc397 into main Jul 21, 2025
17 checks passed
@rogerkuou rogerkuou deleted the metadata_reading branch March 30, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants