64 Native cropping in radar coordinates#86
Merged
Simon-van-Diepen merged 6 commits intomainfrom Apr 22, 2026
Merged
Conversation
Contributor
Author
|
I just realized I originally planned on doing this together with #85 instead of as a separate PR. @rogerkuou would you prefer to convert this to a draft and include #85 in the branch or keep them separate as they are now? |
rogerkuou
approved these changes
Apr 22, 2026
Member
|
Hi @Simon-van-Diepen , thanks for the implementation. I think it's nice to have this PR separated. I will review this one first I have one general comments here: Let's add support to bounding box in a simple tuple. Since the function is already here . After this it's good to merge! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shapelyfor geometryNecessary for #85
For TU Delft specific workflow, radarcoding is incorporated in the
DePSIpackage already. By keeping it there, it saves having to include radarcoding and polygon reading natively insarxarray.The Dataset or DataArray remains in grid format, hence the bounding box (min/max azimuth, min/max range) is used instead of a perfect cutout.