fix(server): name-based event PR titles and tidier batch PR bodies (#3275)

Event submissions previously produced misleading PRs: the title used the
opaque `event_<hash>` key, the body linked it to a 404 `/view/` page,
labelled every event an "addition" even when it replaced an existing one,
and embedded the poster full-bleed.

Events now render by their human name, distinguishing "add" from "update",
in an `event | image` table with a thumbnail-sized poster. Per-edit
`### Edit N` headers (which auto-linked `#N` to issues) are replaced by
`---` separators under a small `<sub>` label.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: CommanderStorm

server/src/routes/feedback/batch_processor/mod.rs

@@ -76,9 +76,9 @@ pub async fn update_batch_pr_metadata(
 
     // Append the new edit's description
     let updated_description = if current_description.is_empty() {
-        format!("## Batched Edits\n\n### Edit #{edit_count}\n{new_edit_description}")
+        format!("<sub>Batched edits</sub>\n\n{new_edit_description}")
     } else {
-        format!("{current_description}\n\n---\n\n### Edit #{edit_count}\n{new_edit_description}")
+        format!("{current_description}\n\n---\n\n{new_edit_description}")
     };
 
     let github = GitHub::default();

server/src/routes/feedback/proposed_edits/addition/building.rs

@@ -4,9 +4,9 @@ use std::path::Path;
 use serde::{Deserialize, Serialize};
 
 use super::super::coordinate::Coordinate;
-use super::AppliableAddition;
 use super::areatree::{AreatreeKind, format_line, insert_under};
 use super::validation::{AdditionError, AdditionVariant, CollisionSource, RepoSnapshot};
+use super::{AppliableAddition, AppliedAddition};
 
 const MAX_NAME_LEN: usize = 200;
 
@@ -136,7 +136,7 @@ impl AppliableAddition for NewBuilding {
         Ok(())
     }
 
-    fn apply(&self, _key: &str, base_dir: &Path, _branch: &str) -> anyhow::Result<String> {
+    fn apply(&self, _key: &str, base_dir: &Path, _branch: &str) -> anyhow::Result<AppliedAddition> {
         let areatree_path = base_dir
             .join("data")
             .join("processors")
@@ -167,14 +167,16 @@ impl AppliableAddition for NewBuilding {
             }
         }
 
-        Ok(self.coords.fenced_geojson_feature(&serde_json::json!({
-            "kind": "new-building",
-            "id": effective_id,
-            "name": self.name,
-            "node_kind": self.kind,
-            "parent_id": self.parent_id,
-            "building_prefixes": self.building_prefixes,
-        })))
+        Ok(AppliedAddition::created(
+            self.coords.fenced_geojson_feature(&serde_json::json!({
+                "kind": "new-building",
+                "id": effective_id,
+                "name": self.name,
+                "node_kind": self.kind,
+                "parent_id": self.parent_id,
+                "building_prefixes": self.building_prefixes,
+            })),
+        ))
     }
 
     fn kind_label(&self) -> &'static str {
@@ -302,7 +304,8 @@ mod tests {
 
         let summary = sample_building()
             .apply("0103", dir.path(), "branch")
-            .unwrap();
+            .unwrap()
+            .summary;
         assert_snapshot!(summary, @r#"
         ```geojson
         {

server/src/routes/feedback/proposed_edits/addition/event.rs

@@ -10,8 +10,8 @@ use serde::Deserialize;
 use super::super::AppliableEdit as _;
 use super::super::coordinate::Coordinate;
 use super::super::image::Image;
-use super::AppliableAddition;
 use super::validation::{AdditionError, RepoSnapshot};
+use super::{AppliableAddition, AppliedAddition};
 
 const MAX_NAME_LEN: usize = 200;
 /// The photo marker renders a 256×256 thumb crop, so smaller uploads would be upscaled.
@@ -239,29 +239,34 @@ impl AppliableAddition for NewEvent {
         Ok(())
     }
 
-    fn apply(&self, key: &str, base_dir: &Path, branch: &str) -> anyhow::Result<String> {
+    fn apply(&self, key: &str, base_dir: &Path, branch: &str) -> anyhow::Result<AppliedAddition> {
         let csv_path = events_csv_path(base_dir);
         let raw = fs::read(&csv_path)?;
         // Content-addressed key, so always the first slot.
         let image = format!("/cdn/thumb/{key}_0.webp");
         // Identity = key: an existing row under this key makes the addition an update.
-        let (verb, image_md) = if let Some(row) = matching_row_range(&raw, key)? {
-            let image_md = self.image.replace(key, base_dir, branch)?;
+        let replaced = if let Some(row) = matching_row_range(&raw, key)? {
+            self.image.replace(key, base_dir, branch)?;
             self.replace_events_row(&image, &csv_path, &raw, row)?;
-            ("update", image_md)
+            true
         } else {
-            let image_md = self.image.apply(key, base_dir, branch)?;
+            self.image.apply(key, base_dir, branch)?;
             self.append_events_row(&image, &csv_path)?;
-            ("new", image_md)
+            false
         };
 
-        Ok(format!(
-            "{verb} event `{name}` ({starts_at} - {ends_at}, org `{org}`)\n\n{image_md}",
-            name = self.name,
-            starts_at = format_de(&self.starts_at)?,
-            ends_at = format_de(&self.ends_at)?,
-            org = self.organising_org_id,
-        ))
+        let verb = if replaced { "update" } else { "new" };
+        Ok(AppliedAddition {
+            summary: format!(
+                "{verb} event \"{name}\" ({starts_at} - {ends_at}, org `{org}`)",
+                name = self.name,
+                starts_at = format_de(&self.starts_at)?,
+                ends_at = format_de(&self.ends_at)?,
+                org = self.organising_org_id,
+            ),
+            image_url: Some(Image::raw_lg_url(key, branch)?),
+            replaced,
+        })
     }
 
     fn kind_label(&self) -> &'static str {
@@ -514,14 +519,20 @@ mod tests {
         )
         .unwrap();
 
-        let summary = sample_event()
+        let applied = sample_event()
             .apply("event_9d02ddd940c43f87", dir.path(), "branch")
             .unwrap();
-        assert_snapshot!(summary, @r"
-        update event `GARNIX Festival` (10.6.26 16:00 - 12.6.26 23:00, org `51897`)
-
-        ![image showing event_9d02ddd940c43f87](https://raw.githubusercontent.com/TUM-Dev/NavigaTUM/refs/heads/branch/data/sources/img/lg/event_9d02ddd940c43f87_0.webp)
-        ");
+        assert!(applied.replaced);
+        assert_eq!(
+            applied.summary,
+            "update event \"GARNIX Festival\" (10.6.26 16:00 - 12.6.26 23:00, org `51897`)"
+        );
+        assert_eq!(
+            applied.image_url.as_deref(),
+            Some(
+                "https://raw.githubusercontent.com/TUM-Dev/NavigaTUM/refs/heads/branch/data/sources/img/lg/event_9d02ddd940c43f87_0.webp"
+            )
+        );
 
         let csv = fs::read_to_string(sources.join("events.csv")).unwrap();
         assert_snapshot!(csv, @r#"
@@ -609,14 +620,20 @@ mod tests {
         )
         .unwrap();
 
-        let summary = sample_event()
+        let applied = sample_event()
             .apply("event_9d02ddd940c43f87", dir.path(), "branch")
             .unwrap();
-        assert_snapshot!(summary, @r"
-        new event `GARNIX Festival` (10.6.26 16:00 - 12.6.26 23:00, org `51897`)
-
-        ![image showing event_9d02ddd940c43f87](https://raw.githubusercontent.com/TUM-Dev/NavigaTUM/refs/heads/branch/data/sources/img/lg/event_9d02ddd940c43f87_0.webp)
-        ");
+        assert!(!applied.replaced);
+        assert_eq!(
+            applied.summary,
+            "new event \"GARNIX Festival\" (10.6.26 16:00 - 12.6.26 23:00, org `51897`)"
+        );
+        assert_eq!(
+            applied.image_url.as_deref(),
+            Some(
+                "https://raw.githubusercontent.com/TUM-Dev/NavigaTUM/refs/heads/branch/data/sources/img/lg/event_9d02ddd940c43f87_0.webp"
+            )
+        );
 
         let csv = fs::read_to_string(sources.join("events.csv")).unwrap();
         assert_snapshot!(csv, @r#"

server/src/routes/feedback/proposed_edits/addition/mod.rs

@@ -28,10 +28,31 @@ pub enum Addition {
 
 pub trait AppliableAddition {
     fn validate(&self, key: &str, snap: &RepoSnapshot) -> Result<(), AdditionError>;
-    fn apply(&self, key: &str, base_dir: &Path, branch: &str) -> anyhow::Result<String>;
+    fn apply(&self, key: &str, base_dir: &Path, branch: &str) -> anyhow::Result<AppliedAddition>;
     fn kind_label(&self) -> &'static str;
 }
 
+/// The result of applying an [`Addition`], as the PR description renders it.
+pub struct AppliedAddition {
+    /// One-line human summary for the PR body.
+    pub summary: String,
+    /// Image to show beside the summary (events only).
+    pub image_url: Option<String>,
+    /// Whether an existing entry was replaced rather than created (events only).
+    pub replaced: bool,
+}
+
+impl AppliedAddition {
+    /// A new addition with no image.
+    pub fn created(summary: String) -> Self {
+        Self {
+            summary,
+            image_url: None,
+            replaced: false,
+        }
+    }
+}
+
 impl Addition {
     fn as_appliable(&self) -> &dyn AppliableAddition {
         match self {
@@ -46,13 +67,26 @@ impl Addition {
         self.as_appliable().validate(key, snap)
     }
 
-    pub fn apply(&self, key: &str, base_dir: &Path, branch: &str) -> anyhow::Result<String> {
+    pub fn apply(
+        &self,
+        key: &str,
+        base_dir: &Path,
+        branch: &str,
+    ) -> anyhow::Result<AppliedAddition> {
         self.as_appliable().apply(key, base_dir, branch)
     }
 
     pub fn kind_label(&self) -> &'static str {
         self.as_appliable().kind_label()
     }
+
+    /// The event's name, or `None` for non-event additions.
+    pub fn event_name(&self) -> Option<&str> {
+        match self {
+            Self::Event(e) => Some(&e.name),
+            _ => None,
+        }
+    }
 }
 
 #[cfg(test)]

server/src/routes/feedback/proposed_edits/addition/poi.rs

@@ -5,8 +5,8 @@ use std::path::Path;
 use serde::{Deserialize, Serialize};
 
 use super::super::coordinate::Coordinate;
-use super::AppliableAddition;
 use super::validation::{AdditionError, CollisionSource, RepoSnapshot};
+use super::{AppliableAddition, AppliedAddition};
 
 const MAX_NAME_LEN: usize = 200;
 const MAX_KEY_LEN: usize = 64;
@@ -122,7 +122,7 @@ impl AppliableAddition for NewPoi {
         Ok(())
     }
 
-    fn apply(&self, key: &str, base_dir: &Path, _branch: &str) -> anyhow::Result<String> {
+    fn apply(&self, key: &str, base_dir: &Path, _branch: &str) -> anyhow::Result<AppliedAddition> {
         let yaml_path = base_dir.join("data").join("sources").join("21_pois.yaml");
         let raw = fs::read_to_string(&yaml_path).unwrap_or_default();
         let mut map: BTreeMap<String, serde_yaml::Value> = if raw.trim().is_empty() {
@@ -147,12 +147,12 @@ impl AppliableAddition for NewPoi {
         let out = serde_yaml::to_string(&map)?;
         fs::write(&yaml_path, out)?;
 
-        Ok(format!(
+        Ok(AppliedAddition::created(format!(
             "new POI `{key}` ({name}, usage `{usage}`, parent `{parent}`)",
             name = self.name,
             usage = self.usage_name,
             parent = self.parent,
-        ))
+        )))
     }
 
     fn kind_label(&self) -> &'static str {
@@ -263,7 +263,8 @@ mod tests {
 
         let summary = sample_poi()
             .apply("validierungsautomat-99", dir.path(), "branch")
-            .unwrap();
+            .unwrap()
+            .summary;
         assert_snapshot!(
             summary,
             @"new POI `validierungsautomat-99` (Validierungsautomat 99, usage `Validierungsautomat`, parent `5101.EG.917`)"

server/src/routes/feedback/proposed_edits/addition/room.rs

@@ -5,9 +5,9 @@ use std::path::Path;
 use serde::{Deserialize, Serialize};
 
 use super::super::coordinate::Coordinate;
-use super::AppliableAddition;
 use super::areatree::AreatreeKind;
 use super::validation::{AdditionError, AdditionVariant, CollisionSource, RepoSnapshot};
+use super::{AppliableAddition, AppliedAddition};
 
 #[derive(Debug, Deserialize, Serialize, Clone, utoipa::ToSchema)]
 pub struct RoomLink {
@@ -156,7 +156,7 @@ impl AppliableAddition for NewRoom {
         Ok(())
     }
 
-    fn apply(&self, key: &str, base_dir: &Path, _branch: &str) -> anyhow::Result<String> {
+    fn apply(&self, key: &str, base_dir: &Path, _branch: &str) -> anyhow::Result<AppliedAddition> {
         let yaml_path = base_dir
             .join("data")
             .join("sources")
@@ -185,13 +185,13 @@ impl AppliableAddition for NewRoom {
 
         self.coords.apply_to_csv(key, base_dir)?;
 
-        Ok(format!(
+        Ok(AppliedAddition::created(format!(
             "new room `{key}` ({alt}, arch_name `{arch}`, usage_id {uid}) @ {coords:?}",
             alt = self.alt_name,
             arch = self.arch_name,
             uid = self.usage_id,
             coords = self.coords,
-        ))
+        )))
     }
 
     fn kind_label(&self) -> &'static str {
@@ -331,7 +331,8 @@ mod tests {
         let dir = setup_apply_dir();
         let summary = sample_room()
             .apply("5117.EG.103", dir.path(), "branch")
-            .unwrap();
+            .unwrap()
+            .summary;
         assert_snapshot!(
             summary,
             @"new room `5117.EG.103` (Testraum, arch_name `EG103@5117`, usage_id 12) @ Coordinate { lat: 48.262, lon: 11.668 }"